Re: [Bro-Dev] Broker::publish API

2018-08-14 Thread Jon Siwek
On Tue, Aug 14, 2018 at 12:09 PM Jan Grashöfer wrote: > > On 13/08/18 18:24, Jon Siwek wrote: > > Old Worker: > > > >Cluster::relay_rr(Cluster::proxy_pool, my_event); > > > > New Worker: > > > >Broker::publish(Cluster::rr_topic(Cluster::proxy_pool), my_event); > > That doesn't look like

Re: [Bro-Dev] Broker::publish API

2018-08-14 Thread Jan Grashöfer
On 13/08/18 18:24, Jon Siwek wrote: > Old Worker: > >Cluster::relay_rr(Cluster::proxy_pool, my_event); > > New Worker: > >Broker::publish(Cluster::rr_topic(Cluster::proxy_pool), my_event); That doesn't look like an API simplification to me ;D > Even Newer Worker: > >

Re: [Bro-Dev] Broker::publish API

2018-08-14 Thread Robin Sommer
On Tue, Aug 14, 2018 at 10:51 -0500, Jonathan Siwek wrote: > Not sure, is Broker::auto_publish() currently able to do the same thing? Hmm .. Good point. Scope is different between the two (event vs topic) but the effect is similar in the end. > I can also see the opposite being intuitive: If

Re: [Bro-Dev] Broker::publish API

2018-08-14 Thread Jon Siwek
On Tue, Aug 14, 2018 at 10:13 AM Robin Sommer wrote: > One more question: what about raising published events locally as well > if the sending node is subscribed to the topic? I'm kind of torn on > that. I don't think we want that as a default, but perhaps as an > option, either with the

Re: [Bro-Dev] Broker::publish API

2018-08-14 Thread Robin Sommer
On Mon, Aug 13, 2018 at 13:55 -0500, Jonathan Siwek wrote: > associating node IDs with subscription state and also message state > (push node IDs into messages upon receipt before forwarding), Yeah, that sounds like the right direction. Some reading might be worthwile doing here, there are