Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Chet Ramey
On 11/25/23 1:32 PM, Emanuele Torre wrote: In any event, thanks for pointing out where the examples still need to change. No problem. :) I also noticed that examples/loadables/strptime is not in .gitignore. Thanks. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer

Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Emanuele Torre
On Sat, Nov 25, 2023 at 01:20:55PM -0500, Chet Ramey wrote: > On 11/24/23 9:40 PM, Emanuele Torre wrote: > > Many of the loadable builtins that set variables in the > > examples/loadables directory don't work anymore because they still want > > to call legal_identifier instead of valid_identifier.

Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Chet Ramey
On 11/24/23 9:40 PM, Emanuele Torre wrote: Many of the loadable builtins that set variables in the examples/loadables directory don't work anymore because they still want to call legal_identifier instead of valid_identifier. I haven't decided yet whether to use lib/sh/compat.c, in which case

Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Robert Elz
Date:Sat, 25 Nov 2023 08:53:48 +0100 From:Emanuele Torre Message-ID: | But the bash executable still does not contain the legal_ symbols: You'd only be getting symbols (.o files defining the symbols) loaded from an archive format library (.a file) if something

Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Andreas Schwab
On Nov 25 2023, Emanuele Torre wrote: > But the bash executable still does not contain the legal_ symbols: If bash does not reference any of the symbols in lib/sh/compat.c there is nothing pulling it in. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510

Re: Many of the example loadable builtins don't work anymore

2023-11-25 Thread Emanuele Torre
On Sat, Nov 25, 2023 at 08:53:48AM +0100, Emanuele Torre wrote: > Now I can see that compat.o is actually being used to create > lib/sh/libsh.a, and that libsh.a contains the legal_ symbols > > [...] > > But the bash executable still does not contain the legal_ symbols: > > $ grep -abo

Re: Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
On Sat, Nov 25, 2023 at 04:32:36AM +0100, Emanuele Torre wrote: > I've noticed that a lib/sh/compat.c file was added that still provides > the declaration for the legacy legal_ functions. > > The bash executable I was getting from building the devel branch did not > have those symbols though. >

Re: Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
I've noticed that a lib/sh/compat.c file was added that still provides the declaration for the legacy legal_ functions. The bash executable I was getting from building the devel branch did not have those symbols though. The reason was that lib/sh/Makefile was not getting regenerated, so the

Many of the example loadable builtins don't work anymore

2023-11-24 Thread Emanuele Torre
Many of the loadable builtins that set variables in the examples/loadables directory don't work anymore because they still want to call legal_identifier instead of valid_identifier. $ ./bash -c 'enable -f {examples/loadables/,}mktemp; mktemp' /tmp/shtmp.h2HpWZ $ ./bash -c 'enable -f