Re: [patch v2] glob: resolve DT_UNKNOWN via is_dir

2022-03-25 Thread DJ Delorie
Paul Eggert writes: >>> +# define dirfd(str) __dirfd (str) >> >> This needs an #undef before it, else it causes build errors as glibc >> already has a definition for dirfd() and it conflicts with this one. >> Prudence says they should *all* be protected as such, but I only mention >> the new

Re: Issue building gnulib with clang (as used in GRUB)

2022-03-25 Thread Jeffrey Walton
On Fri, Mar 25, 2022 at 10:00 AM Paul Eggert wrote: > > ... > > he possible > > security issue is that this size variable can be manipulated > > to enable mis-use via a stack overflow > That issue shouldn't happen here; i.e., the diagnostic is a false alarm. I believe the security issue is

Re: Issue building gnulib with clang (as used in GRUB)

2022-03-25 Thread Paul Eggert
On 3/24/22 12:16, Darren Kenny wrote: Is this a known issue when building with clang? Would you have any suggestions on how to correctly resolve it? I didn't know about the issue, or had forgotten about it. One way to resolve it would be to figure out what clang option is needed to suppress

Re: An confusing Coverity issue in regcomp.c

2022-03-25 Thread Darren Kenny
Thanks Bruno for confirming - certainly was confusing :) Thanks, Darren. On Thursday, 2022-03-24 at 20:34:45 +01, Bruno Haible wrote: > Hi Darren, > > I appreciate that you are, like Paul and me, looking into the > Coverity findings. > > You need to be aware that about 90% of the Coverity