Joan Lledó, le sam. 08 janv. 2022 13:15:37 +0100, a ecrit:
> From: Joan Lledó
>
> Use a internal array of pointers instead
Applied, thanks!
Samuel
> * pci-arbiter/device_map.h:
> * Update device_map_region() prototype
> * Now it receives an output address as parameter
> *
I updated the comment
From: Joan Lledó
Use a internal array of pointers instead
* pci-arbiter/device_map.h:
* Update device_map_region() prototype
* Now it receives an output address as parameter
* pci-arbiter/device_map.c:
* Update device_map_region() definition to match the new prototype
* Support for
Joan Lledó, le ven. 07 janv. 2022 12:09:55 +0100, a ecrit:
> > Rather >= ?
>
> No, libpciaccess accepts using the legacy method for addrress up to 0x10
> included.
Odd for the base part, but ok :)
But can't se just use the non-legacy mapping in all cases? That'd make
the code simpler.
Hello,
Joan Lledó, le ven. 07 janv. 2022 12:09:56 +0100, a ecrit:
> - err = pci_device_map_range (device, region->base_addr, region->size,
> - PCI_DEV_MAP_FLAG_WRITABLE, >memory);
> + /* Use the legacy call for regions under 1MB */
> + if
From: Joan Lledó
Use a internal array of pointers instead
* pci-arbiter/device_map.h:
* Update device_map_region() prototype
* Now it receives an output address as parameter
* pci-arbiter/device_map.c:
* Update device_map_region() definition to match the new prototype
* Support for
Hi,
> Rather >= ?
No, libpciaccess accepts using the legacy method for addrress up to 0x10
included.
> Also, why this address? Putting a comment there would be welcome to explain
> the magic number.
I'm taking the condition from here:
Joan Lledó, le mer. 05 janv. 2022 13:08:02 +0100, a ecrit:
> - if (region->memory == 0)
> + if (*addr == 0)
> {
> - err = pci_device_map_range (device, region->base_addr, region->size,
> - PCI_DEV_MAP_FLAG_WRITABLE, >memory);
> + if (region->base_addr
From: Joan Lledó
Use a internal array of pointers instead
* pci-arbiter/device_map.h:
* Update device_map_region() prototype
* Now it receives an output address as parameter
* pci-arbiter/device_map.c:
* Update device_map_region() definition to match the new prototype
* Support for
