This looks right to me.
Peter J. Philipp wrote:
> On Tue, Sep 14, 2021 at 10:48:44AM -0600, Theo de Raadt wrote:
> > Mark Kettenis wrote:
> >
> > > To be honest, I do think that adding __packed is a reasonable way to
> > > handle protocol structs like this where performance doesn't really
> >
On Tue, Sep 14, 2021 at 10:48:44AM -0600, Theo de Raadt wrote:
> Mark Kettenis wrote:
>
> > To be honest, I do think that adding __packed is a reasonable way to
> > handle protocol structs like this where performance doesn't really
> > matter. This translates into __attribute__((packed)) and
Mark Kettenis wrote:
> To be honest, I do think that adding __packed is a reasonable way to
> handle protocol structs like this where performance doesn't really
> matter. This translates into __attribute__((packed)) and both GCC and
> LLVM started treating that in a way to signal that the data
> Date: Tue, 14 Sep 2021 13:29:05 +
> From: Visa Hankala
>
> On Tue, May 04, 2021 at 07:29:20AM +0200, Peter J. Philipp wrote:
> > > Index: print-wg.c
> > > ===
> > > RCS file: /cvs/src/usr.sbin/tcpdump/print-wg.c,v
> > >
In tcpdump, we have generally used the "extract" approach rather
than __packed, for various reasons including potential encapculation
cases where compiler generated code has been insufficiently cynical --
meaning, __packed doesn't mean "must access everything as bytes".
Visa Hankala wrote:
> On
On Tue, Sep 14, 2021 at 01:29:05PM +, Visa Hankala wrote:
> On Tue, May 04, 2021 at 07:29:20AM +0200, Peter J. Philipp wrote:
[some of my earlier mail cut]
> data->nonce is the (most) offending variable because it needs 8-byte
> alignment.
>
> An alternative to memcpy() is to use tcpdump's
On Tue, May 04, 2021 at 07:29:20AM +0200, Peter J. Philipp wrote:
> > Index: print-wg.c
> > ===
> > RCS file: /cvs/src/usr.sbin/tcpdump/print-wg.c,v
> > retrieving revision 1.6
> > diff -u -p -u -r1.6 print-wg.c
> > --- print-wg.c
I have had similar for months on end and never been able to get more
information. Usually it stopped doing our after a while and sometimes
started again later. Currently it's not happening for me and I hope it
stays that way!
There is a chance you might get something from a kernel with
