RFR: JDK-8057537: Serialize reconfigure and fix make clean-foo foo

2014-09-04 Thread Erik Joelsson
Hello David, I hear your pain and when reading this got to thinking that separating clean and reconfigure targets shouldn't be that hard. I came up with this solution: Bug: https://bugs.openjdk.java.net/browse/JDK-8057537 Webrev: http://cr.openjdk.java.net/~erikj/8057537/webrev.root.01/ It

Re: serialize the reconfigure target ?

2014-09-04 Thread pointo1d
Hiya David , On 04/09/14 04:38, David Holmes wrote: I naively assumed this would work: make reconfigure images There should be a way to serialize the top-level set of targets without serializing all the sub-targets. That way this would work, as would: make clean-foo foo which is

Re: serialize the reconfigure target ?

2014-09-04 Thread pointo1d
Hi again David , On 04/09/14 04:38, David Holmes wrote: I naively assumed this would work: make reconfigure images There should be a way to serialize the top-level set of targets without serializing all the sub-targets. That way this would work, as would: make clean-foo foo which is

Re: RFR (preliminary): JDK-8056999 Make hotspot builds less verbose on default log level

2014-09-04 Thread pointo1d
On 04/09/14 05:35, David Holmes wrote: Hi Magnus, On 1/09/2014 10:11 PM, Magnus Ihse Bursie wrote: Even in the default log level (warn), hotspots builds are extremely verbose. With the new jigsaw build system, hotspot is build in parallel with the jdk, and the sheer amount of hotspot output

Re: RFR: JDK-8057537: Serialize reconfigure and fix make clean-foo foo

2014-09-04 Thread David Holmes
That's a big Thumbs Up! from me Erik! Thank you very much. David On 4/09/2014 7:12 PM, Erik Joelsson wrote: Hello David, I hear your pain and when reading this got to thinking that separating clean and reconfigure targets shouldn't be that hard. I came up with this solution: Bug:

Re: serialize the reconfigure target ?

2014-09-04 Thread David Holmes
Hi Dave, On 4/09/2014 7:59 PM, pointo1d wrote: Hi again David , On 04/09/14 04:38, David Holmes wrote: I naively assumed this would work: make reconfigure images There should be a way to serialize the top-level set of targets without serializing all the sub-targets. That way this would

Re: serialize the reconfigure target ?

2014-09-04 Thread pointo1d
Hiya David , On 04/09/14 11:26, David Holmes wrote: Hi Dave, On 4/09/2014 7:59 PM, pointo1d wrote: Hi again David , On 04/09/14 04:38, David Holmes wrote: snip I've just discovered this page in the gmake manual - https://www.gnu.org/software/make/manual/html_node/Parallel-Output.html - or

Re: RFR: JDK-8057537: Serialize reconfigure and fix make clean-foo foo

2014-09-04 Thread Magnus Ihse Bursie
On 2014-09-04 11:12, Erik Joelsson wrote: Hello David, I hear your pain and when reading this got to thinking that separating clean and reconfigure targets shouldn't be that hard. I came up with this solution: Bug: https://bugs.openjdk.java.net/browse/JDK-8057537 Webrev:

Re: RFR: JDK-8057537: Serialize reconfigure and fix make clean-foo foo

2014-09-04 Thread Tim Bell
On 09/04/14 06:51, Magnus Ihse Bursie wrote: On 2014-09-04 11:12, Erik Joelsson wrote: Hello David, I hear your pain and when reading this got to thinking that separating clean and reconfigure targets shouldn't be that hard. I came up with this solution: Bug:

Re: RFR: JDK-8057132: Build fails if PROFILE is set in the environment

2014-09-04 Thread Frederic Parain
Reviewed and tested. Thumbs up! Fred On 09/03/2014 12:00 PM, Erik Joelsson wrote: Hello, Please review this small fix for minor regression in the source reorg change. Before the change, BuildJdk.gmk would explicitly set PROFILE= when calling CreateJars.gmk or Images.gmk for a normal image

RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Gerard Ziemski
hi all, Please review a very small fix that makes hotspot build ignore ide folder, which is where local users can store their own favorite IDE projects. For those interested, I have an Xcode project for JDK8 and JDK9 that I am personally actively supporting and using, which is hosted at

Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Karen Kinnear
Gerard, I'm a bit confused - if you have an ide to build the entire jdk - what happens? I was a bit surprised to see a hotspot specific change? Also - can't you store your favorite IDE project outside of the repository? thanks, Karen On Sep 4, 2014, at 12:45 PM, Gerard Ziemski wrote: hi

Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Gerard Ziemski
hi Karen, The Xcode project is just to build hotspot libs, which it then combines with all the other JDK libs and jars built beforehand using command line, to create a complete JDK build that can be ran using Xcode for live debugging hotspot. I have made a deliberate decision, which may

Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Dmitry Samersoff
Gerard, we already have ./jdk/make/netbeans, ./langtools/make/netbeans and I think it's a good pattern to follow. You can create hotspot/make/xcode and don't change the makefile. Also with upcoming switch to full forest build you may consider to create ide folder at top level and move per ws

Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Dean Long
Wouldn't it be better to replace $(HOTSPOT_TOPDIR) with $(HOTSPOT_TOPDIRS), so we don't even search in top-level directories that aren't interesting? dl On 9/4/2014 9:45 AM, Gerard Ziemski wrote: hi all, Please review a very small fix that makes hotspot build ignore ide folder, which is

Re: RFR (XS) 8033946 - Hotspot build should ignore ide folder

2014-09-04 Thread Bernhard Urban
Hi Gerard, On Thu, Sep 4, 2014 at 6:45 PM, Gerard Ziemski gerard.ziem...@oracle.com wrote: For those interested, I have an Xcode project for JDK8 and JDK9 that I am personally actively supporting and using, which is hosted at https://orahub.oraclecorp.com/gerard.ziemski/xcode that is meant

RFR: 8056209 : Remove unused files for libawt

2014-09-04 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8056209 Proposed removing several files ./windows/native/libawt/sun/java2d/d3d/D3DPipeline.cpp ./windows/native/libawt/sun/java2d/d3d/D3DShaderGen.c ./windows/native/libawt/sun/windows/WBufferStrategy.cpp After some analysis the actual list of files

RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

2014-09-04 Thread Jesper Wilhelmsson
Hi, Looking for reviews for this small fix that removes the unnecessary passing of HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added but is not needed since buildtree.make explicitly includes defs.make where HS_ALT_MAKE is defined. Webrev:

RE: How to influence File Permission Mode

2014-09-04 Thread Medi Montaseri
-jdk-20140904.debian.tgz | grep '^-rw---' -rw--- root/root 31265 2014-09-04 19:06 ./demo/scripting/jconsole-plugin/jconsole-plugin.jar -rw--- root/root 43860 2014-09-04 19:06 ./demo/jfc/Metalworks/Metalworks.jar -rw--- root/root 20448 2014-09-04 19:06 ./demo/jfc