Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-13 Thread David DeHaven
The --with-xcode-path argument is optional, you should also be able to build with Xcode 4 selected via sudo xcode-select -switch /path/to/Xcode4.app. I leave MAS managed Xcode (currently 6) active as I'm constantly bouncing between projects and it's a hassle to have to remember to reset

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Mandy Chung
On 1/13/15 7:45 AM, Sergey Bylokhov wrote: On 13.01.2015 17:23, Alan Bateman wrote: Typo in my mail, I meant verify-modules. They are currently issues with verify-modules and boot cycle builds so I think verify-modules is currently disabled (at least in jdk9/dev). Erik is working on this via

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
On 13.01.2015 20:26, Mandy Chung wrote: On 1/13/15 7:45 AM, Sergey Bylokhov wrote: On 13.01.2015 17:23, Alan Bateman wrote: Typo in my mail, I meant verify-modules. They are currently issues with verify-modules and boot cycle builds so I think verify-modules is currently disabled (at least

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Mandy Chung
On 1/13/15 9:34 AM, Sergey Bylokhov wrote: On 13.01.2015 20:26, Mandy Chung wrote: On 1/13/15 7:45 AM, Sergey Bylokhov wrote: On 13.01.2015 17:23, Alan Bateman wrote: Typo in my mail, I meant verify-modules. They are currently issues with verify-modules and boot cycle builds so I think

Build Group Lead resignation

2015-01-13 Thread Kelly O'Hair
I wish to resign as Build Group Lead. It makes much more sense for someone closer to the OpenJDK build issues to be the lead of this group. I would like to stay a group member and keep up-to-date on the activities, but I am unable to take on any significant role at this time. According to the

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread David Holmes
Hi Roman, On 14/01/2015 7:41 AM, Roman Kennke wrote: Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define.

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Alan Bateman
On 13/01/2015 15:45, Sergey Bylokhov wrote: On 13.01.2015 17:23, Alan Bateman wrote: Typo in my mail, I meant verify-modules. They are currently issues with verify-modules and boot cycle builds so I think verify-modules is currently disabled (at least in jdk9/dev). Erik is working on this

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
On 13.01.2015 21:51, Alan Bateman wrote: I think this looks okay. I see Mandy's comment about dropping the dependency on sun.security.util and that would be good to do (but can be another patch if you want). ok. The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.05/jdk

Re: RFR: AARCH64: Top-level JDK changes

2015-01-13 Thread Dean Long
On 1/13/2015 1:08 AM, Andrew Haley wrote: On 13/01/15 08:44, Dean Long wrote: I came up with a simpler version, where I replace aarch64- with arm-, run autoconf-config.sub, then replace arm- back to aarch64-. Thanks. That sounds good to me. Andrew. Here's the patch. If it looks good, I

Re: RFR: AARCH64: Top-level JDK changes

2015-01-13 Thread Dean Long
On 1/12/2015 3:49 AM, Magnus Ihse Bursie wrote: On 2015-01-12 05:31, Dean Long wrote: I found a small problem with the new config.sub wrapper. It works with the bash shell but not with the dash shell. The problem seems to be with this line: result=`. $DIR/autoconf-config.sub $sub_args

Re: [8u40] Request for review and approval: 8068485: Update references of download.oracle.com to docs.oracle.com in javadoc makefile

2015-01-13 Thread Erik Joelsson
Looks good to me. /Erik On 2015-01-13 00:40, Bhavesh Patel wrote: Hi, In the javadoc makefile, there are references to http://download.oracle.com. This automatically gets redirected to http://docs.oracle.com. These references needs to be updated to point to https://docs.oracle.com.

Re: RFR: AARCH64: Top-level JDK changes

2015-01-13 Thread Dean Long
On 1/12/2015 2:25 AM, Andrew Haley wrote: On 12/01/15 04:31, Dean Long wrote: I found a small problem with the new config.sub wrapper. It works with the bash shell but not with the dash shell. The problem seems to be with this line: result=`. $DIR/autoconf-config.sub $sub_args $@` dash

Re: RFR: AARCH64: Top-level JDK changes

2015-01-13 Thread Andrew Haley
On 13/01/15 08:44, Dean Long wrote: I came up with a simpler version, where I replace aarch64- with arm-, run autoconf-config.sub, then replace arm- back to aarch64-. Thanks. That sounds good to me. Andrew.

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-13 Thread Erik Joelsson
Hello, New webrev for root repo: http://cr.openjdk.java.net/~erikj/8042707/webrev.root.02/ On 2015-01-09 15:45, Magnus Ihse Bursie wrote: It looks basically good to me. Some remarks on toolchain_windows.m4, though. In TOOLCHAIN_CHECK_POSSIBLE_VISUAL_STUDIO_ROOT: # TODO: improve detection

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Alan Bateman
On 13/01/2015 13:52, Sergey Bylokhov wrote: Yes it is unnecessary. The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.03/jdk http://cr.openjdk.java.net/~serb/8056298/webrev.03/root This looks good to (and I assume that make verify-images passes). -Alan.

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Alan Bateman
On 13/01/2015 14:17, Sergey Bylokhov wrote: On 13.01.2015 17:05, Alan Bateman wrote: On 13/01/2015 13:52, Sergey Bylokhov wrote: Yes it is unnecessary. The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.03/jdk http://cr.openjdk.java.net/~serb/8056298/webrev.03/root This looks

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
On 13.01.2015 17:05, Alan Bateman wrote: On 13/01/2015 13:52, Sergey Bylokhov wrote: Yes it is unnecessary. The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.03/jdk http://cr.openjdk.java.net/~serb/8056298/webrev.03/root This looks good to (and I assume that make verify-images

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
Hi, Alan. On 12.01.2015 23:42, Alan Bateman wrote: Thanks for doing this. I think it looks okay except for modules.xml where it looks like there may be a few issues. 1. You've updated the definition of java.corba to depend on java.datatransfer but I don't think this is needed (is there code

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread Roman Kennke
Hi David, - In ciTypeFlow.cpp only include some files and code only when building C2. I don't think that code makes sense outside of C2. (That's the issue that you've seen). Looks okay but someone from compiler team needs to comment. There may be other code that need adjusting. It

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Alan Bateman
On 13/01/2015 11:40, Sergey Bylokhov wrote: : The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.02/jdk http://cr.openjdk.java.net/~serb/8056298/webrev.02/root Bug: https://bugs.openjdk.java.net/browse/JDK-8056298 Thanks for the update. The only thing that isn't clear to me is

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Erik Joelsson
The makefile change looks good to me. /Erik On 2015-01-13 12:40, Sergey Bylokhov wrote: Hi, Alan. On 12.01.2015 23:42, Alan Bateman wrote: Thanks for doing this. I think it looks okay except for modules.xml where it looks like there may be a few issues. 1. You've updated the definition of

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
On 13.01.2015 16:15, Alan Bateman wrote: On 13/01/2015 11:40, Sergey Bylokhov wrote: : The new versions: http://cr.openjdk.java.net/~serb/8056298/webrev.02/jdk http://cr.openjdk.java.net/~serb/8056298/webrev.02/root Bug: https://bugs.openjdk.java.net/browse/JDK-8056298 Thanks for the update.

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Sergey Bylokhov
On 13.01.2015 17:23, Alan Bateman wrote: Typo in my mail, I meant verify-modules. They are currently issues with verify-modules and boot cycle builds so I think verify-modules is currently disabled (at least in jdk9/dev). Erik is working on this via JDK-8067479. The new versions:

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-13 Thread Magnus Ihse Bursie
On 2015-01-13 09:41, Erik Joelsson wrote: Hello, New webrev for root repo: http://cr.openjdk.java.net/~erikj/8042707/webrev.root.02/ Fixes look good to me. Thanks! /Magnus On 2015-01-09 15:45, Magnus Ihse Bursie wrote: It looks basically good to me. Some remarks on toolchain_windows.m4,

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-13 Thread Mandy Chung
On 1/13/2015 11:30 AM, Sergey Bylokhov wrote: On 13.01.2015 21:51, Alan Bateman wrote: I think this looks okay. I see Mandy's comment about dropping the dependency on sun.security.util and that would be good to do (but can be another patch if you want). ok. The new versions:

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread Roman Kennke
Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define. http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.02/ Please review and push if ok. Roman Am Freitag,