Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

2016-03-11 Thread Anthony Scarpino
I updated the webrev and added the build-dev list as there are two makefile changes. http://cr.openjdk.java.net/~ascarpino/8140422/webrev.01/ thanks Tony On 02/29/2016 08:55 AM, Anthony Scarpino wrote: I need a code review of this change: Currently CertPath algorithm restrictions allow

RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-11 Thread Erik Joelsson
In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the generated binaries some. These changes are: * Standardizing sort order for objects on link command line on Windows to a locale

RFR: JDK-8151726: Introduce a JPRT testset buildinfra

2016-03-11 Thread Erik Joelsson
When verifying build changes, we are currently lacking a good way of doing all relevant builds in one JPRT job. Some build configurations we aren't even able to test at all. To facilitate this, I would like to introduce a new testset. This testset will be a super set of the current default

RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-11 Thread Erik Joelsson
Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build for build output comparisons to be meaningful

Re: RFR: JDK-8151619: genSocketOptionRegistry.exe always relinked on Windows

2016-03-11 Thread Tim Bell
Erik: The build tool genSocketOptionRegistry.exe is always relinked on Windows at every rebuild. This causes a long chain of unnecessary rebuilding, completely destroying incremental build performance. The underlying cause of this is the enabling of debug symbols everywhere without properly

RFR: JDK-8151619: genSocketOptionRegistry.exe always relinked on Windows

2016-03-11 Thread Erik Joelsson
The build tool genSocketOptionRegistry.exe is always relinked on Windows at every rebuild. This causes a long chain of unnecessary rebuilding, completely destroying incremental build performance. The underlying cause of this is the enabling of debug symbols everywhere without properly

Re: Fix the version of required jdk

2016-03-11 Thread KUBOTA Yuji
Hi Erik, Thank you for quickly push! - Yuji On 2016-03-11, Erik Joelsson wrote: > Pushed: https://bugs.openjdk.java.net/browse/JDK-8151685 > > On 2016-03-11 09:20, Erik Joelsson wrote: > >> Hello Yuji, >> >> Your second patch looks fine. I will sponsor the fix. >> >> /Erik >> >> On 2016-03-11

Re: Fix the version of required jdk

2016-03-11 Thread Erik Joelsson
Pushed: https://bugs.openjdk.java.net/browse/JDK-8151685 On 2016-03-11 09:20, Erik Joelsson wrote: Hello Yuji, Your second patch looks fine. I will sponsor the fix. /Erik On 2016-03-11 08:25, KUBOTA Yuji wrote: Hi everyone Sorry, I pasted a wrong patch at previous mail. The right patch is

Re: Fix the version of required jdk

2016-03-11 Thread Erik Joelsson
Hello Yuji, Your second patch looks fine. I will sponsor the fix. /Erik On 2016-03-11 08:25, KUBOTA Yuji wrote: Hi everyone Sorry, I pasted a wrong patch at previous mail. The right patch is as below. diff --git a/common/autoconf/generated-configure.sh

Re: RFR: 8151630 and 8151631 ios build failures after b106 merge

2016-03-11 Thread Erik Joelsson
Looks ok. /Erik On 2016-03-10 20:33, Gary Adams wrote: A minor problem arises when we eliminate the last cmd from the ios build. When making images the support/modules_cmds-stripped is passed to the jimage tool, but the directory is not created if no cmds were processed. This will be a moot