Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

Much better, and thank you for fixing the existing mkdir/echo lines too. Just one nit, for this continuation: $(TOOL_CACERTSHASHER) -i $(GENDATA_CACERTSHASHER_IN) \ -o $(GENDATA_CACERTSHASHER) please use tab+4spaces for the second line. No need to resend webrev for that. See

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

Looks good to me. /Erik On 2016-03-18 05:42, Andrew Hughes wrote: - Original Message - On 2016-03-16 05:25, Andrew Hughes wrote: - Original Message - Hello, As representative for the build-infra group creating the new Hotspot build, I appreciate that the changes are made

Re: RFR(XS): 8151987: jexec should be executable

On Wed, Mar 16, 2016 at 12:29 PM, Volker Simonis wrote: > > > On Wed, Mar 16, 2016 at 12:14 PM, Alan Bateman > wrote: > >> On 16/03/2016 11:08, Volker Simonis wrote: >> >>> Hi, >>> >>> can I please have a review for the following small fix: >>>

Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

I believe I got everyone's comments. I've updated the webrev. http://cr.openjdk.java.net/~ascarpino/8140422/webrev.02/ Thanks Tony On 02/29/2016 08:55 AM, Anthony Scarpino wrote: Currently CertPath algorithm restrictions allow or deny all certificates. This change adds the ability to

Errors building on OSX 10.8.5

While I plan to upgrade this week to El Capitan from 10.8.5, it looks like the build now requires a more current version of OSX than it did a few weeks ago based on the error I am seeing after updating my jdk9 workspace today before the jake integration. I assume I am out of luck until i

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

- Original Message - > Looks good to me. > > /Erik > Thanks. Pushed: http://hg.openjdk.java.net/jdk9/dev/rev/9d77f922d694 -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D

Re: RFR(XS): 8151987: jexec should be executable

On 16/03/2016 12:19, Volker Simonis wrote: So here comes a new (and even smaller) version of the patch which fixes jlink in the same way: http://cr.openjdk.java.net/~simonis/webrevs/2016/8151987.v1/ Please feel free to

Re: RFR: JDK-8151973: Add Jib and JPRT configuration for linux-arm64 open only

Erik, On 16/03/2016 8:10 PM, Erik Joelsson wrote: Hello, Since we have a community supported Linux aarch64 port, I would like to be able to build it using Jib and JPRT, specifically as part of the new buildinfra testset. Bug: https://bugs.openjdk.java.net/browse/JDK-8151973 Webrev:

Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

Ok.. thanks.. I'll make those changes.. Tony On 03/12/2016 07:37 AM, Erik Joelsson wrote: Hello Anthony, I realize you followed the patterns already in the file and we apparently haven't updated that file to follow latest standards. I would like you to change the following: $(ECHO) foo

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

> On Mar 15, 2016, at 10:51 PM, Erik Joelsson wrote: > > The __FILE__ macro is built into the compiler and evaluates to the file name > of the current source file. It's intended use is for debug messages. In the > rest of the JDK we eliminated its use completely by

Re: RFR 8140422: Add mechanism to allow non default root CAs to be not subject to algorithm restrictions

ok.. thanks Tony On 03/18/2016 10:27 AM, Erik Joelsson wrote: Much better, and thank you for fixing the existing mkdir/echo lines too. Just one nit, for this continuation: $(TOOL_CACERTSHASHER) -i $(GENDATA_CACERTSHASHER_IN) \ -o $(GENDATA_CACERTSHASHER) please use

Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

+1 -phil. On 02/15/2016 01:02 AM, Erik Joelsson wrote: Looks good. /Erik On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review. Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

- Original Message - > On 2016-03-16 05:25, Andrew Hughes wrote: > > - Original Message - > >> Hello, > >> > >> As representative for the build-infra group creating the new Hotspot > >> build, I appreciate that the changes are made in configure. That will at > >> least