Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-06 Thread Christian Thalinger
> On Apr 5, 2016, at 11:14 PM, Erik Joelsson wrote: > > Hello, > > I assume the mx projects are for Java code or do they also generate projects > for native? Also native. Look at the screenshots I posted. Particularly this one:

Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-06 Thread Daniel D. Daugherty
I'm good with all of your replies/resolutions. I did forget to say thanks for sticking with the rework of the HotSpot build system! There have been a few attempts in the past to rework the HotSpot build system, but no one was able to make much progress let alone finish it. Kudos!! Dan On

Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-06 Thread Erik Joelsson
Hello, I assume the mx projects are for Java code or do they also generate projects for native? The new top level target is only meant to replace the old Visual Studio project generator, at least for now. /Erik On 2016-04-06 03:23, Christian Thalinger wrote: On Apr 5, 2016, at 8:10 AM,

Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-06 Thread Erik Joelsson
Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and published a new webrev: http://cr.openjdk.java.net/~erikj/8152666/webrev.02/ On 2016-04-05 20:10, Daniel D. Daugherty wrote: > The new build supports the following variants: > > *