> On May 31, 2019, at 11:15 PM, Sean Mullan wrote:
>
> On 5/30/19 8:49 PM, Weijun Wang wrote:
>> Sure. How many info do you want to see?
>> I can prepend `keytool -printcert` but that's too much. At least I think the
>> extensions part is not needed. Also, I don't wish people reading the
>>
Bringing these pages to more recent version is better than
the current so outdated version even it's just a snapshot.
The list of new pages look okay (but I didn't validate the
content.)
Mandy
On 5/31/19 2:02 PM, Jonathan Gibbons wrote:
Please review a change to refresh the content of the man
Looks good to me.
/Erik
On 2019-05-31 14:02, Jonathan Gibbons wrote:
Please review a change to refresh the content of the man pages (*.1
files) in the main repo,
to contain essentially the exact same content as found in the Oracle
JDK man pages.
Going forward, the intent is to bulk-update
Please review a change to refresh the content of the man pages (*.1
files) in the main repo,
to contain essentially the exact same content as found in the Oracle JDK
man pages.
Going forward, the intent is to bulk-update these pages towards the end
of each release
cycle, until we can
> On May 31, 2019, at 4:46 PM, Kim Barrett wrote:
>
>> On May 31, 2019, at 12:11 AM, Nick Gasson wrote:
>>
>> /home/nicgas01/jdk/src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp:259:34:
>> note: in instantiation of function template specialization
>> 'Atomic::add' requested here
>>
> On May 31, 2019, at 12:11 AM, Nick Gasson wrote:
>>> /home/nicgas01/jdk/src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp:43:39:
>>> error: cannot initialize a parameter of type 'char *' with an lvalue of
>>> type 'unsigned long'
>>>return __sync_add_and_fetch(dest, add_value);
Erik:
This patch changes the filter mechanics to only apply to the path
relative to the workspace root. I also changed the filter token from
"unix" to "/unix/" to avoid the risk of matching substrings in
directories in the future.
Bug: https://bugs.openjdk.java.net/browse/JDK-8225140
Webrev:
If the workspace directory (or any parent) contains the word "unix", the
build fails in java.desktop-libs. There are several libraries here that
use the EXCLUDE_SRC_FILTER option of SetupJdkLibrary to filter away the
src/java.desktop/unix/lib* dirs. This option incorrectly includes the
whole
This looks good to me, and thanks for fixing the other instances of
BUILD_TOOLS_JDK!
/Erik
On 2019-05-30 20:00, Weijun Wang wrote:
New webrev at
https://cr.openjdk.java.net/~weijun/8193255/webrev.01
Changes:
1. Textual info at the beginning of each cert
2. Makefile: indentation,
Hello Robin,
On 2019-05-31 05:26, Robin Westberg wrote:
Hi Erik,
On 29 May 2019, at 17:22, Erik Joelsson wrote:
Thanks, looks good!
Thanks for reviewing! Unfortunately I had to do a few more general changes to get
the “ccls" indexer working properly as well, hope you don’t mind taking
On 5/30/19 8:49 PM, Weijun Wang wrote:
Sure. How many info do you want to see?
I can prepend `keytool -printcert` but that's too much. At least I think the
extensions part is not needed. Also, I don't wish people reading the
fingerprint inside as genuine and does not calculate it from the
Hi Volker,
> On 29 May 2019, at 16:01, Volker Simonis wrote:
>
> On Wed, May 29, 2019 at 3:43 PM Robin Westberg
> wrote:
>>
>> Hi Volker,
>>
>>> On 28 May 2019, at 17:33, Volker Simonis wrote:
>>>
>>> Hi Robin,
>>>
>>> thanks a lot for doing this!
>>>
>>> I have just a quick question. Do
Hi Erik,
> On 29 May 2019, at 17:22, Erik Joelsson wrote:
>
> Thanks, looks good!
Thanks for reviewing! Unfortunately I had to do a few more general changes to
get the “ccls" indexer working properly as well, hope you don’t mind taking
another look:
Webrevs:
- Full:
On 5/30/19 3:29 PM, Erik Joelsson wrote:
> Build change looks good.
Thanks, Erik. Not expecting any more build changes, I am going to drop
build-dev@ from the following
replies on this thread.
-Aleksey
Hi Max,
this looks all good to me now :)
Best regards
Christoph
> -Original Message-
> From: build-dev On Behalf Of
> Weijun Wang
> Sent: Freitag, 31. Mai 2019 05:01
> To: Erik Joelsson
> Cc: security-...@openjdk.java.net; build-dev d...@openjdk.java.net>
> Subject: Re: RFR 8193255:
15 matches
Mail list logo
