Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Sandhya Viswanathan
On Fri, 5 Nov 2021 00:56:05 GMT, Vladimir Kozlov wrote: >> Thanks a lot @vnkozlov. > > @sviswa7 testing passed you can integrate. Thanks a lot @vnkozlov for testing and review. Thanks @erikj79 @PaulSandoz @magicus for the review. - PR: https://git.openjdk.java.net/jdk/pull/6265

Integrated: 8276025: Hotspot's libsvml.so may conflict with user dependency

2021-11-04 Thread Sandhya Viswanathan
On Thu, 4 Nov 2021 17:48:56 GMT, Sandhya Viswanathan wrote: > This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp

RFR: 8276672: Cannot build hsdis on WSL

2021-11-04 Thread Yasumasa Suenaga
JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu. Hsdis.gmk has two problems: 1. MinGW version is fixed to "9.2.0" 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/sys-root I

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Michael Bien
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Vladimir Kozlov
On Thu, 4 Nov 2021 18:15:08 GMT, Sandhya Viswanathan wrote: >> Looks good. I will run tests. > > Thanks a lot @vnkozlov. @sviswa7 testing passed you can integrate. - PR: https://git.openjdk.java.net/jdk/pull/6265

Re: Running jdk's tests to produce coverage report

2021-11-04 Thread Jonathan Gibbons
I'll update the jtreg build script, and then you'll be able to build jtreg yourself, and get the jcov from there. -- Jon On 11/3/21 9:55 AM, Chaliasos, Stefanos wrote: Do you know where I can download this version? In GitHub there are releases until jcov3.0-b07 Stefanos

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Andrew Leonard
On Thu, 4 Nov 2021 21:51:46 GMT, Joe Darcy wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Andrew Leonard
On Thu, 4 Nov 2021 21:51:46 GMT, Joe Darcy wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Magnus Ihse Bursie
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Joe Darcy
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to

RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-04 Thread Andrew Leonard
This PR enables reproducible Jars, Jmods and openjdk image zip files (eg.src.zip). It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying ZipOutputStream's. It fixes the following keys issues relating to reproducibility: - Jar and ZipOutputStream are not SOURCE_DATE_EPOCH aware

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Paul Sandoz
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Vladimir Kozlov
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Erik Joelsson
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Vladimir Kozlov
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]

2021-11-04 Thread Sandhya Viswanathan
> This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and > the renamed symbols. >

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency

2021-11-04 Thread Vladimir Kozlov
On Thu, 4 Nov 2021 17:48:56 GMT, Sandhya Viswanathan wrote: > This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency

2021-11-04 Thread Sandhya Viswanathan
On Thu, 4 Nov 2021 18:11:41 GMT, Vladimir Kozlov wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp

Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency

2021-11-04 Thread Vladimir Kozlov
On Thu, 4 Nov 2021 17:48:56 GMT, Sandhya Viswanathan wrote: > This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp

RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency

2021-11-04 Thread Sandhya Viswanathan
This patch removes conflicts with libsvml.so distributed with Intel's MKL library: Renames exported symbols from __svml to __jsvml. Renames library from libsvml.so to libjsvml.so. Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and the renamed symbols. Updates tests

Integrated: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Magnus Ihse Bursie
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Thu, 4 Nov 2021 13:17:13 GMT, Magnus Ihse Bursie wrote: > Shoot! ...as in "Approved"? :) - PR: https://git.openjdk.java.net/jdk/pull/6231

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Magnus Ihse Bursie
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-04 Thread Aleksey Shipilev
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >