Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

On Fri, 10 Jun 2022 09:45:15 GMT, Magnus Ihse Bursie wrote: > (But does it really speed things up?) Yes, I think it does: `apt` would read the package database once, and do the post-install actions once. `update-alternatives` does not have to happen between those two lines. -

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

On Fri, 10 Jun 2022 09:39:29 GMT, Magnus Ihse Bursie wrote: >> .github/actions/get-bootjdk/action.yml line 26: >> >>> 24: # >>> 25: >>> 26: name: 'Get BootJDK' >> >> Here and later, polishing: "BootJDK" -> "boot JDK"? > > I think we've mostly been using "BootJDK" as a specialized term in the

Re: RFR: 8288195: Prepare build system for GHA changes

On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote: > A few changes to the build system is needed for the GHA rewrite > ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)). Looks fine! - Marked as reviewed by shade (Reviewer). PR:

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

On Thu, 9 Jun 2022 12:57:05 GMT, Magnus Ihse Bursie wrote: >> With project Skara, the ability to run a set of sanity build and test jobs >> on selected platforms was added. This functionality was driven by >> `.github/workflows/submit.yml`. This file unfortunately lacks any real >> structure,

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

On Fri, 10 Jun 2022 07:13:32 GMT, Aleksey Shipilev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apparently that was not a legal reference to actions/checkout. Try another >&

Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows

On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > >

Re: RFR: 8287336: GHA: Workflows break on patch versions

On Wed, 25 May 2022 17:17:12 GMT, Christoph Langer wrote: > This fixes the issue on GHA when the branch contains a patch version. > > Here you can see the problem: > https://github.com/openjdk-bots/jdk18u/actions/runs/2385040187 > And here you see how it looks if it's fixed: >

Re: RFR: 8287202: GHA: Add macOS aarch64 to the list of default platforms for workflow_dispatch event

On Tue, 24 May 2022 06:41:52 GMT, Christoph Langer wrote: > It seems that it was forgotten to add the macOS aarch64 platform to the > default platforms of workflow_dispatch. Let's fix this. Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8861

Re: RFR: 8287174: Remove deprecated configure arguments

On Mon, 23 May 2022 17:25:30 GMT, Magnus Ihse Bursie wrote: > We have a bunch of configure arguments that has been deprecated for multiple > releases. These should be removed. In effect, this will raise an error > instead of a warning if these argument is included on the command line for >

Re: pre-submit tests for github PRs

On 5/23/22 16:53, Ioi Lam wrote: On 5/23/2022 4:41 AM, Alan Bateman wrote: On 22/05/2022 23:58, David Holmes wrote: GHA tests a range of OpenJDK ports, not just the "mainstream platforms". The existing linux-86 failures (and others) are due to the Loom integration which only fully supports a

Re: RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li wrote: >> We are trying to cross build a RISC-V version of OpenJDK. We specified >> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an >> error message. >> >> >> configure: error: /usr/bin/bash >>

Re: RFR: 8284507: GHA: Only check test results if testing was not skipped

On Thu, 7 Apr 2022 07:53:38 GMT, Christoph Langer wrote: > In GitHub Actions the step "Check that all tests executed successfully" will > be marked as failing when the "Run tests" step did not run but some earlier > step already failed. This is irritating and it can be corrected by doing the

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer [v2]

On Wed, 6 Apr 2022 11:12:39 GMT, Christoph Langer wrote: >> Make cygwin usage in GHA more reliable >> >> With this change we now attempt to retrieve the cygwin installer from cache >> every time we need it. >> We would also only try to download it once per build job, in the beginning. >>

Re: RFR: 8284389: Improve stability of GHA Pre-submit testing by caching cygwin installer

On Tue, 5 Apr 2022 20:57:45 GMT, Christoph Langer wrote: > Make cygwin usage in GHA more reliable > > With this change we now attempt to retrieve the cygwin installer from cache > every time we need it. > We would also only try to download it once per build job, in the beginning. > During

Integrated: 8283999: Update JMH devkit to 1.35

On Wed, 30 Mar 2022 12:25:52 GMT, Aleksey Shipilev wrote: > JMH 1.35 is released, so we can bump the devkit too. > > Additional testing: > - [x] JMH devkit creation > - [x] Sample benchmarks This pull request has now been integrated. Changeset: a3223cb6 Author:Alekse

RFR: 8283999: Update JMH devkit to 1.35

JMH 1.35 is released, so we can bump the devkit too. Additional testing: - [x] JMH devkit creation - [x] Sample benchmarks - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/8040/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8040=00 Issue:

Re: RFR: 8283575: Check for GNU time fails for version >1.7

On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote: > The version output of GNU time changed from "GNU time" to "GNU Time" in > version 1.8. We need to update our check for identifying GNU time to handle > this. Looks okay, provided you tested with some version of GNU [Tt]ime. Is double

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4]

On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote: >> This PR implements JEP 422: Linux/RISC-V Port [1]. >> The PR starts as a squashed merge of the >> https://openjdk.java.net/projects/riscv-port branch. >> >> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive >> Unmatched

Integrated: 8283017: GHA: Workflows break with update release versions

On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For exam

Re: RFR: 8283017: GHA: Workflows break with update release versions

On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For exam

RFR: 8283017: GHA: Workflows break with update release versions

Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, which means the test jobs in GHA workflows are unable to run. See for example JDK 18u GHA run: Build step produce: Creating jdk-18.0.1-internal+0_linux-x64_bin.tar.gz Creating

Re: configure misses check for linux-glibc-devel / linux-headers / kernel-headers ?

On 3/4/22 12:41, Baesken, Matthias wrote: Hi Aleksey I did not use a devkit, just installed gcc/g++ on the Alpine docker image I used . Maybe that's why I do not see this help output you added ? That might be the key. I remember testing this with vanilla Alpine 3 image. IIRC, configure

Re: configure misses check for linux-glibc-devel / linux-headers / kernel-headers ?

On 3/4/22 10:08, Baesken, Matthias wrote: Hi , while attempting to build jdk on an Alpine Linux I was running into the following issue : After some additional package installations configure was passing successfully , however hotspot build failed with

Integrated: 8282225: GHA: Allow one concurrent run per PR only

On Tue, 22 Feb 2022 07:05:40 GMT, Aleksey Shipilev wrote: > Since last year, GHA allows concurrency control over GHA runs: > > https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ > > https://docs.github.com/en/actions/using-workflows/

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

On Tue, 22 Feb 2022 16:18:24 GMT, Aleksey Shipilev wrote: >> Since last year, GHA allows concurrency control over GHA runs: >> >> https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ >> >> https://docs.github.com/en/ac

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

On Tue, 22 Feb 2022 16:18:24 GMT, Aleksey Shipilev wrote: >> Since last year, GHA allows concurrency control over GHA runs: >> >> https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ >> >> https://docs.github.com/en/ac

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only

On Tue, 22 Feb 2022 07:05:40 GMT, Aleksey Shipilev wrote: > Since last year, GHA allows concurrency control over GHA runs: > > https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ > > https://docs.github.com/en/actions/using-workflows/

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

run gets cancelled on new commit > - [x] Verified in-progress run gets cancelled on merge > - [x] Verified in-progress run gets cancelled on rebase + force-push Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Also speci

RFR: 8282225: GHA: Allow one concurrent run per PR only

Since last year, GHA allows concurrency control over GHA runs: https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency Our GHA workflows trigger on every PR

Re: RFR: 8274980: Improve adhoc build version strings [v10]

On Thu, 10 Feb 2022 16:42:47 GMT, Magnus Ihse Bursie wrote: >> Current adhoc version build strings are not ideal. Some of the problems: >> * A build number of "0" is inserted, which make the version string look >> like it's an official build, at least when not reading carefully >> * The

Re: RFR: 8274980: Improve adhoc build version strings [v4]

On Fri, 4 Feb 2022 10:00:50 GMT, TheShermanTanker wrote: > If that's the case, I'm wondering if instead of changing > `18-internal+0-adhoc.shade.jdk (18-internal)` to something like > `18-internal-jdk-18+17-80-gcdf89304eaf.shade (18-internal)`, `build 18<+build > number, not

Re: Segfault when building openjdk13 with openjdk12

On 2/2/22 08:53, Abigail G wrote: Whoops, looks like I made the zip wrong, this one should work: https://0x0.st/oHxy.zip So it looks like a GC crash: # SIGSEGV (0xb) at pc=0x7fa2ba719208, pid=29539, tid=29557 siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr:

Re: RFR: JDK-8280583: Always build NMT [v3]

On Wed, 26 Jan 2022 08:36:44 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>

Re: RFR: JDK-8280583: Always build NMT [v2]

On Wed, 26 Jan 2022 06:23:41 GMT, Thomas Stuefe wrote: >> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >>

Re: GHAs and precompiled headers

On 1/24/22 10:26 AM, Thomas Stüfe wrote: On Mon, Jan 24, 2022 at 10:15 AM Aleksey Shipilev mailto:sh...@redhat.com>> wrote: On 1/24/22 8:43 AM, Thomas Stüfe wrote: > We generally build without --disable-precompiled-headers in GHAs, which > hides errors from miss

Re: GHAs and precompiled headers

On 1/24/22 8:43 AM, Thomas Stüfe wrote: We generally build without --disable-precompiled-headers in GHAs, which hides errors from missing includes. Since GHAs are very useful to test builds on side platforms, would it not make sense to build without precompiled headers? Or is that too costly?

Re: Make test-tier1 doesn't work.

On 1/21/22 10:25 AM, Liu, Xin wrote: make -qp can dump all targets. I can't find test-tier1, test-jdk_lang etc. Huh? $ make -qp 2>&1 | grep tier1: run-test-tier1: test-tier1: Is this target still available? if so, do we need to update testing.md? I think the "normal" way to access test

Integrated: 8279958: Provide configure hints for Alpine/apk package managers

On Thu, 13 Jan 2022 12:02:33 GMT, Aleksey Shipilev wrote: > Our build system provides helpful hints about the packages to install to > resolve the build-time dependencies. It can be amended to include Alpine/apk > package managers. Noticed this when trying to build mainlin

Re: RFR: 8279958: Provide configure hints for Alpine/apk package managers

On Thu, 13 Jan 2022 12:02:33 GMT, Aleksey Shipilev wrote: > Our build system provides helpful hints about the packages to install to > resolve the build-time dependencies. It can be amended to include Alpine/apk > package managers. Noticed this when trying to build mainlin

RFR: 8279958: Provide configure hints for Alpine/apk package managers

Our build system provides helpful hints about the packages to install to resolve the build-time dependencies. It can be amended to include Alpine/apk package managers. Noticed this when trying to build mainline OpenJDK on Alpine 3. Additional testing: - [x] Was able to build on clean Alpine

Re: Need OpenJDK to be used on PowerPC for our products.

On 1/7/22 11:06 AM, Dipendu Ghosh wrote: At present I am trying to setup the build environment for OpenJDK. So I followed the steps present at https://openjdk.java.net/groups/build/doc/building.html. I think that's a mirror of in-tree docs:

Re: Need OpenJDK to be used on PowerPC for our products.

On 1/7/22 9:38 AM, Dipendu Ghosh wrote: Thank You David for the link. But that does not provide builds for Linux/PPC32 (single core e500v2). PPC32 is not a supported platform, so you would not be be able to compile "Server" (C1/C2 compilers) for it. You would be able to compile "Zero" (pure

Integrated: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT

On Wed, 5 Jan 2022 08:42:41 GMT, Aleksey Shipilev wrote: > Following up on suggestion here: > https://github.com/openjdk/jdk/pull/6720#discussion_r778457819 This pull request has now been integrated. Changeset: bc123811 Author:Aleksey Shipilev URL: https://git.openjdk.ja

Integrated: 8279445: Update JMH devkit to 1.34

On Tue, 4 Jan 2022 12:15:10 GMT, Aleksey Shipilev wrote: > Brings lots of goodies, including automatic enablement of Compiler > Blackholes: > https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html > > Additional testing: > - [x] Devkit creation wor

Re: RFR: 8279445: Update JMH devkit to 1.34

On Tue, 4 Jan 2022 12:15:10 GMT, Aleksey Shipilev wrote: > Brings lots of goodies, including automatic enablement of Compiler > Blackholes: > https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html > > Additional testing: > - [x] Devkit creation wor

RFR: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT

Following up on suggestion here: https://github.com/openjdk/jdk/pull/6720#discussion_r778457819 - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/6964/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6964=00 Issue:

Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

On Wed, 5 Jan 2022 08:31:54 GMT, Aleksey Shipilev wrote: >> doc/testing.html line 198: >> >>> 196: Retry failed tests up to a set number of times. Defaults to 0. >>> 197: REPEAT_COUNT >>> 198: Repeat the tests for a set number of times. Default

Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

On Tue, 4 Jan 2022 23:39:45 GMT, Sergey Bylokhov wrote: >> This adds the test repeat feature in the build system. This is convenient to >> follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run >> the test multiple times, until we run out of repeats or the tests fail. >>

RFR: 8279445: Update JMH devkit to 1.34

Brings lots of goodies, including automatic enablement of Compiler Blackholes: https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html Additional testing: - [x] Devkit creation works - [x] Sample benchmarks runs with new devkit - Commit messages: - Fix

[jdk18] Integrated: 8279379: GHA: Print tests that are in error

On Mon, 3 Jan 2022 11:34:14 GMT, Aleksey Shipilev wrote: > Current GHA workflow only prints `newfailures.txt` when tests fail. But the > tests can also "ERROR" out. In which case, we want to print > `other_errors.txt` as well. In current mainline GHA, we have a x86_32

Re: [jdk18] RFR: 8279379: GHA: Print tests that are in error

On Mon, 3 Jan 2022 11:34:14 GMT, Aleksey Shipilev wrote: > Current GHA workflow only prints `newfailures.txt` when tests fail. But the > tests can also "ERROR" out. In which case, we want to print > `other_errors.txt` as well. In current mainline GHA, we have a x86_32

[jdk18] RFR: 8279379: GHA: Print tests that are in error

Current GHA workflow only prints `newfailures.txt` when tests fail. But the tests can also "ERROR" out. In which case, we want to print `other_errors.txt` as well. In current mainline GHA, we have a x86_32 langtools_tier1 failure like this: == Test summary

Integrated: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

On Mon, 6 Dec 2021 11:12:22 GMT, Aleksey Shipilev wrote: > This adds the test repeat feature in the build system. This is convenient to > follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run > the test multiple times, until we run out of repeats or th

Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

On Mon, 6 Dec 2021 11:12:22 GMT, Aleksey Shipilev wrote: > This adds the test repeat feature in the build system. This is convenient to > follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run > the test multiple times, until we run out of repeats or th

RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test

This adds the test repeat feature in the build system. This is convenient to follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run the test multiple times, until we run out of repeats or the tests fail. With this sample test: /* * @test * @run driver IntermittentTest

Re: RFR: 8277427: Update jib-profiles to use JMH 1.33 devkit

On Fri, 19 Nov 2021 01:20:43 GMT, Claes Redestad wrote: > Use most recent devkit. > > Testing: staged devkit, built and verified micros locally Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6468

Re: RFR: JDK-8276422 Add command-line option to disable finalization

On Thu, 18 Nov 2021 07:40:34 GMT, David Holmes wrote: >> Do we even have to have a flag on Java side? It looks like these calls are >> only done as the upcalls from VM, so we might just keep the flag on VM side? > > @shipilev not sure what you mean by "a flag on the Java side". The Java code

Re: RFR: JDK-8276422 Add command-line option to disable finalization

On Thu, 18 Nov 2021 07:13:55 GMT, David Holmes wrote: >> Huh, good catch! This was mostly left over from an earlier version of the >> flag that used system properties, which aren't initialized until after the >> Finalizer class is initialized. >> >> It might be the case that the Holder can be

Re: RFR: JDK-8276422 Add command-line option to disable finalization

On Thu, 18 Nov 2021 01:34:36 GMT, Stuart Marks wrote: > Pretty much what it says. The new option controls a static member in > InstanceKlass that's consulted to determine whether the finalization > machinery is activated for instances when a class is loaded. A new native > method is added so

Re: RFR: 8276864: Update boot JDKs to 17.0.1 in GHA

On Tue, 9 Nov 2021 14:45:56 GMT, Aleksey Shipilev wrote: > Current GHA runs at 17 GA, which misses fixes from 17.0.1. > > Additional testing: > - [x] GHA builds are fine > - [x] GHA tests are fine Ok, good, thanks. GHA are clean. I am integrating. -

Integrated: 8276864: Update boot JDKs to 17.0.1 in GHA

On Tue, 9 Nov 2021 14:45:56 GMT, Aleksey Shipilev wrote: > Current GHA runs at 17 GA, which misses fixes from 17.0.1. > > Additional testing: > - [x] GHA builds are fine > - [x] GHA tests are fine This pull request has now been integrated. Changeset: f561d3c1 Author:A

Re: RFR: 8276864: Update boot JDKs to 17.0.1 in GHA

On Tue, 9 Nov 2021 14:45:56 GMT, Aleksey Shipilev wrote: > Current GHA runs at 17 GA, which misses fixes from 17.0.1. > > Additional testing: > - [x] GHA builds are fine > - [x] GHA tests are fine Thanks, Erik. Anyone else wants/needs to review this? -

Re: RFR: 8276854: Windows GHA builds fail due to broken Cygwin

On Wed, 10 Nov 2021 10:14:36 GMT, Anirvan Sarkar wrote: > It is my mistake. Sorry for rushing and breaking the etiquette. I will ensure > that this does not happen again. Good, thanks. No harm done in this particular case, as the patch is definitely sensible. I'll handle the backports...

Re: RFR: 8276854: Windows GHA builds fail due to broken Cygwin

On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar wrote: > Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub > Actions. > `make` SEGVs on the latest version. > > Version number format obtained from > https://cygwin.com/packages/summary/cygwin.html The patch looks

RFR: 8276864: Update boot JDKs to 17.0.1 in GHA

Current GHA runs at 17 GA, which misses fixes from 17.0.1. Additional testing: - [x] GHA builds are fine - [ ] GHA tests are fine - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/6314/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6314=00

Integrated: 8276550: Use SHA256 hash in build.tools.depend.Depend

On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

On Thu, 4 Nov 2021 13:17:13 GMT, Magnus Ihse Bursie wrote: > Shoot! ...as in "Approved"? :) - PR: https://git.openjdk.java.net/jdk/pull/6231

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and

RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

JDK-8182285 added the incremental build capabilities for modules, by hashing the APIs of each module. The original change uses MD5, which is quite weak, and JDK-8214483 allows `MessageDigest` to have no MD5 implementation. This is the cause of some build failures when using a FIPS-compliant

Re: RFR: 8274980: Improve adhoc build version strings

On Thu, 28 Oct 2021 09:34:07 GMT, Magnus Ihse Bursie wrote: > Current adhoc version build strings are not ideal. Some of the problems: > * A build number of "0" is inserted, which make the version string look like > it's an official build, at least when not reading carefully > * The version

Integrated: 8276057: Update JMH devkit to 1.33

On Wed, 27 Oct 2021 12:28:16 GMT, Aleksey Shipilev wrote: > Time to update the devkit to the latest JMH. > > Additional testing: > - [x] Devkit generation works > - [x] Sample benchmarks run This pull request has now been integrated. Changeset: a2f2d8fc Author:Alekse

Re: RFR: 8276057: Update JMH devkit to 1.33

On Wed, 27 Oct 2021 12:28:16 GMT, Aleksey Shipilev wrote: > Time to update the devkit to the latest JMH. > > Additional testing: > - [x] Devkit generation works > - [x] Sample benchmarks run Thanks! - PR: https://git.openjdk.java.net/jdk/pull/6139

RFR: 8276057: Update JMH devkit to 1.33

Time to update the devkit to the latest JMH. Additional testing: - [x] Devkit generation works - [x] Sample benchmarks run - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/6139/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6139=00 Issue:

Re: Unable to build Client/Server variant for OpenJDK-11 on ARMv7-A

On 10/22/21 12:31 AM, John Cummings wrote: Thank you again, that solved that problem, and now another has arose. Please confirm. This patch solves the build failure for you? https://bugs.openjdk.java.net/browse/JDK-8222825 https://cr.openjdk.java.net/~bulasevich/8222825/webrev.00.jdk11/

Re: Unable to build Client/Server variant for OpenJDK-11 on ARMv7-A

On 10/13/21 7:20 PM, John Cummings wrote: Thank you both for the responses! I am now using the https://github.com/openjdk/jdk11u-dev/ tree that you linked and I have trimmed down my cxxflags and cflags to just -O2 and -pipe, and added

Re: Unable to build Client/Server variant for OpenJDK-11 on ARMv7-A

Hi, This does not look a build issue per se, but rather a Hotspot bug. On 10/8/21 7:46 PM, John Cummings wrote: I am using the source from https://hg.openjdk.java.net/jdk/jdk11. This is an extremely old JDK 11 tree. The most actual one is here: https://github.com/openjdk/jdk11u-dev/ FWIW,

Integrated: 8274083: Update testing docs to mention tiered testing

On Tue, 21 Sep 2021 14:52:26 GMT, Aleksey Shipilev wrote: > Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) This pull request has now been integrated

Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]

> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

On Fri, 24 Sep 2021 05:58:09 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.html line 80: > >> 78: >> 79:

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

On Thu, 23 Sep 2021 11:58:02 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 79: > >> 77: >> 78:

Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]

> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

On Thu, 23 Sep 2021 11:54:06 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 72: > >> 70: The test

Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]

> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

On Thu, 23 Sep 2021 10:56:02 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 95: > >> 93: the tests in `tier

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

On Thu, 23 Sep 2021 09:28:29 GMT, Jie Fu wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 107: > >> 105: (`JTREG_KEYWORDS=\!headfu

Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]

> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

On Thu, 23 Sep 2021 05:44:57 GMT, David Holmes wrote: >> Aleksey Shipilev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert accidental edit >> - More discussion > > doc/testing.html line 73

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's > mention them in `testing.md`. > > Current patch is my braindump, I am open for suggestions :) Aleksey Shipilev has updated the pull request incrementally with two additional commits since the l

Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]

On Wed, 22 Sep 2021 02:05:35 GMT, David Holmes wrote: >> I'll take another stab at it tomorrow. >> >> The whole tiered testing thing encapsulates that some tests are more >> important to run (at least, first or regularly) than others. So we need to >> somehow capture that. Discussing what

Re: RFR: 8274083: Update testing docs to mention tiered testing

On Tue, 21 Sep 2021 15:20:44 GMT, Alan Bateman wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > doc/testing.html line 77: > >> 75: tier1: This test

RFR: 8274083: Update testing docs to mention tiered testing

Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`. Current patch is my braindump, I am open for suggestions :) - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/5615/files Webrev:

Integrated: 8273797: Stop impersonating "server" VM in all VM variants

On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote: > As the follow-up for Zero-specific JDK-8273494, we might want to clean up > build system logic for all VM variants: stop impersonating "server" VMs for > all of them. This basically leaves "core" and &q

Re: RFR: 8273927: Enable hsdis for riscv64

On Fri, 17 Sep 2021 08:38:09 GMT, Aleksey Shipilev wrote: > Currently compiled `hsdis-riscv64.so` binary complains: > > > hsdis: bad native mach=architecture not set in Makefile!; please port hsdis > to this platform > > > It seems to be as simple as poi

Integrated: 8273927: Enable hsdis for riscv64

On Fri, 17 Sep 2021 08:38:09 GMT, Aleksey Shipilev wrote: > Currently compiled `hsdis-riscv64.so` binary complains: > > > hsdis: bad native mach=architecture not set in Makefile!; please port hsdis > to this platform > > > It seems to be as simple as poi

Re: RFR: 8273797: Stop impersonating "server" VM in all VM variants

On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote: > As the follow-up for Zero-specific JDK-8273494, we might want to clean up > build system logic for all VM variants: stop impersonating "server" VMs for > all of them. This basically leaves "core" and &q

RFR: 8273927: Enable hsdis for riscv64

Currently compiled `hsdis-riscv64.so` binary complains: hsdis: bad native mach=architecture not set in Makefile!; please port hsdis to this platform It seems to be as simple as point to the right BFD arch. Additional testing: - [x] Linux RISC-V port, `-XX:+PrintAssembly` works

Re: RFR: 8273797: Stop impersonating "server" VM in all VM variants

On Wed, 15 Sep 2021 10:02:19 GMT, Aleksey Shipilev wrote: > As the follow-up for Zero-specific JDK-8273494, we might want to clean up > build system logic for all VM variants: stop impersonating "server" VMs for > all of them. This basically leaves "core" and &q

Integrated: 8273801: Handle VMTYPE for "core" VM variant

On Wed, 15 Sep 2021 09:55:22 GMT, Aleksey Shipilev wrote: > Building with --with-jvm-variants=core currently produces a binary that > replies an odd version: > > > $ build/linux-x86_64-core-fastdebug/images/jdk/bin/java -version > openjdk version "18-internal"

  1   2   3   4   5   >