Re: RFR(XS): 8211837: Creation of the default CDS Archive should depend on ENABLE_CDS

Hi Volker, Looks good. Thanks for fixing! It would be good to update the following comment in jdk-options.m4 to add AIX, minimal and core.  609  610 #  611 # Disable the default CDS archive generation  612 #  

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Thanks, David! Jiangli On 9/17/18 4:45 PM, David Holmes wrote: Hi Jiangli, Conversion looks good. Thanks, David On 18/09/2018 8:15 AM, Jiangli Zhou wrote: Please review the change for JEP 341 (Default CDS Archives) sub-task, JDK-8210592. Currently, there are sub-sets of tiered tests

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Thanks, Erik! Jiangli On 9/17/18 4:42 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-09-17 15:15, Jiangli Zhou wrote: Please review the change for JEP 341 (Default CDS Archives) sub-task, JDK-8210592. Currently, there are sub-sets of tiered tests running in CDS mode (defined

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Thanks, Misha! Jiangli > On Sep 17, 2018, at 4:17 PM, mikhailo wrote: > > Change looks good, > > Misha > > >> On 09/17/2018 03:15 PM, Jiangli Zhou wrote: >> Please review the change for JEP 341 (Default CDS Archives) sub-task, >> JDK-8210592. >>

RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Please review the change for JEP 341 (Default CDS Archives) sub-task, JDK-8210592. Currently, there are sub-sets of tiered tests running in CDS mode (defined in closed tier5 and tier6 test definitions). These tests are also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE is

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

possible breakage on your side. Any comments/feedbacks on the default CDS archive are highly appreciated!   http://cr.openjdk.java.net/~jiangli/8202951/webrev.02/ The above webrev is sync'ed with the lasted jdk/jdk repository today. Thanks! Jiangli On 8/30/18 11:26 AM, Jiangli Zhou wrote: Hi

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

If you fix it like I suggested, you do not need to respin the webrev. /Magnus /Erik Apart from this, I'm more on Erik's line. :-) /Magnus /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JD

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

. :-) /Magnus /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK-8204247). The goal of the JEP is to include a default CDS archive in JDK 12 binary distribution (downloadable from http://jdk.java.net/12

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Here is the updated webre with CheckDefaultArchiveFile.java changes.   http://cr.openjdk.java.net/~jiangli/8202951/webrev.01/ Thanks, Jiangli On 8/28/18 11:09 AM, Jiangli Zhou wrote: On 8/28/18 9:33 AM, Ioi Lam wrote: The JVM and test changes look good. I just have one comment

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

uild changes look good to me (but should probably get review from someone else). /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK-8204247). The goal of the JEP is to include a default CDS archive in J

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Thanks, Erik! Jiangli On 8/28/18 9:25 AM, Erik Joelsson wrote: Build changes look good to me (but should probably get review from someone else). /Erik On 2018-08-27 13:33, Jiangli Zhou wrote: Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK

RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

Please review the implementation for JEP JDK-8204247 (https://bugs.openjdk.java.net/browse/JDK-8204247). The goal of the JEP is to include a default CDS archive in JDK 12 binary distribution (downloadable from http://jdk.java.net/12/). The default CDS archive is generated using the default

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

Thanks a lot for reviewing, Mandy! Jiangli > On Jul 6, 2018, at 1:40 PM, mandy chung wrote: > > Hi Jiangli, > > On 6/28/18 4:15 PM, Jiangli Zhou wrote:> webrev: > http://cr.openjdk.java.net/~jiangli/8202035/webrev.00/ >> RFE: https://bugs.openjdk.java.net/brow

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

> p2i(new_p), p2i(archived)); It is for the case where there is an existing copy of the archived object. Maybe ‘found existing archived copy’ would help? > > > For your consideration, I've incorporated my comments above into > heapShared.cpp. > I

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

Hi Erik, Thank you for the quick review! Jiangli > On Jun 28, 2018, at 5:44 PM, Erik Joelsson wrote: > > Build changes look good. > > /Erik > > > On 2018-06-28 16:15, Jiangli Zhou wrote: >> This is a follow-up RFE of JDK-8201650 (Move iteration order randomi

RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

This is a follow-up RFE of JDK-8201650 (Move iteration order randomization of unmodifiable Set and Map to iterators), which was resolved to allow Set/Map objects being archived at CDS dump time (thanks Claes and Stuart Marks). In the current RFE, it archives the set of system ModuleReference

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

> On Jun 19, 2018, at 5:21 AM, Volker Simonis wrote: > > On Tue, Jun 19, 2018 at 9:25 AM, David Holmes wrote: >> Hi Volker, >> >> On 19/06/2018 4:50 PM, Volker Simonis wrote: >>> >>> On Tue, Jun 19, 2018 at 6:54 AM, David Holmes >>> wrote: Hi Volker, v3 looks much

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

Hi Volker, Thanks for adding CDS_ONLY to all FileMapInfo fields. It looks cleaner also with Thomas and David’s suggestion to remove the macros in globals.hpp and javaClasses.cpp. Thanks! Jiangli > On Jun 18, 2018, at 9:04 AM, Volker Simonis wrote: > > On Mon, Jun 18, 2018 at 8:17 AM, David

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

s harmless. Thanks for the explanation. For consistency, would it be worth to add CDS_ONLY for the non-static fields in FileMapInfo also? Thanks, Jiangli > > Regards, > Volker > > > On Thu, Jun 14, 2018 at 6:42 PM, Jiangli Zhou wrote: >> Hi Volker, >> &g

Re: RFR(M): 8204965: Fix '--disable-cds' and disable CDS on AIX by default

Hi Volker, The changes look good to me overall. I’ll refer to the JVMTI experts for jvmtiEnv.cpp change. I have a question for the change in vmStructs.cpp. Any reason why only _current_info needs CDS_ONLY? //

Re: RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

the record that I think the way we handle both __TIME__/__DATE__ in > hotspot, and ad-hoc version strings in general, is broken and leave much to > be desired. +1 on the above (both the review and the usage of __TIME__/__DATE__). Thanks! Jiangli > > /Magnus > > > >

Re: RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

Received: from [10.132.185.167] (/10.132.185.167) >by default (Oracle Beehive Gateway v4.0) >with ESMTP ; Fri, 11 May 2018 14:33:20 -0700 > Subject: Re: RFR: 8199807 & 8202738: AppCDS performs overly restrictive path > matching check > To: Jiangli Zhou <jiangli

RFR: 8199807 & 8202738: AppCDS performs overly restrictive path matching check

Hi, Please review the following webrev that addresses the issue of copied/moved JDK image after generating a CDS archive. Thanks Karen Kinnear and Alan Baterman for initiating the investigation & discussions in this area (especially the ease of usage). Thanks Ioi for implementing a test case

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

> On Apr 27, 2018, at 1:43 AM, David Holmes <david.hol...@oracle.com> wrote: > > On 27/04/2018 4:20 AM, Jiangli Zhou wrote: >>> On Apr 25, 2018, at 10:09 PM, David Holmes <david.hol...@oracle.com> wrote: >>> >>> On 26/04/2018 2:34 PM, Jiangli

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

> On Apr 26, 2018, at 12:21 PM, Calvin Cheung <calvin.che...@oracle.com> wrote: > > > > On 4/26/18, 12:00 PM, Jiangli Zhou wrote: >> Hi Calvin, >> >>> On Apr 26, 2018, at 10:10 AM, Calvin Cheung<calvin.che...@oracle.com> >>> wrote: &

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Calvin, > On Apr 26, 2018, at 10:10 AM, Calvin Cheung <calvin.che...@oracle.com> wrote: > > > > On 4/25/18, 9:34 PM, Jiangli Zhou wrote: >> Here is the incremental webrev with updates that incorporate all feedbacks: >> http://cr.openjdk.java.net/~jian

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Thanks, Magnus and Erik! Jiangli > On Apr 26, 2018, at 8:55 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Build looks good, thanks. > > /Erik > > > On 2018-04-25 21:34, Jiangli Zhou wrote: >> Here is the incremental webrev with updates tha

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

> On Apr 25, 2018, at 10:09 PM, David Holmes <david.hol...@oracle.com> wrote: > > On 26/04/2018 2:34 PM, Jiangli Zhou wrote: >> Here is the incremental webrev with updates that incorporate all feedbacks: >> http://cr.openjdk.java.net/~jiangli/8193213_8182731/web

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

before exiting VM. Full webrev: http://java.se.oracle.com:10065/mdash/jobs/jianzhou-jdk-20180426-0406-20150 Tested all modified tests locally. Rerunning hs-tier1 ~ hs-tier5 tests. Thanks for all the suggestions! Jiangli > On Apr 25, 2018, at 5:24 PM, Jiangli Zhou <jiangli.z...@orac

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi David, > On Apr 25, 2018, at 3:12 PM, David Holmes <david.hol...@oracle.com> wrote: > > Hi Jiangli, > > On 26/04/2018 3:39 AM, Jiangli Zhou wrote: >> Hi David, >> Thanks a lot for the review! >>> On Apr 24, 2018, at 11:17 PM, David Holmes <da

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

ing at this! Jiangli > > /Erik > > > On 2018-04-25 02:17, Magnus Ihse Bursie wrote: >> >> >> On 2018-04-25 08:17, David Holmes wrote: >>> cc'ing build-dev for the makefile change >>> >>> Hi Jiangli, >>> >>> O

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi Magnus, Thanks a lot for the review! Jiangli > On Apr 25, 2018, at 2:17 AM, Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com> wrote: > > > > On 2018-04-25 08:17, David Holmes wrote: >> cc'ing build-dev for the makefile change >> >> Hi Jiang

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

Hi David, Thanks a lot for the review! > On Apr 24, 2018, at 11:17 PM, David Holmes <david.hol...@oracle.com> wrote: > > cc'ing build-dev for the makefile change > > Hi Jiangli, > > On 25/04/2018 10:53 AM, Jiangli Zhou wrote: >> Please review the following ch

Re: RFR: compile-time guard some UseSharedSpaces-only coding with the INCLUDE_CDS macro - was :RE: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro

4323.1/> Looks good. I see Coleen already said she will push the change for you. Thanks, Jiangli > > > Is a second review needed ? > > > Best regards, Matthias > > From: Jiangli Zhou [mailto:jiangli.z...@oracle.com > <mailto:jiangli.z...@oracle.

Re: RFR: compile-time guard some UseSharedSpaces-only coding with the INCLUDE_CDS macro - was :RE: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro

>> I can help you integrate the changes after they are reviewed. > > Thanks for your feedback ! > > I created a bug : > > https://bugs.openjdk.java.net/browse/JDK-8184323 > > > and a webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8184323/ > > >

Re: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro

Hi Matthias, Thank you for noticing that. Yes, it would be helpful if you can add the #if INCLUDE_CDS for CDS only code. I can help you integrate the changes after they are reviewed. Thanks! Jiangli > On Jul 5, 2017, at 6:36 AM, Baesken, Matthias > wrote: > >