On Fri, 10 Jun 2022 09:34:53 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>>
On Tue, 7 Jun 2022 20:05:26 GMT, Jonathan Gibbons wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any
On Tue, 7 Jun 2022 13:05:49 GMT, Magnus Ihse Bursie wrote:
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and
On Thu, 2 Jun 2022 20:59:26 GMT, Jonathan Gibbons wrote:
> Please review a moderate change to enable (most) doclet warnings even if
> doclint is enabled.
>
> Since the introduction of doclint, there was some (small) overlap between the
> small set of warnings generate
On Thu, 2 Jun 2022 23:33:13 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespace
>
> test/langtools/jdk/javadoc/doclet/testDoclintDocletMessages/
at ... revealing a number of latent warnings in the
> JDK API that need to be addressed. The short term fix here is to temporarily
> remove the use of the `-serialwarn` option. See
> [JDK-8287749](https://bugs.openjdk.java.net/browse/JDK-8287749).
Jonathan Gibbons has updated the pull
On Fri, 3 Jun 2022 15:59:04 GMT, Pavel Rappo wrote:
> > I did a visual inspection over the Checker class.
>
> > The test is set up to be a framework to accommodate new cases if any should
> > arise.
>
> This is good. It would be even better if we had a mechanism to reduce risk of
>
On Fri, 3 Jun 2022 07:48:15 GMT, Pavel Rappo wrote:
> > Since the introduction of doclint, there was some (small) overlap between
> > the small set ... and the new larger set ... But, the sets do not overlap
>
> Do or do they not overlap? :)
Ooops. Wrong word. I was meaning that neither set
Please review a moderate change to enable (most) doclet warnings even if
doclint is enabled.
Since the introduction of doclint, there was some (small) overlap between the
small set of warnings generated by the doclet and the new larger set of
diagnostics that could be generated by doclint.
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
javac and javadoc changes look OK
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 13 Dec 2021 05:51:37 GMT, David Holmes wrote:
> Trivial update to change the version to 19-ea, and update the single
> reference to the "current release".
>
> Content changes for 19 will follow.
>
> Thanks,
> David
Marked as reviewed by jjg (Reviewer).
-
PR:
ll directories whose name is not a
> valid Java identifier (or, if easier, contains a `-`, such as `doc-files` or
> `snippet-files`.)
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments
-
C
On Fri, 3 Dec 2021 00:40:03 GMT, Magnus Ihse Bursie wrote:
>> Please review a patch to use snippets in the `java.compiler` documentation,
>> instead of a mix of raw HTML and/or `{@code ...}`. The change is just about
>> the presentation of the code fragments; there are no changes to the
>>
On Fri, 3 Dec 2021 13:47:05 GMT, Erik Joelsson wrote:
>> make/modules/java.compiler/Java.gmk line 30:
>>
>>> 28:
>>> 29: EXCLUDES += \
>>> 30: javax/tools/snippet-files \
>>
>> You can put this just on a single line :-).
>>
>> And I'm frankly not sure if make is happy about having a
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it
Please review a patch to use snippets in the `java.compiler` documentation,
instead of a mix of raw HTML and/or `{@code ...}`. The change is just about
the presentation of the code fragments; there are no changes to the normative
specifications for the module.
One of the examples went to
On Thu, 25 Nov 2021 15:58:58 GMT, Julia Boes wrote:
> This change adds support for the `@toolGuide` tag in class-level API
> documentation.
>
> (A use case is the jwebserver tool, where the
> com.sun.net.httpserver.SimpleFileServer class provides API points for
> extension and customization
Emmanual,
If you're interested, please contact the javadoc-...@openjdk.java.net
list regarding the javadoc fix. While the diff looks promising, it would
require a corresponding regression test.
-- Jon
On 11/19/21 6:24 AM, Emmanuel Bourg wrote:
On Thu, 11 Nov 2021 15:37:09 GMT, Emmanuel
On Fri, 5 Nov 2021 19:47:04 GMT, Andrew Leonard wrote:
>> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654
>>
>> A intermittent problem with the make dependencies means the jdk.javadoc
>> element-list-.txt generation can remove the src defined
>> element|package-list-<7,8,9,10>.txt
I'll update the jtreg build script, and then you'll be able to build
jtreg yourself, and get the jcov from there.
-- Jon
On 11/3/21 9:55 AM, Chaliasos, Stefanos wrote:
Do you know where I can download this version?
In GitHub there are releases until jcov3.0-b07
Stefanos
On Wed, 20 Oct 2021 13:46:43 GMT, Hannes Wallnöfer wrote:
>> Please review a change to add a copy-to-clipboard feature to snippets. I
>> took special care to make the feature usable on mobile devices. Sample
>> output can be viewed and tested here:
>>
>>
On Fri, 22 Oct 2021 09:06:49 GMT, Pavel Rappo wrote:
>> I've traced the execution of a local jtreg run with a debugger and examined
>> the respective `jtr` file. Here is what I saw. The locale that the javadoc
>> under test uses is that of returned by java.util.Locale.getDefault(). This
>>
On Wed, 20 Oct 2021 14:41:43 GMT, Pavel Rappo wrote:
>> I think this should be ok for the general case. Linking to "#" (i.e. empty
>> fragment) is common practice for links that trigger script functions.
>
> What I mean is that the amended test will now pass for a URL which has an
> empty
On Wed, 27 Oct 2021 16:59:57 GMT, Jonathan Gibbons wrote:
>> What I mean is that the amended test will now pass for a URL which has an
>> empty fragment but is not a "button".
>
> I think this change is OK for now. We can make it more restrictive later if
>
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Wed, 18 Aug 2021 22:06:13 GMT, Jonathan Gibbons wrote:
> Please review a small (delete one character) change to improve the error
> messages reported when bad HTML is detected when post-processing the output
> from pandoc to generate the docs.
>
> The change is just to pa
Please review a small (delete one character) change to improve the error
messages reported when bad HTML is detected when post-processing the output
from pandoc to generate the docs.
The change is just to pass the filename as an argument to the command, instead
of just piping the input to
On Fri, 13 Aug 2021 03:51:23 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to have doclnt check for empty
> "descriptions" -- the body of a doc comment, before the block tags.
>
> It is already the case that doclint checks for missing/empty de
their
> over-simplistic minimal comments. It was not possible, in general, to avoid
> updating the source code while preserving line numbers, so in many cases, the
> golden `*.out` files had to be updated as well.
>
> A new test is added, focussing on the different forms of empty/
On Mon, 16 Aug 2021 17:08:13 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
>> 203:
>>
>>> 201: // Don't report an empty description if the
>>> comm
On Fri, 13 Aug 2021 09:21:40 GMT, Hannes Wallnöfer wrote:
>> Please review a relatively simple update to have doclnt check for empty
>> "descriptions" -- the body of a doc comment, before the block tags.
>>
>> It is already the case that doclint checks for missing/empty descriptions in
>>
On Fri, 13 Aug 2021 09:20:19 GMT, Hannes Wallnöfer wrote:
>> Please review a relatively simple update to have doclnt check for empty
>> "descriptions" -- the body of a doc comment, before the block tags.
>>
>> It is already the case that doclint checks for missing/empty descriptions in
>>
Please review a relatively simple update to have doclnt check for empty
"descriptions" -- the body of a doc comment, before the block tags.
It is already the case that doclint checks for missing/empty descriptions in
block tags, like @param, @return, etc.
There are three cases to consider:
*
On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson wrote:
> This patch adds copying of element-list files generated for jdk.javadoc to
> the interim langtools version of jdk.javadoc. I'm also refactoring the
> jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra
> standards
On Tue, 15 Jun 2021 15:35:14 GMT, Maurizio Cimadamore
wrote:
> I can push to 17 if desired, but I'll need a new PR for that
pushing to 17 would be nice; the script is equally broken and unusable there.
-
PR: https://git.openjdk.java.net/jdk/pull/4492
On Tue, 15 Jun 2021 14:04:56 GMT, Maurizio Cimadamore
wrote:
> As the title says (please also refer to the JBS issue which describes all the
> issues in more details), the IDE support for IntelliJ has been updated with
> many enhancements as part of a seemingly innocuous "path handling" fix.
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote:
> Update symbol files in JDK 18 for changes in JDK 17 b26.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4477
On Mon, 7 Jun 2021 19:48:39 GMT, Hannes Wallnöfer wrote:
>> This adds a new kind of summary list for new API added in specific releases,
>> and adds information to the deprecated API list about elements that were
>> deprecated in the given releases.
>>
>> The changes to the code are
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote:
> The @jls and @jvms taglet share most of their functionality. A JLS URL
> looks like
>
> https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1
>
> and a JVMS URL looks like
>
>
>
On Mon, 7 Jun 2021 15:46:45 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8263468
>>
On Mon, 7 Jun 2021 15:00:43 GMT, Hannes Wallnöfer wrote:
>> This adds a new kind of summary list for new API added in specific releases,
>> and adds information to the deprecated API list about elements that were
>> deprecated in the given releases.
>>
>> The changes to the code are
On Fri, 28 May 2021 08:19:33 GMT, Hannes Wallnöfer wrote:
>> This adds a new kind of summary list for new API added in specific releases,
>> and adds information to the deprecated API list about elements that were
>> deprecated in the given releases.
>>
>> The changes to the code are
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote:
> Now that the default behavior of JDK 17 is still
> `-Djava.security.manager=allow`, we can remove the
> `-Djavatest.security.noSecurityManager=true` option from the jtreg command
> line inside `RunTests.gmk`. Three problem-listed langtools
On Thu, 3 Jun 2021 19:05:35 GMT, Jonathan Gibbons wrote:
> Please review changes to the GitHub Actions for the repo, to use jtreg 6.
>
> There are three small parts to the change:
>
> 1. The version info is updated in `make/conf/test-dependencies`
> 2. The new `make/build.
. The format of the tag in the jtreg repo is changed to follow OpenJDK
conventions.
Tested implicitly with GitHub Actions on my fork, seen here:
https://github.com/jonathan-gibbons/jdk/actions/runs/903574304
-
Commit messages:
- use bash for build.sh
- JDK-8268185: Update GitHub Actions
.ROOT`
> files.
>
> All the tests that could be updated ahead of time have been updated. There
> are a few tests remaining that need to be done at this time, because of the
> change in the module name for TestNG 7.3. It changed from a default of
> `testng` to and explicit `org.testn
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
I
Please review the change to update to using jtreg 6.
The primary change is to the jib-profiles.js file, which specifies the version
of jtreg to use, for those systems that rely on this file. In addition, the
`requiredVersion` has been updated in the various `TEST.ROOT` files.
All the tests
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The
On Tue, 1 Jun 2021 22:20:25 GMT, Nikita Gubarkov
wrote:
>> The fix fails on a Mac, where `realpath` is not available by default.
>
> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
> probably need to check `realpath` availability in idea.sh and sugges
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The
On Tue, 20 Apr 2021 22:36:28 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple change to `make/Docs.gmk` to move the link
> for "Other Versions" from a "hidden" link in the top nav bar to an explicit
> link in the "bottom" text. The link
Please review a moderately simple change to `make/Docs.gmk` to move the link
for "Other Versions" from a "hidden" link in the top nav bar to an explicit
link in the "bottom" text. The link is placed to appear after the sentence
beginning "For more information..." and before all the legal text
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote:
> Please review a small change to Docs.gmk, such that the short version string
> in the upper right corner of the main API docs bundle is linked to a page
> that links to other versions of the documentation. While it is not
On Sat, 6 Mar 2021 13:13:02 GMT, liach
wrote:
> Does this change add the "other versions" text under the current version
> info? I don't see where the `Other Versions` text (proposed in the original
> issue) is added. Without that text, imo this utility would be significantly
> less
Please review a small change to Docs.gmk, such that the short version string in
the upper right corner of the main API docs bundle is linked to a page that
links to other versions of the documentation. While it is not so useful in
this release, to be able to access _older_ versions, going
On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote:
> With recent cleanups, several doclint categories have been cleared across the
> JDK and should be enabled in the javadoc build to make sure they stay clean.
>
> Local docs build completes with this stricter set of checks.
-
On Wed, 24 Feb 2021 17:45:19 GMT, Jonathan Gibbons wrote:
> Fix typo-by-omission. A `;` is missing after ``.
>
> This is in the build tools, in the code for the `@jls` taglet, used to
> generate docs. No change to JDK product code.
This pull request has now been integrated
Fix typo-by-omission. A `;` is missing after ``.
This is in the build tools, in the code for the `@jls` taglet, used to generate
docs. No change to JDK product code.
-
Commit messages:
- JDK-8262315: missing ';' in generated entities
Changes:
On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy wrote:
> Using the symbol updating script, update the symbol files for API changes in
> JDK 16 build 31.
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2010
On Fri, 8 Jan 2021 01:58:07 GMT, Jonathan Gibbons wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - Fixing tests after a merge.
>> - Merging master into JD
On Thu, 7 Jan 2021 20:23:16 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Fri, 25 Dec 2020 02:17:16 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing -Xhtmlversion option from doclint and --doclint-format from javac.
>> * Removing
On Thu, 24 Dec 2020 02:54:17 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
>> * Sorting out supported tags and
On Wed, 23 Dec 2020 17:08:55 GMT, Jonathan Gibbons wrote:
>> \s was introduced as a valid escape character in JDK 15 as part of the
>> support for Text Blocks.
>>
>> https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-EscapeSequence
>> https://do
On Wed, 23 Dec 2020 15:53:00 GMT, Jonathan Gibbons wrote:
>> One must-fix item (bad pattern constant.)
>
> \s was introduced as a valid escape character in JDK 15 as part of the
> support for Text Blocks.
>
> https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.ht
On Wed, 23 Dec 2020 05:10:31 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 5th: 8258460: Remove --doclint-format option from javac
>
> One must-fix it
On Fri, 18 Dec 2020 02:34:16 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
>> * Sorting out supported tags and
On Fri, 18 Dec 2020 01:34:15 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
>> * Sorting out supported tags and
On Fri, 18 Dec 2020 02:34:16 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
>> * Sorting out supported tags and
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
>
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incrementally wi
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request incrementally wi
On Thu, 17 Dec 2020 01:40:14 GMT, Yoshiki Sato wrote:
>> HTML4 is no longer supported in javadoc.
>>
>> doclint needs to drop HTML4 support as well.
>> The changes consist of:
>> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
>> * Sorting out supported tags and
On Thu, 17 Dec 2020 04:50:59 GMT, Jonathan Gibbons wrote:
>> Yoshiki Sato has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
On Thu, 12 Nov 2020 03:10:01 GMT, Yoshiki Sato wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
>> 410:
>>
>>> 408: OBSOLETE,
>>> 409: UNSUPPORTED
>>> 410: }
>>
>> On one hand, I don't think we need this level of detail, but on the
e in the file's extension, two
> makefiles are updated to accommodate the new extension: one is for the
> "interim" javadoc used to generate the API docs; the other is for the primary
> javadoc in the main JDK image.
Jonathan Gibbons has updated the pull request with a new target
On Mon, 14 Dec 2020 09:11:31 GMT, Hannes Wallnöfer wrote:
>> This is for JDK16, as a precursor to fixing JDK-8258002.
>>
>> While it is good to be using localized strings in the generated output, the
>> significance for JDK-8258002 is that the strings are now obtained from a
>> resource file,
On Thu, 5 Nov 2020 16:16:44 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Fix merge issues; review feedback
>> - Merge with m
On Thu, 22 Oct 2020 02:40:44 GMT, Jonathan Gibbons wrote:
> This introduces support for a new `@spec` tag that can be used as either an
> inline tag or as a block tag. It is used to identify references to external
> specifications, in such a way that the references can be collected
This is for JDK16, as a precursor to fixing JDK-8258002.
While it is good to be using localized strings in the generated output, the
significance for JDK-8258002 is that the strings are now obtained from a
resource file, and not hardcoded in JavaScript file itself.
The source file `search.js`
On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons wrote:
> This is for JDK16, as a precursor to fixing JDK-8258002.
>
> While it is good to be using localized strings in the generated output, the
> significance for JDK-8258002 is that the strings are now obtained from a
>
On Thu, 3 Dec 2020 09:22:18 GMT, Jan Lahoda wrote:
>> Adding support for record classes in the historical data for ct.sym. This
>> includes a few changes not strictly needed for the change:
>> -updating and moving tests into test/langtools, so that it is easier to run
>> them.
>> -fixing
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
as `{@jls}` and `{@jvms}`.) To
> support bimodal standard tags, some changes to `DocCommentParser` are
> incorporated here.
>
> This change is only the _support_ for the new tag; it does _not_ include any
> changes to API docs to _use_ the new tag.
Jonathan Gibbons has updated
On Mon, 16 Nov 2020 12:44:08 GMT, Magnus Ihse Bursie wrote:
>> Currently, to use the javac server, a horrendously long command line option
>> is created, looking like this: `--server:portfile=> portfile>:sjavac=`, where the sjavac command has
>> had all spaces replaced by %20. Since Project
On Fri, 6 Nov 2020 18:41:15 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Thu, 5 Nov 2020 12:43:03 GMT, Jan Lahoda wrote:
>> Thanks @jonathan-gibbons for your comments! I've tried to update the code
>> based on them, mostly in
>> https://github.com/lahodaj/jdk/commit/743f516c660b577035cdda4510a0bb97937fd9b2
>> and
>> https:/
as `{@jls}` and `{@jvms}`.) To
> support bimodal standard tags, some changes to `DocCommentParser` are
> incorporated here.
>
> This change is only the _support_ for the new tag; it does _not_ include any
> changes to API docs to _use_ the new tag.
Jonathan Gibbons has updated
On Mon, 2 Nov 2020 18:15:09 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview
On Tue, 27 Oct 2020 16:09:45 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
>> line 88:
>>
>>> 86:
>>> 87: @Override
>>> 88: protected Content getDeprecatedOrPreviewLink(Element member) {
>>
>>
On Fri, 16 Oct 2020 16:07:41 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - Removing trailing whitespace.
>> - Merging master into JDK-8250768.
>> - Updating
On Thu, 29 Oct 2020 09:26:05 GMT, Jan Lahoda wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java
>> line 1288:
>>
>>> 1286: case FIELD: case INSTANCE_INIT: case LOCAL_VARIABLE:
>>> case PARAMETER:
>>> 1287: case
On Thu, 29 Oct 2020 09:43:56 GMT, Jan Lahoda wrote:
>> I don't think there should be much interaction with -source .
>> We don't support preview features from previous version or preview class
>> files from previous versions, so I think it should be enough to handle the
>> currently present
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
line 1039:
> 1037: } else if (utils.isVariableElement(element) ||
> utils.isTypeElement(element)) {
> 1038: return getLink(new LinkInfoImpl(configuration, context,
> typeEl
On Wed, 21 Oct 2020 12:43:51 GMT, Hannes Wallnöfer wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 35 commits:
>>
>> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into
>> JDK-8250768
>>
This introduces support for a new `@spec` tag that can be used as either an
inline tag or as a block tag. It is used to identify references to external
specifications, in such a way that the references can be collected together on
a new summary page, called "Other Specifications", available
1 - 100 of 539 matches
Mail list logo
