On Tue, 14 Jun 2022 11:54:40 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix exitTransportWithError signature
>
> make/autoconf/flags-ldflags.m4 line 132:
On Tue, 14 Jun 2022 10:09:37 GMT, Magnus Ihse Bursie wrote:
>> When we started introducing some possibly more intrusive compiler flags and
>> functionality for reproducible builds, we also introduced a flag to turn
>> this off out of an abundance of caution. But we ha
e from our builds, at least on
> linux and windows. There are no more `__DATE__` and `__TIME__` macros in the
> source code.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Fix exitTransportWithError signature
-
On Tue, 14 Jun 2022 09:48:25 GMT, Magnus Ihse Bursie wrote:
> When we started introducing some possibly more intrusive compiler flags and
> functionality for reproducible builds, we also introduced a flag to turn this
> off out of an abundance of caution. But we have been b
When we started introducing some possibly more intrusive compiler flags and
functionality for reproducible builds, we also introduced a flag to turn this
off out of an abundance of caution. But we have been been using this
configuration for a year or so internally within Oracle, with no
On Mon, 13 Jun 2022 06:50:54 GMT, KIRIYAMA Takuya wrote:
>> At default configuration, SOURCE_DATE_EPOCH is exported as environment
>> variable in SetupReproducibleBuild. Then, gcc is affected of
>> SOURCE_DATE_EPOCH environment variable. This value is used only to set
>> SOURCE_DATE_ISO_8601
On Tue, 7 Jun 2022 13:05:49 GMT, Magnus Ihse Bursie wrote:
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
&g
On Mon, 13 Jun 2022 09:47:48 GMT, Severin Gehwolf wrote:
>> What do you mean by "build time information"?
>
> @magicus I think it's `-Xinternalversion` which has different output between
> Windows and Linux of the same build. But to me that's a feature not a bug.
> From the PR description:
>
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Marked as reviewed by ihse (Reviewer).
On Fri, 10 Jun 2022 07:29:49 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>>
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is
On Fri, 10 Jun 2022 11:23:57 GMT, Aleksey Shipilev wrote:
>> If I do that, there need to be some kind of if statement in the called
>> workflow, since if that input argument is left out, we'd get a command line
>> like `sudo dpkg --add-architecture` which I assume is illegal syntax (or,
>>
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used, i
On Fri, 10 Jun 2022 11:22:00 GMT, Aleksey Shipilev wrote:
>> I can merge the two `apt-get install` lines, if you say that it is not
>> necessary to call `update-alternatives` before the second install line. (But
>> does it really speed things up?)
>
>> (But does it really speed things up?)
>
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
This pull request has now been integrated.
Changeset: d0c8ff8f
Author:Magnus Ihse Bursi
On Fri, 10 Jun 2022 07:23:12 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>>
A few changes to the build system is needed for the GHA rewrite
([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
-
Commit messages:
- 8288195: Prepare build system for GHA changes
Changes: https://git.openjdk.org/jdk/pull/9122/files
Webrev:
On Fri, 10 Jun 2022 07:18:34 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>&
On Fri, 10 Jun 2022 09:43:47 GMT, Magnus Ihse Bursie wrote:
>> Also, I think we can speed up this part by merging two `apt-get install`
>> invocation lines together. It was separate before, because it was two steps,
>> unnecessary now.
>
> Ideally, all version informati
On Fri, 10 Jun 2022 07:14:33 GMT, Aleksey Shipilev wrote:
>> .github/workflows/build-cross-compile.yml line 89:
>>
>>> 87: sudo apt-get install gcc-${{ inputs.apt-gcc-version }}
>>> g++-${{ inputs.apt-gcc-version }} libxrandr-dev${{ inputs.apt-architecture
>>> }} libxtst-dev${{
On Fri, 10 Jun 2022 07:09:28 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>>
On Fri, 10 Jun 2022 07:07:11 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>>
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
On Tue, 7 Jun 2022 22:47:32 GMT, Jonathan Gibbons wrote:
>> make/conf/github-actions.conf line 31:
>>
>>> 29:
>>> 30:
>>> JTREG_URL=https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/330/artifact/jtreg/jtreg-6.1+1.tar.gz
>>> 31:
>>>
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
On Wed, 8 Jun 2022 14:46:13 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
Marked as reviewed by ihse (Reviewer).
-
PR:
A
>
> I also needed to make a few tweaks to the build system to play nice with the
> new GHA code.
>
> * The build failure summary is now stored in
> build/$BUILD/make-support/failure-summary.log
>
> * The configure summary now indicates what devkit or sysroot is used,
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote:
>> One can select a testcase by ID when running a jtreg test case directly from
>> jtreg (using the testcase.java#testID syntax). However, this has not been
>> possible to do when launching jtreg indirectly from make.
>>
>> This fix attempts
On Tue, 7 Jun 2022 19:57:48 GMT, Alexey Pavlyutkin
wrote:
> Hi!
>
> Here is a fix to jdk.jdi that fixes reproducible build for Windows. The idea
> of the fix is to re-use value of --with-hotspot-build-time option to generate
> deterministic timestamp exactly like it's done to hotspot
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Wed, 8 Jun 2022 07:47:24 GMT, KIRIYAMA Takuya wrote:
> At default configuration, SOURCE_DATE_EPOCH is exported as environment
> variable in SetupReproducibleBuild. Then, gcc is affected of
> SOURCE_DATE_EPOCH environment variable. This value is used only to set
> SOURCE_DATE_ISO_8601
On Mon, 6 Jun 2022 12:57:25 GMT, Jaikiran Pai wrote:
>> It is currently both tricky and tedious to figure out what went wrong when a
>> jtreg test fails in GHA.
>>
>> We should utilize the full potential of GitHub Action summaries and error
>> annotations to make finding failures easier and
On 2022-06-02 21:26, Andrey Turbanov wrote:
Hello.
I noticed strange warnings produced by 'make test' recently on my
Win11 installation. For example:
$ make test TEST="tier1"
Building target 'test' in configuration 'windows-x86_64-server-release'
/usr/bin/bash: Files/Git/cmd/git: No such file
On Thu, 2 Jun 2022 09:17:59 GMT, Magnus Ihse Bursie wrote:
> I encountered a bunch of issues when running with msys2 on Windows (but one
> of them could have happened on cygwin as well).
>
> * fixpath must set MSYS2_ARG_CONV_EXCL="*" before running cmd.exe to figure
&g
I encountered a bunch of issues when running with msys2 on Windows (but one of
them could have happened on cygwin as well).
* fixpath must set MSYS2_ARG_CONV_EXCL="*" before running cmd.exe to figure out
the temp directory, or msys might interfere with the command line to cmd.
* Paths like
On Thu, 26 May 2022 12:04:41 GMT, Magnus Ihse Bursie wrote:
> It is currently both tricky and tedious to figure out what went wrong when a
> jtreg test fails in GHA.
>
> We should utilize the full potential of GitHub Action summaries and error
> annotations to make finding
On Mon, 30 May 2022 00:10:50 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>>
It is currently both tricky and tedious to figure out what went wrong when a
jtreg test fails in GHA.
We should utilize the full potential of GitHub Action summaries and error
annotations to make finding failures easier and more discoverable.
With this PR, the overview of failures are
On Tue, 24 May 2022 17:09:10 GMT, Magnus Ihse Bursie wrote:
> The logic in BASIC_SETUP_DEVKIT for setting a correct sysroot for Xcode is
> hard to follow. This should be straightened out. We also expose variables
> that are no longer used. So there's a bit of related cleanup.
>
The logic in BASIC_SETUP_DEVKIT for setting a correct sysroot for Xcode is hard
to follow. This should be straightened out. We also expose variables that are
no longer used. So there's a bit of related cleanup.
The new code is more or less functionally equivalent to the old. There were
some
On 2022-05-23 19:16, Andrew Leonard wrote:
Hi,
Has anyone looked into reproducible builds for codesign'd MacOS builds?
Basically Apple codesigning is non-deterministic, which is not surprisingly
I guess, so naturally makes reproducible builds a bit tricky. The general
theme for this sort of
On Tue, 24 May 2022 06:41:52 GMT, Christoph Langer wrote:
> It seems that it was forgotten to add the macOS aarch64 platform to the
> default platforms of workflow_dispatch. Let's fix this.
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8861
On Mon, 23 May 2022 17:25:30 GMT, Magnus Ihse Bursie wrote:
> We have a bunch of configure arguments that has been deprecated for multiple
> releases. These should be removed. In effect, this will raise an error
> instead of a warning if these argument is included on the com
On Mon, 23 May 2022 10:04:14 GMT, Magnus Ihse Bursie wrote:
> Testing ispell + shell magic to locate typos. It worked, but is not scalable
> to the entire JDK. :-( Keep the fixes for the problems found in the make
> directory, though.
This pull request has now been integrated.
We have a bunch of configure arguments that has been deprecated for multiple
releases. These should be removed. In effect, this will raise an error instead
of a warning if these argument is included on the command line for configure.
The deprecated arguments stopped having any effect when they
Testing ispell + shell magic to locate typos. It worked, but is not scalable to
the entire JDK. :-( Keep the fixes for the problems found in the make
directory, though.
-
Commit messages:
- 8287155: Additional make typos
Changes: https://git.openjdk.java.net/jdk/pull/8837/files
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Build changes look good. Thanks for the
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote:
> On AArch64 it is sometimes convenient to have LSE atomics right from the
> start. Currently they are enabled after feature detection and RR reverse
> debugger works incorrectly.
>
> New build configuration feature 'hardlse' is added. If
On Sun, 15 May 2022 20:50:25 GMT, Kim Barrett wrote:
> Please review this cleanup of deprecation warning suppression when building
> for Windows.
>
> This change consists of several parts.
>
> (1) Remove the global deprecation warning suppression when building HotSpot
> for Windows.
>
> (2)
On Fri, 13 May 2022 08:43:35 GMT, Christian Hagedorn
wrote:
>> I'm googling around for some information about -gdwarf-4 but is mostly
>> coming up empty handed. :( I found
>> [this](https://www.phoronix.com/scan.php?page=news_item=GCC-11-DWARF-5-Possible-Default)
>> saying that dwarf-5
On Fri, 8 Apr 2022 11:11:29 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000],
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will
Aren't we embedding this bundle ID in every launcher, so you would
need a .template for each possible launcher that could be
included in an app?
I naively assumed that only the java launcher was needed, since this is
about packaging a Java app, so all you'd need is an entry to your main
On 2022-05-12 13:17, Michael Hall wrote:
I had read this but possibly didn’t grok the issue myself. If I
understand correctly now the conflict isn’t within the application but
across applications to some other application that has already been
added to the Mac App Store that included the
On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
(cc:ing build-dev.)
On 2022-05-12 00:17, Michael Hall wrote:
Is this restricted somehow to Mac App Store applications?
Is a warning issued as stripping native commands may break application
functionality?
Is it not possible for the user to provide their own Info.plist with a
different
On Wed, 11 May 2022 19:14:54 GMT, Lance Andersen wrote:
>> make/autoconf/lib-bundled.m4 line 220:
>>
>>> 218: if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then
>>> 219: LIBZ_CFLAGS="$LIBZ_CFLAGS
>>> -I$TOPDIR/src/java.base/share/native/libzip/zlib"
>>> 220: if test "x$OPENJDK_TARGET_OS"
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLASHSCREEN with
>> bundled zlib
>> -
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On 2022-05-11 16:01, Kim Barrett wrote:
Globally disabling use-after-free warnings for this package seems really
questionable. If these are problems in the code, just suppressing the warning
and leaving the problems to bite us seems like a bad idea. And the problems
ought to be reported
On Wed, 11 May 2022 13:05:45 GMT, Erik Gahlin wrote:
>> make/modules/jdk.jfr/Java.gmk line 26:
>>
>>> 24: #
>>> 25:
>>> 26: DISABLED_WARNINGS_java += exports lossy-conversions
>>
>> Note that with the fix of JDK-8286392 (and JDK-8286396) the
>> `lossy-conversions` warning should not be
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand
On Wed, 11 May 2022 11:38:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>>
On Tue, 10 May 2022 08:46:44 GMT, Severin Gehwolf wrote:
>> `make test TEST="gtest:> `1.10.0`. It expects `suites` to be present in the google test output
>> whereas the OpenJDK build infra code expects `cases`. I'm not sure when/if
>> that changed, but here is a proposed fix.
>>
>> Thoughts?
On Tue, 10 May 2022 01:36:06 GMT, David Holmes wrote:
>> The way LauncherCommon.gmk is currently written, it's only meant to be
>> included from "make/module//Launcher.gmk", or at least only from one
>> single place for each module. This is because the man page generation that
>> happens in
On Mon, 9 May 2022 23:18:47 GMT, Erik Joelsson wrote:
> The way LauncherCommon.gmk is currently written, it's only meant to be
> included from "make/module//Launcher.gmk", or at least only from one
> single place for each module. This is because the man page generation that
> happens in
including the command-line
tools, demos, API documentation, JMOD archives, native libraries, and
man pages -- even when using a different build path. Note that I didn't
test on macOS or Windows.
A big thank you to Magnus Ihse Bursie and Andrew Leonard for doing much
of the work to make this possible.
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>>
On Fri, 29 Apr 2022 22:50:45 GMT, Ioi Lam wrote:
> During `java -Xshare:dump -XX:-UseCompressedOops`, the location of the Java
> heap is chosen by the OS. Due to Address Space Layout Randomization, the heap
> will always start at a different location. This causes the archive for
>
On Fri, 29 Apr 2022 12:43:02 GMT, Magnus Ihse Bursie wrote:
> A debug printout in configure was introduced in JDK-8285093. It should be
> removed.
This pull request has now been integrated.
Changeset: 64225e19
Author:Magnus Ihse Bursie
URL:
https://git.openjdk.java.net/jdk/
A debug printout in configure was introduced in JDK-8285093. It should be
removed.
-
Commit messages:
- 8285919: Remove debug printout from JDK-8285093
Changes: https://git.openjdk.java.net/jdk/pull/8467/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8467=00
Issue:
On Mon, 18 Apr 2022 23:16:18 GMT, Naoto Sato wrote:
> Fixing performance regression caused by the fix to
> https://bugs.openjdk.java.net/browse/JDK-8176706. The fix introduced extra
> looping through the resource map multiple times which was not necessary. The
> execution time of the tool now
On Tue, 19 Apr 2022 20:38:31 GMT, Magnus Ihse Bursie wrote:
> Analogous to `UTIL_ARG_ENABLE`, we need a `UTIL_ARG_WITH` which wraps
> ´AC_ARG_WITH`, provides a declarative rather than programmatic way of
> handling configure arguments. It can also make sure that all edge cases are
Analogous to `UTIL_ARG_ENABLE`, we need a `UTIL_ARG_WITH` which wraps
´AC_ARG_WITH`, provides a declarative rather than programmatic way of handling
configure arguments. It can also make sure that all edge cases are covered, and
that we treat arguments consistently.
This PR contains the
On Tue, 19 Apr 2022 10:41:07 GMT, Magnus Ihse Bursie wrote:
> JEP 298 was about removing demos and samples. Unfortunately,
> [JDK-8173801](https://bugs.openjdk.java.net/browse/JDK-8173801) which should
> have removed all files in src/samples, left a few non-source files (key
On 2022-04-14 19:42, Andrew Hughes wrote:
On 12:57 Wed 13 Apr , Magnus Ihse Bursie wrote:
I disagree completely. We had it this way in mainline originally, but it
was fixed in https://bugs.openjdk.java.net/browse/JDK-8256393.
Prior to this patch, it seems there were no GCC version
On Fri, 15 Apr 2022 11:49:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO
On Thu, 14 Apr 2022 16:13:59 GMT, Andrew Leonard wrote:
> JDK-8282769 added support for more ISO-8601 formats, but remove handling of
> just a date "-MM-DD" being present, which is the case for a configure
> using --with-source-date=version which uses the date string from
>
On Tue, 19 Apr 2022 08:47:18 GMT, Feilong Jiang wrote:
>> This patch adds Zero support for the 32-bit RISC-V architecture.
>>
>> Additional tests:
>>
>> - [x] Linux zero RISCV32 cross-compilation
>> - [x] Resulting binaries run on QEMU User mode without problems
>
> Feilong Jiang has updated
JEP 298 was about removing demos and samples. Unfortunately,
[JDK-8173801](https://bugs.openjdk.java.net/browse/JDK-8173801) which should
have removed all files in src/samples, left a few non-source files (key stores
and images). These should be removed.
-
Commit messages:
-
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fix
I ran `codespell` on the `make` directory, and accepted those changes where it
indeed discovered real typos.
(Due to false positives this can unfortunately not be run automatically)
Most of the fixes are in comments. A few are in messages aimed at the user.
-
Commit messages:
-
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote:
>> Found various typos of expected: `exepected`, `exept`, `epectedly`,
>> `expeced`, `Unexpeted`, etc.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8284853:
On Thu, 14 Apr 2022 12:07:06 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
though
You can modify make/scripts/fixpath.sh, and remove/comment out the line
rm -rf $TEMPDIRS
in the cleanup trap to keep it for post-mortem debugging.
/Magnus
best regards,
Julian
On Wed, Apr 13, 2022 at 7:04 PM Magnus Ihse Bursie
wrote:
On 2022-04-13 05:39, Julian Waters w
On Wed, 13 Apr 2022 11:30:14 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On 2022-04-12 15:21, David Holmes wrote:
On Tue, 12 Apr 2022 11:31:03 GMT, Johannes Bechberger
wrote:
Adds an implementation of the missing method (guarded with `defined(AARCH64) &&
defined(__APPLE__)`) and fixes the compilation issues on Mac M1.
Looks good and trivial.
It seems apparent
On 2022-04-13 05:39, Julian Waters wrote:
Recently I've been getting build failures on my Windows device that go
something along the lines of:
/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/.../x86_64-w64-mingw32/bin/ld.exe:
cannot find
I disagree completely. We had it this way in mainline originally, but it
was fixed in https://bugs.openjdk.java.net/browse/JDK-8256393.
As you might know, I'm not too fond of the GHA solution, since we can't
debug issues with Github's hosts. Nevertheless, many users look at the
GHA results as
1 - 100 of 3173 matches
Mail list logo
