Re: JDK 10u and generated-configure.sh

2018-05-08 Thread Rob McKenna
gt; > On Tue, 2018-05-08 at 14:09 +0100, Rob McKenna wrote: > > Ahem: http://openjdk.java.net/census#jdk-updates > > > > -Rob > > > > On 08/05/18 14:08, Rob McKenna wrote: > > > (also, according to http://db.openjdk.java.net/people/ you have > > &

Re: [jdk10 & jdk8u] Request for Review: 8173654

2017-06-07 Thread Rob McKenna
custom file, if present. > $(eval $(call IncludeCustomExtension, jdk, lib/CoreLibraries.gmk)) > > /Erik > > > On 2017-06-06 19:01, Rob McKenna wrote: > >Hi folks, > > > >We've found it useful to be able to override LIBJAVA_SRC_DIRS / > >LIBJAVA_MAPFILE in libjava

[jdk10 & jdk8u] Request for Review: 8173654

2017-06-06 Thread Rob McKenna
Hi folks, We've found it useful to be able to override LIBJAVA_SRC_DIRS / LIBJAVA_MAPFILE in libjava. This change in 10 allows the former and backports the latter to 8: http://cr.openjdk.java.net/~robm/8173654/ Thanks, -Rob

Re: What to pass to --with-custom-make-dir?

2017-03-03 Thread Rob McKenna
Hi Christian, I'm cc'ing build-dev (and bcc'ing jdk8u-dev) as that may be a more appropriate venue for this discussion. -Rob On 03/03/17 10:19, Christian Thalinger wrote: > At Twitter we are using the custom extension mechanism to separate our > additional code from upstream in order to

Re: [8u76] Request for review & approval for CR8146566: OpenJDK build can't handle commas in LDFLAGS

2016-01-08 Thread Rob McKenna
Approved. (not sure why I didn't explicitly state that in the last mail) -Rob On 08/01/16 13:56, Andrew Hughes wrote: - Original Message - Looks good. /Erik Thanks Erik. Pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/92c6a16b6dac On 2016-01-06 20:12, Rob

Re: [8u76] Request for review & approval for CR8146566: OpenJDK build can't handle commas in LDFLAGS

2016-01-06 Thread Rob McKenna
cc'ing build-dev for a review and updating the subject. -Rob On 06/01/16 19:10, Andrew Hughes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8146566 Webrev: http://cr.openjdk.java.net/~andrew/8u/8146566/webrev.01/ If additional LDFLAGS containing commas are passed to the build

Re: [8u] Request for Approval and Review: JDK-8136980: build for 8u65 and 8u66 for solaris platforms is failing

2015-09-30 Thread Rob McKenna
Approved. -Rob On 30/09/15 14:30, Magnus Ihse Bursie wrote: On 2015-09-30 14:43, Erik Joelsson wrote: Hello, Please approve and review this fix for 8u. My last fix for this issue, JDK-8136691, was not enough. I made a mistake while verifying the fix and the problem is still there.

Re: [8u-dev] Request for approval for JDK-8074554 Create custom hook for running after AC_OUTPUT

2015-03-06 Thread Rob McKenna
Approved. Please add a suitable noreg keyword. -Rob On 06/03/15 14:41, Magnus Ihse Bursie wrote: Requesting approval to backport this JDK9 fix to jdk8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8074554 Original JDK9 changeset:

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

2012-12-22 Thread Rob McKenna
to earlier threads are well worth reading for additional context: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012417.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-June/001747.html -Rob On 30/11/12 03:48, Rob McKenna wrote: Hi

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

2012-12-19 Thread Rob McKenna
/pipermail/core-libs-dev/2009-June/001747.html -Rob On 30/11/12 03:48, Rob McKenna wrote: Hi David, On 30/11/12 02:31, David Holmes wrote: Hi Rob, This is only a superficial scan. The changes in java/java/makefile look pretty horrible. What are all those -R entries? Library search paths