Re: JDK-8061281 (JEP-230): Push Makefiles, repository layout and small set of benchmarks

2015-08-12 Thread Staffan Friberg
Hi Erik, Thank you for the quick review. I have fixed all your comments in this new webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8061281/webrev.02 Cheers, Staffan On 08/12/2015 03:15 AM, Erik Joelsson wrote: Hello, On 2015-08-12 01:34, Staffan Friberg wrote: Hi, Unfortunately we have

JDK-8061281 (JEP-230): Push Makefiles, repository layout and small set of benchmarks

2015-08-11 Thread Staffan Friberg
Hi, Unfortunately we have not yet got the new repositories created in OpenJDK for JEP-230 that was discussed earlier this year [1]. However I wanted to make sure we are ready to push as soon as those repositories are created. These two webrevs contain updates to the build scripts to add the

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-05 Thread Staffan Friberg
Hi, On 12/04/2014 10:23 PM, joe darcy wrote: Hello, On 12/4/2014 4:34 PM, David Holmes wrote: Hi Staffan, On 2/12/2014 10:08 AM, Staffan Friberg wrote: Hi, Hopefully this is the right list for this discussion. As part of adding Microbenchmarks to the OpenJDK source tree, I'm trying

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-05 Thread Staffan Friberg
Hi Jon, On 12/05/2014 01:52 PM, Jonathan Gibbons wrote: On 12/05/2014 11:46 AM, Staffan Friberg wrote: Hi, On 12/04/2014 10:23 PM, joe darcy wrote: Hello, On 12/4/2014 4:34 PM, David Holmes wrote: Hi Staffan, On 2/12/2014 10:08 AM, Staffan Friberg wrote: Hi, Hopefully this is the right

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-04 Thread Staffan Friberg
On 12/03/2014 02:58 AM, Magnus Ihse Bursie wrote: On 2014-12-02 23:45, Christian Thalinger wrote: On Dec 2, 2014, at 2:40 PM, Jonathan Gibbons jonathan.gibb...@oracle.com wrote: Staffan, That seems to put it on the low end for reasonably being its own repo, if you wanted that, at least, as

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-02 Thread Staffan Friberg
are in the same repository that is easier to understand and maintain. $.02, Roger On 12/1/2014 7:08 PM, Staffan Friberg wrote: Hi, Hopefully this is the right list for this discussion. As part of adding Microbenchmarks to the OpenJDK source tree, I'm trying to understand how we best would add

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-02 Thread Staffan Friberg
, Staffan Friberg staffan.frib...@oracle.com wrote: Hi, (Adding the jdk9-dev list to increase the visibility of the discussion) With the multiple sub-repository commit mechanism improved I believe this might be less of an issue. JPRT can push JDK and HS changes at together and the same

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-02 Thread Staffan Friberg
02:08 PM, Staffan Friberg wrote: Hi Chris, Agree, there is no major reason this needs to be a new repository, as I mentioned in the 3 options below it would work well without it. The main thing I want to achieve is that the benchmarks are located on the top level. The suite will contain

Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-01 Thread Staffan Friberg
Hi, Hopefully this is the right list for this discussion. As part of adding Microbenchmarks to the OpenJDK source tree, I'm trying to understand how we best would add the benchmark sources to the existing OpenJDK tree structure. Since the microbenchmark suite will cover all parts of the