RE: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-15 Thread Lindenmaier, Goetz
.@openjdk.java.net > Cc: 2d-dev <2d-...@openjdk.java.net>; build-dev@openjdk.java.net; > Martin Balao Alonso > Subject: Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure > (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1) > > Hi Goetz, > &

Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-14 Thread Martin Balao
Hi Goetz, On 5/13/19 1:38 PM, Lindenmaier, Goetz wrote: > > Can I somehow verify that it's the font that has the problem? > Can I fix the font so that the test passes? > I cannot say whether or not the static max advance value in each font is right or not, but let's assume it is. The

Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-14 Thread Martin Balao
Hi Goetz, Thanks for raising this issue. I'm not surprised by MaxAdvanceIsMax test failing on some OS. The reason is that this test is very OS specific. All installed fonts are tested and a static value from each font is used for the assertion, after scale calculations. If there is a difference

RE: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-13 Thread Lindenmaier, Goetz
failure > (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1) > > Hi Goetz, > > Thanks for raising this issue. > > I'm not surprised by MaxAdvanceIsMax test failing on some OS. The reason > is that this test is very OS specific. > > All insta

RE: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-08 Thread Lindenmaier, Goetz
r, Christoph > ; jdk-updates-...@openjdk.java.net > Cc: 2d-dev <2d-...@openjdk.java.net>; build-dev@openjdk.java.net; > Martin Balao Alonso > Subject: Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure > (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-07 Thread Severin Gehwolf
On Tue, 2019-05-07 at 14:51 +, Lindenmaier, Goetz wrote: > I checked the tests, and the only somewhat related > failing one is java/awt/FontMetrics/MaxAdvanceIsMax.java, > but that is also failing without your patch. How is it failing and has a bug been create for this failure if it's not a

RE: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-05-07 Thread Lindenmaier, Goetz
> Subject: [CAUTION] [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1 > > Hi, > > please help reviewing the backport of JDK-8210782: Upgrade HarfBuzz to the > latest 2.3.1. > > This has been backported to 11.0.4-oracle already. I took the large change > down to

RE: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-05-07 Thread Langer, Christoph
Ping: Can I please get a review for this? From: Langer, Christoph Sent: Dienstag, 30. April 2019 11:26 To: jdk-updates-...@openjdk.java.net Cc: 2d-dev <2d-...@openjdk.java.net>; build-dev@openjdk.java.net; Baesken, Matthias Subject: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3

[11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-04-30 Thread Langer, Christoph
Hi, please help reviewing the backport of JDK-8210782: Upgrade HarfBuzz to the latest 2.3.1. This has been backported to 11.0.4-oracle already. I took the large change down to 11u-dev. It applies quite nicely, apart from a little issue in make/lib/Awt2dLibraries.gmk: --- Awt2dLibraries.gmk