Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
Thanks Mandy. dl On 11/8/18 1:02 PM, Mandy Chung wrote: On 11/8/18 12:37 PM, dean.l...@oracle.com wrote: On 11/8/18 11:49 AM, Mandy Chung wrote: This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help.

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Mandy Chung
On 11/8/18 12:37 PM, dean.l...@oracle.com wrote: On 11/8/18 11:49 AM, Mandy Chung wrote: This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help. Sorry, the error is if I remove both --upgrade-module-path

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Mandy Chung
This is strange.  upgrade module path precedes the application module path in the search path.  I would not expect --module-path would help. Can you get the full javac command to see what are being compiled and all the paths set in these options? Mandy On 11/8/18 11:28 AM, dean.l...@oracle.com

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
I get this without --module-path:   Fatal Error: Unable to find package java.lang in classpath or bootclasspath I guess before, when it was using the unnamed module, that it was picking up these system classes from the jdk10 bootjdk, which doesn't seem ideal. It works without

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread dean . long
Thanks Erik. dl On 11/8/18 9:02 AM, Erik Joelsson wrote: Hello, The build changes look ok as long as Jon and Mandy are happy with how javac is invoked. /Erik On 2018-11-07 19:56, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8213348

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-08 Thread Erik Joelsson
Hello, The build changes look ok as long as Jon and Mandy are happy with how javac is invoked. /Erik On 2018-11-07 19:56, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8213348 https://bugs.openjdk.java.net/browse/JDK-8211781

Re: RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-07 Thread Mandy Chung
Hi Dean, On 11/7/18 7:56 PM, dean.l...@oracle.com wrote: https://bugs.openjdk.java.net/browse/JDK-8213348 https://bugs.openjdk.java.net/browse/JDK-8211781 http://cr.openjdk.java.net/~dlong/8213348/webrev/ 108 --module-path $(JDK_OUTPUTDIR)/modules \ 109 --upgrade-module-path

RFR(M) 8213348: jdk.internal.vm.compiler.management service providers missing in module descriptor

2018-11-07 Thread dean . long
https://bugs.openjdk.java.net/browse/JDK-8213348 https://bugs.openjdk.java.net/browse/JDK-8211781 http://cr.openjdk.java.net/~dlong/8213348/webrev/ Added new make/gensrc/Gensrc-jdk.internal.vm.compiler.management.gmk to create module-info.java.extra for jdk.internal.vm.compiler.management.  I