Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-23 Thread Andrew Haley
On 22/03/16 22:57, Kim Barrett wrote: >> On Mar 16, 2016, at 6:12 AM, Andrew Haley wrote: > > The change got pushed before I had a chance to look at the revised > version, but I wanted to get back to this part of the discussion. Great! > I agree that Node::operator new invokes

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-22 Thread Kim Barrett
> On Mar 16, 2016, at 6:12 AM, Andrew Haley wrote: The change got pushed before I had a chance to look at the revised version, but I wanted to get back to this part of the discussion. > On 15/03/16 19:15, Kim Barrett wrote: >>> On Mar 15, 2016, at 12:18 AM, Andrew Hughes

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-19 Thread Erik Joelsson
Looks good to me. /Erik On 2016-03-18 05:42, Andrew Hughes wrote: - Original Message - On 2016-03-16 05:25, Andrew Hughes wrote: - Original Message - Hello, As representative for the build-infra group creating the new Hotspot build, I appreciate that the changes are made

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-19 Thread Andrew Hughes
- Original Message - > Looks good to me. > > /Erik > Thanks. Pushed: http://hg.openjdk.java.net/jdk9/dev/rev/9d77f922d694 -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-19 Thread Andrew Hughes
- Original Message - > On 2016-03-16 05:25, Andrew Hughes wrote: > > - Original Message - > >> Hello, > >> > >> As representative for the build-infra group creating the new Hotspot > >> build, I appreciate that the changes are made in configure. That will at > >> least

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-16 Thread Andrew Haley
On 15/03/16 19:15, Kim Barrett wrote: >> On Mar 15, 2016, at 12:18 AM, Andrew Hughes wrote: > > I’ll probably have more to say later; just responding to one point here. > 2. A number of optimisations in GCC 6 lead to a broken JVM. We need to add

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-16 Thread Erik Joelsson
On 2016-03-16 05:25, Andrew Hughes wrote: - Original Message - Hello, As representative for the build-infra group creating the new Hotspot build, I appreciate that the changes are made in configure. That will at least automatically force me to merge them correctly when they hit the

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-15 Thread Andrew Hughes
- Original Message - > Hello, > > As representative for the build-infra group creating the new Hotspot > build, I appreciate that the changes are made in configure. That will at > least automatically force me to merge them correctly when they hit the > build-infra forest and will make

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-15 Thread Andrew Hughes
- Original Message - > Just a couple of FYIs: > > 1. hotspot groups require copyright updates on pushes to hotspot > forests; other groups do not. Hence many non-hotspot sources have out of > date copyrights - these will eventually be fixed en-masse. > Ok, file updated. > 2. The

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-15 Thread Kim Barrett
> On Mar 15, 2016, at 12:18 AM, Andrew Hughes wrote: I’ll probably have more to say later; just responding to one point here. >>> 2. A number of optimisations in GCC 6 lead to a broken JVM. We need to >>> add -fno-delete-null-pointer-checks and -fno-lifetime-dse to get a

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-15 Thread Severin Gehwolf
On Mon, 2016-03-14 at 18:55 -0400, Kim Barrett wrote: [...] > > > > 2. A number of optimisations in GCC 6 lead to a broken JVM. We need to > > add -fno-delete-null-pointer-checks and -fno-lifetime-dse to get a > > working JVM. > I don't have any suggestions for why gcc6 might be having problems

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-15 Thread Erik Joelsson
Hello, As representative for the build-infra group creating the new Hotspot build, I appreciate that the changes are made in configure. That will at least automatically force me to merge them correctly when they hit the build-infra forest and will make the merge easier. The idea is to start

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread David Holmes
Just a couple of FYIs: 1. hotspot groups require copyright updates on pushes to hotspot forests; other groups do not. Hence many non-hotspot sources have out of date copyrights - these will eventually be fixed en-masse. 2. The CXXFLAGS situation, as alluded, arose out of confusion with the

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread Kim Barrett
> On Mar 14, 2016, at 3:17 PM, Andrew Hughes wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 > Webrev: http://cr.openjdk.java.net/~andrew/8151841/webrev.01/ > > A number of additional flags need to be passed to the C and C++ compiler > for OpenJDK to

RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 Webrev: http://cr.openjdk.java.net/~andrew/8151841/webrev.01/ A number of additional flags need to be passed to the C and C++ compiler for OpenJDK to compile with GCC 6: 1. The C++ standard needs to be explicitly lowered to the old default of