On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote:
Almost there! :-)
1) Comment in config.sub identifies it as config.guess.
2) As as understand it, your first attempt is to just dispatch through
to autoconf-config.sub if there is no aarch64 arguments. Good! However,
the code could be
On 2014-11-21 18:02, Andrew Haley wrote:
On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote:
1) Comment in config.sub identifies it as config.guess.
2) As as understand it, your first attempt is to just dispatch through
to autoconf-config.sub if there is no aarch64 arguments. Good! However,
the
Thank you, Magnus
I will push this into aarch64 staging repo after testing in JPRT.
Vladimir
On 11/21/14 10:03 AM, Magnus Ihse Bursie wrote:
On 2014-11-21 18:02, Andrew Haley wrote:
On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote:
1) Comment in config.sub identifies it as config.guess.
One minor comment: do we want to preserve the history in the new
config.sub,
or check it in as a new file?
dl
On 11/21/2014 10:03 AM, Magnus Ihse Bursie wrote:
On 2014-11-21 18:02, Andrew Haley wrote:
On 11/21/2014 03:46 PM, Magnus Ihse Bursie wrote:
1) Comment in config.sub identifies it
The history is preserved since patch is applied above config.sub.
I did 'hg copy config.sub autoconf-config.sub' and then applied the patch.
And there are only 2 changesets in config.sub:
changeset: 574:b66c81dfa291
user:ohair
date:Mon Jan 14 16:38:25 2013 -0800
summary:
I was thinking 'hg mv config.sub autoconf-config.sub' and then
'hg add config.sub' so it doesn't look like we are modifying the
upstream version
of config.sub, but maybe it's not a big deal?
dl
On 11/21/2014 12:03 PM, Vladimir Kozlov wrote:
The history is preserved since patch is applied
On 11/21/2014 06:03 PM, Magnus Ihse Bursie wrote:
Thanks for working through all these iterations!
Oh, the thanks should be the other way around. I really
want this to be right.
Andrew.
This may be a bug in webrev. If 'hg log -f' shows it as a new file,
that should be enough.
dl
On 11/21/2014 2:37 PM, Vladimir Kozlov wrote:
I did as you said:
hg mv common/autoconf/build-aux/config.sub
common/autoconf/build-aux/autoconf-config.sub
$ hg st
M
I think this covers everything that reviewers have mentioned:
http://cr.openjdk.java.net/~aph/aarch64-8064357-4/
Andrew.
On 11/13/2014 03:03 PM, Andrew Haley wrote:
On 11/13/2014 03:00 PM, Magnus Ihse Bursie wrote:
hg mv config.sub autoconf-config.sub
hg cp config.guess config.sub
and then fix config.sub so that it runs autoconf-config.sub and modifies
the output to what you expect it to be from config.sub
10 matches
Mail list logo
