Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-11-18 Thread Erik Joelsson
This version looks good to me. /Erik On 2014-11-05 14:04, Magnus Ihse Bursie wrote: On 2014-09-24 14:39, Magnus Ihse Bursie wrote: After Jigsaw M1, there is a new common unix directory structure. We have used posix in the build system for the same purpose, but this leads to unnecessary

Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-11-18 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 11/18/14 04:41, Erik Joelsson wrote: This version looks good to me. /Erik On 2014-11-05 14:04, Magnus Ihse Bursie wrote: On 2014-09-24 14:39, Magnus Ihse Bursie wrote: After Jigsaw M1, there is a new common unix directory structure. We have used

Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-11-07 Thread Magnus Ihse Bursie
On 2014-11-05 17:13, Volker Simonis wrote: Hi Magnus, I've looked at the change and I think it looks good. For any case I've also run an AIX build with your change applied and didn't encounter any problems. So thumbs up from me! Thanks! Regards, Volker PS: how did you produce a webrev

Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-11-05 Thread Magnus Ihse Bursie
On 2014-09-24 14:39, Magnus Ihse Bursie wrote: After Jigsaw M1, there is a new common unix directory structure. We have used posix in the build system for the same purpose, but this leads to unnecessary conversations. Instead, we should use unix all way through in the build system. Also,

Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-11-05 Thread Volker Simonis
Hi Magnus, I've looked at the change and I think it looks good. For any case I've also run an AIX build with your change applied and didn't encounter any problems. So thumbs up from me! Regards, Volker PS: how did you produce a webrev from two repositories - do you have a special version of

RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-09-24 Thread Magnus Ihse Bursie
After Jigsaw M1, there is a new common unix directory structure. We have used posix in the build system for the same purpose, but this leads to unnecessary conversations. Instead, we should use unix all way through in the build system. Also, this means that OS_API is slightly misleading --

Re: RFR: JDK-8058631 Rename posix to unix in build system to match file name changes

2014-09-24 Thread Martin Buchholz
Philosophically, there's more variation among unices than windows, but windows OSes certainly have some variation over time. Especially if you count the Win98 family, thankfully no longer supported. On Wed, Sep 24, 2014 at 5:39 AM, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: