Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-15 Thread David Holmes
Thanks Erik! Looks okay to me. David On 15/03/2016 8:36 PM, Erik Joelsson wrote: Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-15 Thread Erik Joelsson
Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2 separate entry points, one open and one closed trace.xml. The way xinclude works, I

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-14 Thread David Holmes
On 14/03/2016 11:22 AM, David Holmes wrote: Hi Erik, On 12/03/2016 2:31 AM, Erik Joelsson wrote: Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-13 Thread David Holmes
Hi Erik, On 12/03/2016 2:31 AM, Erik Joelsson wrote: Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-12 Thread Tim Bell
Erik: When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build for build output comparisons to be meaningful

RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-11 Thread Erik Joelsson
Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fixed in preparation for the new hotspot build for build output comparisons to be meaningful