Re: RFR: JDK-8152666: The new Hotspot Build System

On 18/04/2016 5:28 PM, Erik Joelsson wrote: On 2016-04-17 12:37, David Holmes wrote: I missed all the fun while I was on vacation and have still not yet had a chance to look at the actual code, but have one query ... Yeah, bad timing, but time was also running out. There is still time for

Re: RFR: JDK-8152666: The new Hotspot Build System

On 2016-04-17 12:37, David Holmes wrote: I missed all the fun while I was on vacation and have still not yet had a chance to look at the actual code, but have one query ... Yeah, bad timing, but time was also running out. There is still time for adjustments of course. On 6/04/2016 7:10 PM,

Re: RFR: JDK-8152666: The new Hotspot Build System

I missed all the fun while I was on vacation and have still not yet had a chance to look at the actual code, but have one query ... On 6/04/2016 7:10 PM, Erik Joelsson wrote: Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and

Re: RFR: JDK-8152666: The new Hotspot Build System

On 06/04/16 10:14, Erik Joelsson wrote: Hello, I assume the mx projects are for Java code or do they also generate projects for native? The new top level target is only meant to replace the old Visual Studio project generator, at least for now. +1 for having the build system a more central

Re: RFR: JDK-8152666: The new Hotspot Build System

On 2016-04-07 11:57, Magnus Ihse Bursie wrote: On 2016-04-06 11:10, Erik Joelsson wrote: Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and published a new webrev: http://cr.openjdk.java.net/~erikj/8152666/webrev.02/ I'm not

Re: RFR: JDK-8152666: The new Hotspot Build System

On 2016-04-06 11:10, Erik Joelsson wrote: Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and published a new webrev: http://cr.openjdk.java.net/~erikj/8152666/webrev.02/ I'm not sure if I'm formally allowed to be a reviewer, since

Re: RFR: JDK-8152666: The new Hotspot Build System

> On Apr 5, 2016, at 11:14 PM, Erik Joelsson wrote: > > Hello, > > I assume the mx projects are for Java code or do they also generate projects > for native? Also native. Look at the screenshots I posted. Particularly this one:

Re: RFR: JDK-8152666: The new Hotspot Build System

I'm good with all of your replies/resolutions. I did forget to say thanks for sticking with the rework of the HotSpot build system! There have been a few attempts in the past to rework the HotSpot build system, but no one was able to make much progress let alone finish it. Kudos!! Dan On

Re: RFR: JDK-8152666: The new Hotspot Build System

Hello, I assume the mx projects are for Java code or do they also generate projects for native? The new top level target is only meant to replace the old Visual Studio project generator, at least for now. /Erik On 2016-04-06 03:23, Christian Thalinger wrote: On Apr 5, 2016, at 8:10 AM,

Re: RFR: JDK-8152666: The new Hotspot Build System

Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and published a new webrev: http://cr.openjdk.java.net/~erikj/8152666/webrev.02/ On 2016-04-05 20:10, Daniel D. Daugherty wrote: > The new build supports the following variants: > > *

Re: RFR: JDK-8152666: The new Hotspot Build System

> On Apr 5, 2016, at 8:10 AM, Daniel D. Daugherty > wrote: … > make/Main.gmk >No comments other than the 'hotspot-ide-project' target >looks interesting... Btw. there is already support to generate IDE configurations today via mx:

Re: RFR: JDK-8152666: The new Hotspot Build System

On 3/25/16 2:03 AM, Erik Joelsson wrote: Hello, Here is the initial review for the new Hotspot Build System, as described in " JEP 284: New HotSpot Build System". This patch adds the new build system along side the old and makes the new system the default. The old build system will remain

RFR: JDK-8152666: The new Hotspot Build System

Hello, Here is the initial review for the new Hotspot Build System, as described in " JEP 284: New HotSpot Build System". This patch adds the new build system along side the old and makes the new system the default. The old build system will remain for a (hopefully) short while until we feel