Re: RFR: JDK-8223309: test failing due to self-assign-overloaded

2019-05-03 Thread Tim Bell
Erik: Looks good. Tim I agreed to sponsor this off list. While doing a sanity build locally with the compiler we use at Oracle (Xcode 10.1), I discovered that clang does not let us use unknown warnings like we do with GCC: error: unknown warning option '-Wno-self-assign-overloaded'; did you

Re: RFR: JDK-8223309: test failing due to self-assign-overloaded

2019-05-03 Thread Erik Joelsson
I agreed to sponsor this off list. While doing a sanity build locally with the compiler we use at Oracle (Xcode 10.1), I discovered that clang does not let us use unknown warnings like we do with GCC: error: unknown warning option '-Wno-self-assign-overloaded'; did you mean

Re: RFR: JDK-8223309: test failing due to self-assign-overloaded

2019-05-03 Thread Erik Joelsson
Hello, Change looks good, but I would prefer a line break. We try to keep the lines in the makefiles/build system at least close to 80 chars when possible. No need for new webrev if you make this change. /Erik On 2019-05-03 07:44, Johan Vos wrote: Using MacOS X 10.14.4 and Xcode 10.2.1 I