Re: [9] RFR (xs) 8168317: [JVMCI] use reflection instead of jdk 9 Module API in Services.java

2016-10-25 Thread Doug Simon
> On 24 Oct 2016, at 23:24, Christian Thalinger wrote: > > >> On Oct 24, 2016, at 3:48 AM, Erik Joelsson wrote: >> >> Adding build-dev, which should be included when discussing build issues. For >> any new readers, please see [1] for the

RFR: JDK-8168636 More detailed information about native libraries in build log

2016-10-25 Thread Magnus Ihse Bursie
When building native libraries or executables, currently only the basename of the library is printed, e.g. libjvm.so. This is not always a unique identifier, and even when it is, it's not always helpful in understanding what is being built. Example of output without this patch: Creating

Re: RFR: JDK-8168636 More detailed information about native libraries in build log

2016-10-25 Thread Erik Joelsson
Looks good. /Erik On 2016-10-25 09:42, Magnus Ihse Bursie wrote: When building native libraries or executables, currently only the basename of the library is printed, e.g. libjvm.so. This is not always a unique identifier, and even when it is, it's not always helpful in understanding what

Re: RFR: 8168369, , fix for langtools intermittent failures needs to check PRODUCT_HOME

2016-10-25 Thread Erik Joelsson
Looks good to me. /Erik On 2016-10-25 16:37, Tim Bell wrote: Hello In the matter of intermittent test failures when run on 32-bit JVM installs. My previous makefile fix [1] needs to check TESTJAVA instead of JT_JAVA. Note: PRODUCT_HOME becomes TESTJAVA inside langtools/test/Makefile.

RFR: 8168369, , fix for langtools intermittent failures needs to check PRODUCT_HOME

2016-10-25 Thread Tim Bell
Hello In the matter of intermittent test failures when run on 32-bit JVM installs. My previous makefile fix [1] needs to check TESTJAVA instead of JT_JAVA. Note: PRODUCT_HOME becomes TESTJAVA inside langtools/test/Makefile. The bug report: https://bugs.openjdk.java.net/browse/JDK-8168369

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-25 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/24/2016 1:18 PM, Erik Joelsson wrote: The last change looks good and simple to me. /Erik On 2016-10-21 06:55, Pete Brunet wrote: Please see the latest update http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/ The fix now is to

Re: RFR: 8168369, , fix for langtools intermittent failures needs to check PRODUCT_HOME

2016-10-25 Thread joe darcy
Look fine Tim; thanks, -Joe On 10/25/2016 7:37 AM, Tim Bell wrote: Hello In the matter of intermittent test failures when run on 32-bit JVM installs. My previous makefile fix [1] needs to check TESTJAVA instead of JT_JAVA. Note: PRODUCT_HOME becomes TESTJAVA inside

Re: [9] RFR (xs) 8168317: [JVMCI] use reflection instead of jdk 9 Module API in Services.java

2016-10-25 Thread Christian Thalinger
> On Oct 24, 2016, at 9:01 PM, Doug Simon wrote: > >> >> On 24 Oct 2016, at 23:24, Christian Thalinger wrote: >> >> >>> On Oct 24, 2016, at 3:48 AM, Erik Joelsson wrote: >>> >>> Adding build-dev, which should be