On 5/3/19 2:00 PM, Erik Joelsson wrote:
I posted the diff for jdwp-protocol.html below too (but I forgot the
dot in the filename). That file currently does not have any copyright
visible in html, but the new footer looks the same (except for having
a different relative path in the link to
I posted the diff for jdwp-protocol.html below too (but I forgot the dot
in the filename). That file currently does not have any copyright
visible in html, but the new footer looks the same (except for having a
different relative path in the link to copyright.html).
/Erik
On 2019-05-03
Hello, I created a webrev for the previously discussed issue (AIX : -bnorwexec
linker flag).
AIX supports a binary hardening option called SED, see :
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.security/stack_exec_disable.htm
System wide configuration can be done
Change looks good from a build perspective. I can't comment on the
validity of the flag itself for a platform I don't know.
/Erik
On 2019-05-03 05:48, Baesken, Matthias wrote:
Hello, I created a webrev for the previously discussed issue (AIX : -bnorwexec
linker flag).
AIX supports a binary
Erik:
Looks good.
Tim
I agreed to sponsor this off list. While doing a sanity build locally
with the compiler we use at Oracle (Xcode 10.1), I discovered that clang
does not let us use unknown warnings like we do with GCC:
error: unknown warning option '-Wno-self-assign-overloaded'; did you
Hi,
Could I please get reviews for this 8u backport of an optimization fix
pertaining to the hotspot copy of fdlibm? Historically,
sharedRuntimeTrans.cpp and sharedRuntimeTrig.cpp have been compiled
with optimization turned off on x86/x86_64. As JDK-8210416 will be
backported to JDK 8u fixing
Hi, Erik.
I'm happy to see this change go in. It looks good.
Just one comment. When removing the footer in jvmit.html, I suspect that you
also need to make changes to jvmti.xsl, which was also modified when the
copyright footer was inserted in this changeset:
Thanks Iris!
I did not think about jvmti.xsl, but have removed those lines as well now.
New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/
/Erik
On 2019-05-03 09:53, Iris Clark wrote:
Hi, Erik.
I'm happy to see this change go in. It looks good.
Just one comment. When
Hi Scott,
I agree this a good option. Though we still need to create some custom
wix source code for shortcuts, so we can't get rid completely of Java
code generating wix sources.
- Alexey
On 5/2/2019 8:54 PM, Scott Palmer wrote:
Ideally the wix code should be generated by running the
The (optional) specs and man pages should have the same copyright footer
as the generated API docs. This patch adds the logic to add such
footers. It also removes the existing footer in jvmti.html.
Bug: https://bugs.openjdk.java.net/browse/JDK-8223319
Webrev:
Using MacOS X 10.14.4 and Xcode 10.2.1 I could not build jdk/jdk anymore:
/Users/johan/openjdk/jdk/test/hotspot/gtest/classfile/test_symbolTable.cpp:62:6:
error: explicitly assigning value of variable of type 'TempNewSymbol' to
itself [-Werror,-Wself-assign-overloaded]
s1 = s1; // self
Hello.
maybe some of you are aware of the gcc FORTIFY_SOURCE application security
flags.
Developers can enable compile and also runtime checks for some string / memory
related operations with the flag.
See details :
https://access.redhat.com/blogs/766093/posts/1976213
Have you tried
Hi, Erik.
> New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/
The revised webrev looks good.
Thank you!
Iris
> On May 3, 2019, at 11:12 AM, Baesken, Matthias
> wrote:
>
>
>
>
> Hello.
>maybe some of you are aware of the gcc FORTIFY_SOURCE application
> security flags.
> Developers can enable compile and also runtime checks for some string /
> memory related operations with the flag.
>
> See
I agreed to sponsor this off list. While doing a sanity build locally
with the compiler we use at Oracle (Xcode 10.1), I discovered that clang
does not let us use unknown warnings like we do with GCC:
error: unknown warning option '-Wno-self-assign-overloaded'; did you
mean
Hello,
Change looks good, but I would prefer a line break. We try to keep the
lines in the makefiles/build system at least close to 80 chars when
possible. No need for new webrev if you make this change.
/Erik
On 2019-05-03 07:44, Johan Vos wrote:
Using MacOS X 10.14.4 and Xcode 10.2.1 I
Hello Matthias,
We have tried to use it before but later removed it. See
https://bugs.openjdk.java.net/browse/JDK-8050803
/Erik
On 2019-05-03 08:12, Baesken, Matthias wrote:
Hello.
maybe some of you are aware of the gcc FORTIFY_SOURCE application
security flags.
Developers can
Andy,
I've created the following CRs to track the findings:
https://bugs.openjdk.java.net/browse/JDK-8223325
https://bugs.openjdk.java.net/browse/JDK-8223323
- Alexey
On 5/2/2019 5:08 PM, Andy Herrick wrote:
Alexey:
Please file Bugs for these two issues.
/Andy
On 5/2/2019 1:49 PM, Alexey
Hi Erik,
Could you, please, show a simple diff for jvmti.html and jdwp-protocol.html?
Thanks,
Serguei
On 5/3/19 09:37, Erik Joelsson wrote:
The (optional) specs and man pages should have the same copyright
footer as the generated API docs. This patch adds the logic to add
such footers. It
The new footer looks exactly like on the api docs today.
jvmti.html:
36481,36484c36481
<
< Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights
reserved.
<
<
---
> Copyright 1993,
2019, Oracle and/or its affiliates, 500 Oracle Parkway, Redwood Shores,
Thank you, Erik.
Is it the same with the jdwp-protocol.html?
If so then I'm Okay with the fix.
Thanks,
Serguei
On 5/3/19 11:50 AM, Erik Joelsson wrote:
The new footer looks exactly like on the api docs today.
jvmti.html:
36481,36484c36481
<
< Copyright (c) 2002, 2018, Oracle
21 matches
Mail list logo
