Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v15]

2021-11-03 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew Haley
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v16]

2021-11-03 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew Dinn
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > JDK-8182285 added the incremental build capabilities for modules, by hashing > the APIs of each module. > > The original change uses MD5, which is quite weak, and JDK-8214483 allows > `MessageDigest` to have no MD5 implementation.

RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Aleksey Shipilev
JDK-8182285 added the incremental build capabilities for modules, by hashing the APIs of each module. The original change uses MD5, which is quite weak, and JDK-8214483 allows `MessageDigest` to have no MD5 implementation. This is the cause of some build failures when using a FIPS-compliant

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v16]

2021-11-03 Thread Jorn Vernee
On Wed, 3 Nov 2021 13:08:55 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: Running jdk's tests to produce coverage report

2021-11-03 Thread Alan Bateman
On 03/11/2021 16:34, Chaliasos, Stefanos wrote: Thanks Alan, I used the one that jtreg uses. The complete configuration of JCOV for jtreg is: ``` DEFAULT_JCOV_SRC_TAG=jcov3.0-b07 DEFAULT_JCOV_SRC_ARCHIVE_CHECKSUM=c5c26085750628d58de275b3f50a7409300c0497 DEFAULT_ANT_VERSION=1.10.8

Re: Running jdk's tests to produce coverage report

2021-11-03 Thread Chaliasos, Stefanos
Do you know where I can download this version? In GitHub there are releases until jcov3.0-b07 Stefanos From: Alan Bateman Sent: 03 November 2021 16:39 To: Chaliasos, Stefanos ; build-dev@openjdk.java.net Subject: Re: Running jdk's tests to produce coverage

Re: Running jdk's tests to produce coverage report

2021-11-03 Thread Alan Bateman
On 03/11/2021 15:12, Chaliasos, Stefanos wrote: Hello, I'm trying to compute code coverage for langtools in the JDK repo on a Ubuntu 18.04 machine using JDK 18 for the compilation. I have run the following commands: ``` cd /home/user git clone https://github.com/openjdk/jdk.git cd jdk &&

Running jdk's tests to produce coverage report

2021-11-03 Thread Chaliasos, Stefanos
Hello, I'm trying to compute code coverage for langtools in the JDK repo on a Ubuntu 18.04 machine using JDK 18 for the compilation. I have run the following commands: ``` cd /home/user git clone https://github.com/openjdk/jdk.git cd jdk && bash configure && make jdk && cd ../ git clone

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v17]

2021-11-03 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull

Re: Running jdk's tests to produce coverage report

2021-11-03 Thread tim . bell
Hello Stefanos On 11/3/21 08:12, Chaliasos, Stefanos wrote: Hello, I'm trying to compute code coverage for langtools in the JDK repo on a Ubuntu 18.04 machine using JDK 18 for the compilation. I have run the following commands: ``` cd /home/user git clonehttps://github.com/openjdk/jdk.git

Re: Running jdk's tests to produce coverage report

2021-11-03 Thread Chaliasos, Stefanos
Thanks Alan, I used the one that jtreg uses. The complete configuration of JCOV for jtreg is: ``` DEFAULT_JCOV_SRC_TAG=jcov3.0-b07 DEFAULT_JCOV_SRC_ARCHIVE_CHECKSUM=c5c26085750628d58de275b3f50a7409300c0497 DEFAULT_ANT_VERSION=1.10.8

Re: RFR: 8276550: Use SHA256 hash in build.tools.depend.Depend

2021-11-03 Thread Andrew John Hughes
On Wed, 3 Nov 2021 11:54:39 GMT, Aleksey Shipilev wrote: > [JDK-8182285](https://bugs.openjdk.java.net/browse/JDK-8182285) added the > incremental build capabilities for modules, by hashing the APIs of each > module. > > The original change uses MD5, which is quite weak, and >