Re: RFR: JDK-8136385: Various build speed improvements for windows

On 2015-09-11 16:46, Erik Joelsson wrote: Hello, In the build-infra project, I have made various minor build speed improvements for Windows. These mostly affect incremental build performance, but in certain cases normal builds are also greatly affected. I find these worth committing to JDK 9

Re: [9] Review Request: 8079965 Stop ignoring warnings for libawt_lwawt

On 2015-09-14 16:06, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix I remove WARNINGS_AS_ERRORS_clang option from the libawt_lwawt library, and fix some of the issues: - jlong_md.h:69:9: warning: 'ptr_to_jlong' macro redefined. This is because the "jni_util.h" and

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the following changes: - the feature can be disabled by

Re: build concurrency

On 2015-09-15 11:53, Maurizio Cimadamore wrote: Hi Erik, thanks for the explanation. Regarding build times, the current heuristics scores ok on my high-end machine (I get more or less same time as with JDK 8 build) - but with a lower spec machine (i.e. laptop with dual core intel i5) it

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 14:04, Magnus Ihse Bursie wrote: Does this mean that updates to modules.xml between now and the integration-to-come of jigsaw/jake do not anymore need specific approval? I think we should keep the status quo and CC jigsaw-dev when there are changes to modules.xml. If nothing

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 14:06, David M. Lloyd wrote: Also I could be wrong but it looks to me like the jigsaw/jake forest's equivalent module graph has evolved somewhat, and thus doesn't quite match this file anyway. jigsaw/jake is currently at jdk9-b81. There may be changes backed up in jdk9/dev

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

On 2015-09-14 09:24, Christian Thalinger wrote: The JEP itself can be found here: https://bugs.openjdk.java.net/browse/JDK-8062493 Here are the webrevs: http://cr.openjdk.java.net/~kvn/JVMCI/webrev.top/

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 2015-09-16 14:51, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

> On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: > > > > On 16/09/2015 13:28, Magnus Ihse Bursie wrote: >> On 2015-09-11 18:00, Attila Szegedi wrote: >>> Please review the revised changes for JDK-8135251 "Use >>> Unsafe.defineAnonymousClass for loading Nashorn

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 09/16/2015 07:51 AM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: build concurrency

On 2015-09-14 18:05, Erik Joelsson wrote: Hello, When I implemented the heuristic to choose a suitable default concurrency, I only ever worried about the build. I think having tests use the same concurrency setting must be a new feature? In any case, it seems like there is a case for

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 Nashorn changes and modules.xml changes look good to me. -Sundar On 9/16/2015 7:35 PM, Attila Szegedi wrote: On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

> On Sep 16, 2015, at 2:57 AM, Magnus Ihse Bursie > wrote: > > On 2015-09-14 09:24, Christian Thalinger wrote: >> The JEP itself can be found here: >> >> https://bugs.openjdk.java.net/browse/JDK-8062493 >> >>

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

On 16/09/2015 13:57, Magnus Ihse Bursie wrote: : * modules.xml: Make sure you get sign-off from a Jigsaw developer for modifying this file. The update to modules.xml looks fine. -Alan.

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

On 2015-09-16 18:52, Christian Thalinger wrote: On Sep 16, 2015, at 2:57 AM, Magnus Ihse Bursie wrote: On 2015-09-14 09:24, Christian Thalinger wrote: The JEP itself can be found here: https://bugs.openjdk.java.net/browse/JDK-8062493

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

> On Sep 16, 2015, at 10:11 AM, Magnus Ihse Bursie > wrote: > > On 2015-09-16 18:52, Christian Thalinger wrote: >>> On Sep 16, 2015, at 2:57 AM, Magnus Ihse Bursie >>> wrote: >>> >>> On 2015-09-14 09:24, Christian Thalinger

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

> On Sep 16, 2015, at 6:52 AM, Christian Thalinger > wrote: > > >> On Sep 16, 2015, at 2:57 AM, Magnus Ihse Bursie >> wrote: >> >> On 2015-09-14 09:24, Christian Thalinger wrote: >>> The JEP itself can be found here: >>> >>>

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

I updated top and hotspot webrev with latest (build) changes. Vladimir On 9/16/15 2:28 PM, Christian Thalinger wrote: On Sep 16, 2015, at 6:52 AM, Christian Thalinger wrote: On Sep 16, 2015, at 2:57 AM, Magnus Ihse Bursie

Re: RFR (XXL): JEP 243: Java-Level JVM Compiler Interface

I would like to add this change: diff -r 2134e08cc132 src/share/vm/utilities/vmError.cpp --- a/src/share/vm/utilities/vmError.cppWed Sep 16 14:28:33 2015 -1000 +++ b/src/share/vm/utilities/vmError.cppWed Sep 16 15:04:02 2015 -1000 @@ -517,6 +517,10 @@ void

RFR: JDK-8135060: Stop building Xcode projects in install build

Hello, Here is a patch to the top repo with some functional improvements to the common functionality in the makefiles. This is currently needed for the porting the build of some Oracle specific parts to using build-infra style makefiles. The changes include: * Ability to strip binaries at

Re: RFR: JDK-8135060: Stop building Xcode projects in install build

Erik: Here is a patch to the top repo with some functional improvements to the common functionality in the makefiles. This is currently needed for the porting the build of some Oracle specific parts to using build-infra style makefiles. The changes include: * Ability to strip binaries at