Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

- Original Message - > Hello, > > As representative for the build-infra group creating the new Hotspot > build, I appreciate that the changes are made in configure. That will at > least automatically force me to merge them correctly when they hit the > build-infra forest and will make

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

- Original Message - > Just a couple of FYIs: > > 1. hotspot groups require copyright updates on pushes to hotspot > forests; other groups do not. Hence many non-hotspot sources have out of > date copyrights - these will eventually be fixed en-masse. > Ok, file updated. > 2. The

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

> On Mar 15, 2016, at 12:06 AM, Erik Joelsson wrote: > > Any chance I could get a second review on this? Preferably from the hotspot > team. It’s not quite obvious to me what the __FILE__ change is. Maybe an example would help. > > /Erik > > On 2016-03-11 18:16,

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

> On Mar 15, 2016, at 12:18 AM, Andrew Hughes wrote: I’ll probably have more to say later; just responding to one point here. >>> 2. A number of optimisations in GCC 6 lead to a broken JVM. We need to >>> add -fno-delete-null-pointer-checks and -fno-lifetime-dse to get a

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

On Mon, 2016-03-14 at 18:55 -0400, Kim Barrett wrote: [...] > > > > 2. A number of optimisations in GCC 6 lead to a broken JVM. We need to > > add -fno-delete-null-pointer-checks and -fno-lifetime-dse to get a > > working JVM. > I don't have any suggestions for why gcc6 might be having problems

RFR: JDK-8151800: Jib profile for open linux should produce compact profiles images by default

(note the overloaded use of the word profile in this text) The linux open only Jib profiles are meant to be used for the reference implementation builds. These builds should produce the compact profile images in addition to the normal images. This patch changes the linux open only Jib

RE: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors you mentioned. Still I have updated the code as suggested. Added build team for make file review. JPRT build with fix was

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

Build changes look ok. /Erik On 2016-03-15 15:08, Alexander Scherbatiy wrote: On 15/03/16 16:56, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

On 15/03/16 16:56, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145173/webrev.04/ Alexandr : I have build code with VS2013 and I didn't get any errors you mentioned. Still I have updated the code as suggested. I would suggest to

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

Thanks Erik! Looks okay to me. David On 15/03/2016 8:36 PM, Erik Joelsson wrote: Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

Hello, New webrev where "closed" is replaced with "custom". http://cr.openjdk.java.net/~erikj/8151653/webrev.hotspot.02/ Also, to clarify the refactoring of trace.xml here on the list too. I needed to create 2 separate entry points, one open and one closed trace.xml. The way xinclude works, I

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

Any chance I could get a second review on this? Preferably from the hotspot team. /Erik On 2016-03-11 18:16, Erik Joelsson wrote: In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

Hello, As representative for the build-infra group creating the new Hotspot build, I appreciate that the changes are made in configure. That will at least automatically force me to merge them correctly when they hit the build-infra forest and will make the merge easier. The idea is to start