Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-05 Thread Christian Thalinger
> On Apr 5, 2016, at 8:10 AM, Daniel D. Daugherty > wrote: … > make/Main.gmk >No comments other than the 'hotspot-ide-project' target >looks interesting... Btw. there is already support to generate IDE configurations today via mx:

Re: RFR: JDK-8152666: The new Hotspot Build System

2016-04-05 Thread Daniel D. Daugherty
On 3/25/16 2:03 AM, Erik Joelsson wrote: Hello, Here is the initial review for the new Hotspot Build System, as described in " JEP 284: New HotSpot Build System". This patch adds the new build system along side the old and makes the new system the default. The old build system will remain

Re: RFR: JDK-8152691: Compare script broken after Module system

2016-04-05 Thread Tim Bell
Erik: The compare script has several issues after the module system was introduced. I need it to be updated to a clean baseline again. Things fixed in this patch: * Fixed broken conditional for jar/zip comparison * Stop comparing jmods for now, should be redundant enough * module-info.class

RFR: JDK-8152691: Compare script broken after Module system

2016-04-05 Thread Erik Joelsson
Hello, The compare script has several issues after the module system was introduced. I need it to be updated to a clean baseline again. Things fixed in this patch: * Fixed broken conditional for jar/zip comparison * Stop comparing jmods for now, should be redundant enough * module-info.class