RFR(M): 8175300 - Enable artifact resolution for jtreg tests

2017-03-07 Thread Christian Tornqvist
Hi everyone, Please review this change that adds the ability to have external dependencies in jtreg tests. As a proof of concept, I've added Scimark to the Hotspot repository. The concept is this, annotate the test with one or more @Artifact annotation describing the external dependencies,

JarReorder and ensuing grep failing on Windows

2017-03-07 Thread Jeff Berkowitz
Hi, I'm attempting to build OpenJDK on Windows 10 using VS 2010 Developer Edition. I'm working in cygwin and have reviewed the docs and various blog posts in an effort to "follow the rules". My difficulty: around line 268 of CreateJars.gmk, the makefile runs a "grep -e \.class ..." command

Re: What to pass to --with-custom-make-dir?

2017-03-07 Thread Christian Thalinger
> On Mar 6, 2017, at 10:17 PM, Erik Joelsson wrote: > > > > On 2017-03-07 03:22, David Holmes wrote: >> On 7/03/2017 6:32 AM, Christian Thalinger wrote: >>> On Mar 6, 2017, at 8:51 AM, Christian Thalinger wrote: >

Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Mandy Chung
This fix looks okay. Mandy > On Mar 7, 2017, at 12:51 AM, Erik Joelsson wrote: > > Hello, > > The jmods for the imported javafx modules end up with _imported.marker files > in them. The root cause of this issue is that we don't have a coherent naming > scheme for

Re: RFR: JDK-8176271: Still unable to build JDK 9 on some *7 sparcs

2017-03-07 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-03-07 11:33, Erik Joelsson wrote: In JDK-8162354 Jib was adjusted to use a different boot jdk for M7 sparcs. This fix need to be generalized slightly since it also applies to sparc chips with different letters in front of the 7. Bug:

RFR: JDK-8170884 Clean up post-jlink file copying to the images

2017-03-07 Thread Magnus Ihse Bursie
When jlink was removed, the structure of how we copied "extra" files to the image was changed. In fact, there is no longer any such copies in the OpenJDK build, so any code related to this can and should be removed from the open build. Bug: https://bugs.openjdk.java.net/browse/JDK-8170884

RFR: JDK-8176271: Still unable to build JDK 9 on some *7 sparcs

2017-03-07 Thread Erik Joelsson
In JDK-8162354 Jib was adjusted to use a different boot jdk for M7 sparcs. This fix need to be generalized slightly since it also applies to sparc chips with different letters in front of the 7. Bug: https://bugs.openjdk.java.net/browse/JDK-8176271 Patch: diff -r 4d29ee32d926

Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Alan Bateman
As a short term solution then this looks okay to me. -Alan On 07/03/2017 08:51, Erik Joelsson wrote: Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker

Re: RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Magnus Ihse Bursie
Looks good to me. /Magnus On 2017-03-07 09:51, Erik Joelsson wrote: Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed

RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

2017-03-07 Thread Erik Joelsson
Hello, The jmods for the imported javafx modules end up with _imported.marker files in them. The root cause of this issue is that we don't have a coherent naming scheme for our touch/marker files in the build. I have filed JDK-8176264 to address this properly. For the immediate problem I

Re: What to pass to --with-custom-make-dir?

2017-03-07 Thread Erik Joelsson
On 2017-03-07 03:22, David Holmes wrote: On 7/03/2017 6:32 AM, Christian Thalinger wrote: On Mar 6, 2017, at 8:51 AM, Christian Thalinger wrote: On Mar 3, 2017, at 4:09 PM, David Holmes wrote: Hi Christian, I think you need to pass