jdk7/tl/corba: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: ccd42d367593 Author:tbell Date: 2007-11-12 20:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/ccd42d367593 7654322: touch all Makefiles ! make/Makefile ! make/com/Makefile ! make/com/sun/Makefile ! make/com/sun/corba/Makefile ! make/com/sun/corba/se/Makefile

jdk7/tl/hotspot: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: 39fdd477b25b Author:tbell Date: 2007-11-12 20:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/39fdd477b25b 7654322: touch all Makefiles ! agent/make/Makefile ! agent/src/os/linux/Makefile ! agent/src/os/solaris/Makefile ! agent/src/os/solaris/dbx/Makefile !

jdk7/tl/jaxp: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: dd4fa618b39a Author:tbell Date: 2007-11-12 20:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/dd4fa618b39a 7654322: touch all Makefiles ! make/Makefile

jdk7/tl/jaxws: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: a9506f9440d4 Author:tbell Date: 2007-11-12 20:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/a9506f9440d4 7654322: touch all Makefiles ! make/Makefile

jdk7/tl/jdk: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: 9442b90a75e1 Author:tbell Date: 2007-11-12 20:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9442b90a75e1 7654322: touch all Makefiles ! make/Makefile ! make/com/Makefile ! make/com/sun/Makefile ! make/com/sun/crypto/provider/Makefile !

jdk7/tl/langtools: 7654322: touch all Makefiles

2007-11-12 Thread tim . bell
Changeset: 5f835b2631d9 Author:tbell Date: 2007-11-12 20:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5f835b2631d9 7654322: touch all Makefiles ! make/Makefile ! src/share/opensource/javac/Makefile ! test/Makefile

Re: JDK 6 Project

2008-01-07 Thread Tim Bell
Vote: yes Kelly O'Hair wrote: Joe Darcy has proposed the JDK 6 Project [1]. Should the Build Group sponsor this Project? Please cast your vote by replying to this message with either Tim

Re: OpenJDK does not build on Solaris nv82

2008-02-05 Thread Tim Bell
Alexey Ushakov wrote: Hello Max, Actually, we've already found this problem and passed to the team responsible for the code (Cannot provide you bug id at the moment though, but will do as soon as I get it). For now you can use following workaround in openjdk sources (that worked for me):

Re: OpenJDK does not build on Solaris nv82

2008-02-05 Thread Tim Bell
(that is what I run, all the time, as much as possible), but the JDK7 Release Engineering builds are done on Solaris 10 Update 3 (I just checked), and those are not affected by 6637583. We will fix this as soon as we can. Tim Thanks all. Max On Feb 6, 2008, at 1:41 AM, Tim Bell wrote: Alexey

Re: Not sure where to post this...

2008-03-04 Thread Tim Bell
Hi Ted: No, this was a rm -r -f build and make fastdebug_build. I can send you the fastdebug.log file if you think it'll help. Please send it to me (offline): tim.bell (at) sun.com I will try to puzzle out what is going on. I have some from-scratch Windows XP build machines set up and I am

Re: mail.openjdk.java.net: no search tool on the mailing archive.

2008-04-02 Thread Tim Bell
Mark Reinhold wrote: Date: Tue, 01 Apr 2008 10:59:59 +0200 From: [EMAIL PROTECTED] ... Perhaps somebody who knows how this works, can update the OpenJDK coverage at gmane and nabble? Tim, could you please look into updating our coverage on gmane.org? I am working on this. If anyone has

Re: Mercurial repositories offline?

2008-04-22 Thread Tim Bell
Clemens Eisserer wrote: It looks like the mercurial-servers are down, I only get 500 - Internal Server Error. Thanks for letting us know. Is this already known and when can I expect it to be fixed? I restarted the webserver, and it is serving pages again. Let us know if this happens

Re: OpenJDK Build error on Ubuntu 8.04

2008-06-02 Thread Tim Bell
Hello Sam: Somebody please help me to resolve this error. Please find error message in the attachment. [... snip! ...] /home/samkraju/OpenJDK/jdk7/build/linux-i586/gensrc/java/nio/charset/CharsetEncoder.java:142: cannot find symbol symbol : class $replType$ location: class

Re: Improper passing of variables to submake

2008-06-04 Thread Tim Bell
Hi Martin: In OpenJDK7, If you do make sanity from the root of the forest, I get This is new bug-ID 6710904 COMMON_BUILD_ARGUMENTS needs PREVIOUS_..._VERSION settings It should be visible on http://bugs.sun.com/bugdatabase/ in 24 to 48 hours. Tim

Re: Target gnumake images broken in jdk7/tl/jdk

2008-06-05 Thread Tim Bell
Hi Joël: I sync nightly my jdk7/tl/jdk repository with http://hg.openjdk.java.net/jdk7/tl/jdk and build it nightly (gnumake all images). I created a disposable tree by cloning http://hg.openjdk.java.net/jdk7/tl/jdk, and I am checking on this. Note that this will not affect my b29

Re: [PATCH] Remove dependency on JScheme for generating CORBA exceptions

2008-06-19 Thread Tim Bell
Mark Reinhold wrote: Andrew: Thanks for the patch! The CORBA code isn't maintained directly in OpenJDK, but rather in a sub-project of GlassFish (https://glassfish-corba.dev.java.net/). That's why there's no CORBA Group. (The same goes for JAXWS and JAXP.) Ken Cavanaugh owns the

Re: OpenJDK 7 build failure in com/sun/tools

2008-07-02 Thread Tim Bell
Hi Martin: While building images in a mercurial workspace updated as of today, I get /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/classfile : no such file or directory /home/martinrb/ws/build/build/linux-i586/classes/com/sun/tools/javap : no such file or directory make[1]:

hg: jdk7/build/corba: 6759959: VS2008 errors compiling corba sources

2008-10-16 Thread tim . bell
Changeset: a067bf2329ef Author:tbell Date: 2008-10-15 21:24 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/a067bf2329ef 6759959: VS2008 errors compiling corba sources Summary: Update Makefiles to deal with newer Visual Studio releases Reviewed-by: ohair !

Re: Error building openJDK7

2009-03-26 Thread Tim Bell
://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6819847 the work around is to define IMPORT_BINARY_PLUGS=true This was an unintended consequence of the fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6661448 Hope this helps- Tim Bell

Re: Grr....

2009-03-27 Thread Tim Bell
Hi Kelly freetypecheck has been a royal major pain in the you know what So you are not alone. I thought I reviewed some changes you wrote that eliminated the freetypecheck program and instead used something like grep to check for the version information in the freetype header files.

[Fwd: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]]

2009-03-31 Thread Tim Bell
review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]] Date: Tue, 31 Mar 2009 07:08:41 -0700 From: Tim Bell tim.b...@sun.com Kelly O'Hair wrote: I didn't think openjdk7 could build without binary plugs. But I've been a bit disconnected from the jdk work lately. [... snip

Re: [Fwd: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]]

2009-03-31 Thread Tim Bell
Andrew John Hughes wrote: ERROR: Can't locate pre-built libraries. Please check your access to /NOT-SET/re/jdk/1.7.0/promoted/latest/openjdk/binaryplugs/linux-amd64 and/or check your value of ALT_BINARY_PLUGS_PATH. Good to know it is in the queue though, as I was going

Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]

2009-03-31 Thread Tim Bell
- Tim Bell

Re: Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]

2009-03-31 Thread Tim Bell
I wrote: The other case is if a user outside the Sun network sets IMPORT_BINARY_PLUGS=true. Here they will need to set one of the ALT_..._BINARY_PLUGS variables to point to the plugs anyway. Andrew John Hughes wrote: That suggests to me that outside Sun, there is no need for

Re: Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]

2009-03-31 Thread Tim Bell
xiomara.jayas...@sun.com wrote: Thumbs down -- sorry Tim, this fix breaks the product build. Indeed it did. Sigh. I am working on a fix under bug-ID 6824595 OpenJDK fix breaks product build for jdk7. No wonder everyone is afraid to touch these Makefiles. My build checklist just got

hg: jdk7/build/jdk: 6824595: OpenJDK fix breaks product build for jdk7

2009-04-01 Thread tim . bell
Changeset: ecb7723aaa7c Author:tbell Date: 2009-04-01 04:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ecb7723aaa7c 6824595: OpenJDK fix breaks product build for jdk7 Reviewed-by: xdono, ohair ! make/Makefile

Re: OpenJDK6: Bug in genlocales.gmk

2009-04-01 Thread Tim Bell
Georg Koppen wrote: There NAWK=$(NAWK) should be changed to NAWK=$(NAWK). Otherwise I get an error during compiling like /bin/sh -v command not found. Kelly - thanks for filing 6824976 Fix NAWK assignment in shell script jdk/make/java/java/genlocales.gmk It should be visible in a day or

A note for those building OpenJDK7 b58 from the source

2009-05-11 Thread Tim Bell
control build, they will be blindsided (and very surprised :-) by this set of changes. Hope this helps prevent some confusion- Tim Bell [1] http://hg.openjdk.java.net/jdk7/jdk7/langtools/rev/e2722bd43f3a [2] http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/d201987cb76c

Re: mkdemo and NO_IMAGES

2009-06-08 Thread Tim Bell
2. Even if I set NO_IMAGES=true, why is the images still built? Try also setting DEV_ONLY=true. I think these are tied together for some historic reason. Yes - take a look at top-level/make/jdk-rules.gmk, starting at line 65: ifndef DEV_ONLY JDK_BUILD_TARGETS = sanity all

Re: why I cannot build a product version openjdk?

2009-07-01 Thread Tim Bell
Colin(Du Li) wrote: I tried to build a product version jdk by setting environmental variable SKIP_DEBUG_BUILD=true, SKIP_FASTDEBUG_BUILD=true. But I check the output jdk version, the information as follows: openjdk version 1.7.0-internal-debug OpenJDK Runtime Environment (build

Re: Need reviewer - two fixes for one

2009-07-07 Thread Tim Bell
Hi Kelly Need reviewer. 681: java -Xrunhprof crashes when running with classes compiled with targed=7 Related to 6855180, assert logic could get segv, investigation found next one. 6858127: Missing -DNDEBUG on Linux and Windows native code compiles The C/C++ macro NDEBUG when

hg: jdk7/build/jdk: 2 new changesets

2009-08-07 Thread tim . bell
Changeset: 7e491e39ea0f Author:tbell Date: 2009-08-06 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/7e491e39ea0f 6865853: Additional code changes needed to build deploy using WXP SP2 and Visual Studio 2008 Reviewed-by: ohair !

Re: Need reviewers - 6856630: Restructure jaxp repository

2009-08-07 Thread Tim Bell
Kelly O'Hair wrote: Most of the targets (all included) are in the ant script, and listed in ANT_TARGETS. So 'make all' runs 'ant all'. Ah - of course. Now I see it. So this is a very thin Makefile around ant. That is where the world has been headed for quite a while, I guess... Tim

Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-20 Thread Tim Bell
Hi Folks When building OpenJDK, the freetype sanity check compiles a little program to test that the freetype include files and libraries are available, and also that the version number is acceptable. If building on Windows and using a Visual Studio compiler newer than 2003, this program will

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
*macros. */ #define FREETYPE_MAJOR 2 #define FREETYPE_MINOR 3 #define FREETYPE_PATCH 5 Tim -kto Tim Bell wrote: Hi Folks When building OpenJDK, the freetype sanity check compiles a little program to test that the freetype include files and libraries are available, and also

hg: jdk7/build/jdk: 6705913: freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread tim . bell
Changeset: b3aac0db5586 Author:tbell Date: 2009-08-21 12:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b3aac0db5586 6705913: freetype_versioncheck.exe - Unable To Locate Component Summary: Update freetype_versioncheck to deal with newer Visual Studio releases

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
Hi Martin A way to check at runtime, since freetype 2.0.9, is - A new function named `FT_Library_Version' has been added to return the current library's major, minor, and patch version numbers. This is important since the macros FREETYPE_MAJOR,

Re: Please review fix for 6705913 freetype_versioncheck.exe - Unable To Locate Component

2009-08-21 Thread Tim Bell
Hi Martin Well, I have to side with Microsoft on this one. So do I, actually. The O/S directories should be read-only. I take issue with the alternative presented to developers and ISVs all over the world, which is that they must redistribute the runtime with their product. Everyone has to

Re: build failure on solaris-i586: no /usr/jdk/instances/jdk1.6.0/bin/javac

2009-08-24 Thread Tim Bell
Max (Weijun) Wang wrote: It's a new opensolaris 2009.06 installed by lab guys here. In fact, you can see this JDK installation from a LiveCD of opensolaris. Just like a normal JDK, there are bin/ and jre/ (no lib/) under /usr/jdk/instances/jdk1.6.0. But the bin/ directory only

Re: build failure on solaris-i586: no /usr/jdk/instances/jdk1.6.0/bin/javac

2009-08-24 Thread Tim Bell
David Holmes - Sun Microsystems wrote: Tim Bell said the following on 08/25/09 13:51: I am also running OpenSolaris 2009.06 on my home system. /usr/jdk/instances/jdk1.6.0/bin looks more like a JRE than a JDK: So is this a deployment bug or an OpenSolaris bug or what? Surely a JRE should

Re: Should GNU make 3.81 be required?

2009-09-15 Thread Tim Bell
I wrote: I am currently using Cygwin GNU make v3.80 on Windows due to the later Cygwin builds not supporting MS-DOS drive letters or paths: http://hg.openjdk.java.net/jdk7/jdk7/raw-file/tip/README-builds.html#gmake Kelly O'Hair wrote: I have a 3.81 for cygwin at

Re: Should GNU make 3.81 be required?

2009-09-15 Thread Tim Bell
David Holmes wrote: On Solaris 10 /usr/sfw/bin/gmake (which IIRC comes from the Solaris companion CD) is 3.80. Correct - anything in /usr/sfw or /opt/sfw is from a Software Companion CD. /java/devtools/sparc/bin/gnumake is 3.78.1 I presume the devtools version will be updated to 3.81 ?

Re: Should GNU make 3.81 be required?

2009-09-15 Thread Tim Bell
Brad wrote: Kelly O'Hair wrote: I have a 3.81 for cygwin at http://cr.openjdk.java.net/~ohair/make.exe This binary sums to the same value as the one on cmake. Brad Spent way too much time on this in July Wetmore Ow - my head hurts. So we need Windows GNU make version 3.81 that also

Re: Need reviewer - regression in corba build

2009-09-18 Thread Tim Bell
Hi Kelly: We have run into a corba build problem, not all the classes are getting delivered via the corba/dist/lib/classes.jar file. It appears to be some strange interaction with VPATH and the wildcard logic I added recently in changeset

Re: Freetype version check failure - copy of DLL failed

2009-09-30 Thread Tim Bell
Pete Brunet wrote: Thanks Tim, It must be something else. Here are my two environment variables: ALT_FREETYPE_HEADERS_PATH=C:/Progra~1/GnuWin32/include ALT_FREETYPE_LIB_PATH=C:/Progra~1/GnuWin32/lib Good - that looks OK. freetype was installed via the binary installer at

Re: [Fwd: Re: Freetype version check failure - copy of DLL failed]

2009-10-02 Thread Tim Bell
Pete Brunet wrote: I ran make -d sanity today and see the following. I don't know why it doesn't want to build freetype_versioncheck.exe. It doesn't exist. There is however a file named freetype_versioncheck.exe.manifest so to make sure that isn't a problem I commented out its build from

Re: [Fwd: Re: Freetype version check failure - copy of DLL failed]

2009-10-02 Thread Tim Bell
Pete Brunet wrote: Here is what my PATH looks like: $ echo $PATH /usr/local/bin:/usr/bin:/bin:/usr/X11R6/bin:/cygdrive/c/Program Files/Microsoft Visual Studio 9.0/Common7/IDE:/cygdrive/c/Program Files/Microsoft Visual Studio 9.0/VC/BIN:/cygdrive/c/Program Files/Microsoft Visual Studio

Re: 6856630: Restructure jaxp/jaxws repository

2009-10-09 Thread Tim Bell
Kelly O'Hair wrote: I can't see the webrev right now due to the server issues. % date Fri Oct 9 15:08:00 PDT 2009 The fact that we all got this email, and that I can load up http://cr.openjdk.java.net/~andrew/drops/webrev.01/ Makes me hopeful that the .ojn servers are back online. But -

Re: Review request: Zero buildsystem changes

2009-10-14 Thread Tim Bell
Gary Benson wrote: As an update to my previous message, the HotSpot part of this patch was tested and pushed to hotspot-comp last night, so the remaining code for review is this: http://cr.openjdk.java.net/~gbenson/zero-11-build/ I'm going on vacation on Friday 16, returning Monday 26,

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Tim Bell
Andrew John Hughes wrote: The fix for bug 688: http://hg.openjdk.java.net/jdk7/build/jdk/rev/14bd992a breaks the build as it tries to use javah from ALT_JDK_IMPORT_DIR (via JAVA_TOOLS_DIR) which is not set on normal builds. The README tells the user to set ALT_BOOTDIR and changing

Re: Fix for 6888888 breaks the build

2009-10-15 Thread Tim Bell
Andrew John Hughes wrote: (snip!) I think there's still an issue here that makes this patch worth pushing. The 688 fix didn't cause the bug, but merely made it visible to a lot more people. So 6889255 will only hide it again. The build uses JAVA_TOOLS_DIR for javac, javah and javadoc:

Re: Need reviewers - jdk testing changes 6888927

2009-11-03 Thread Tim Bell
Hi Kelly I need some formal reviewers on these jdk/test/Makefile changes. More polish and changes may need to be done later, but there is value in what I have now, and I need lots of help to improve things (and fix some of our testcases). This is a great start. Here is the bugid and

Re: MSSDK61 in windows-amd64 build

2009-12-14 Thread Tim Bell
Max (Weijun) Wang wrote: Hi Kelly This is the first time I build windows-amd64 with Visual Studio 2008. At the freetypecheck stage, it cannot find the MSSDK61 path. According to make/common/shared/Defs-windows.gmk, it's something like -- $(_program_files)/Microsoft

Re: MSSDK61 in windows-amd64 build

2009-12-14 Thread Tim Bell
Hi Max- Is there some reason you stay with v6.0A, rather than upgrading to $(_program_files)/Microsoft SDKs/Windows/v6.1/ ? No reason. 6.0a is the SDK that comes with VS2008, and I didn't realize an upgrade is needed. According to my notes, Kelly got a response from a program manager at

Please review: Bug ID: 6899737 JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-17 Thread Tim Bell
Hi Folks Here is the bug report: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6899737 Here is the proposed fix (works when using both Visual Studio 2003 and VS 2008 on Windows XP SP2): http://cr.openjdk.java.net/~tbell/6899737.00/ This is a blocker for my work on the full Visual Studio

hg: jdk7/build/jdk: 6899737: JDK build fails in make/java/jli because of _vsnprintf macro redefinition

2009-12-18 Thread tim . bell
Changeset: 9956e8d71e06 Author:tbell Date: 2009-12-18 09:40 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9956e8d71e06 6899737: JDK build fails in make/java/jli because of _vsnprintf macro redefinition Summary: Use stdio.h instead when building with Visual Studio 2008

Re: Need reviewer - minor top level make changes

2010-01-07 Thread Tim Bell
Andrew John Hughes wrote: Is it tl or build for this one? Kelly O'Hair wrote: Either one should be fine. Whatever is easier for you. Not sure what the tl schedule is right now. I expect to push TL to master tomorrow afternoon (8 January) for b79. If you don't mind waiting for b81, feel

Re: Build Group Membership vote

2011-05-11 Thread Tim Bell
Vote: yes On Wed, May 11, 2011 at 10:20 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: Should the following person be added as a member of the OpenJDK Build Group? David Katleman http://db.openjdk.java.net/people/katleman David is a member of the Release Engineering team in Santa Clara.

Re: Build Group Membership vote

2011-05-11 Thread Tim Bell
Vote: yes On Wed, May 11, 2011 at 10:55 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: [Sorry about all these emails, but the build-dev alias is the group alias too.] Should the following person be added as a member of the OpenJDK Build Group? Phil Race http://db.openjdk.java.net/people/prr

Re: Should the Build Group sponsor the Build Infrastructure Project?

2011-05-11 Thread Tim Bell
Vote: Yes On Wed, May 11, 2011 at 8:23 AM, Kelly O'Hair kelly.oh...@oracle.com wrote: Should the Build Group sponsor the Build Infrastructure Project [1]? Please cast your vote by replying to this message with either Vote: yes or Vote: no as the first line of the message body.

Re: Should the Build Group sponsor the JDK 8 Project?

2011-05-23 Thread Tim Bell
Vote: yes - Tim

Re: Should the Build Group sponsor the JDK 7 Update project?

2011-06-15 Thread Tim Bell
Vote: yes Tim

Re: Confused about Windows build

2011-10-17 Thread Tim Bell
://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit http://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit2 http://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit3 Tim Bell On Sun, Oct 16, 2011 at 9:07 PM, Phil Race philip.r...@oracle.com wrote: I concur. Out of the box, 32 bit

Re: Need reviewer: corba changes for build infra

2012-03-12 Thread Tim Bell
Hi Kelly Need a reviewer for these build-infra changes to the strip properties utility in the corba repository. 7153266: Adjustments to corba strip property utility (neutral to builds) http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/ Looks good overall. I find this is a bit

Re: Need reviewer: corba changes for build infra

2012-03-12 Thread Tim Bell
I wrote: I find this is a bit alarming - won't it overwrite the input file with the output file?  120             String infile = inIter.next();  121             String outfile = outIter.next(); Sorry, I meant to pick on these lines, and also mention that args.length should be an even

Re: Need reviewer: corba changes for build infra

2012-03-13 Thread Tim Bell
This is all as expected, although perhaps questionable style. Given Fredrik's comments too, are you ok with the changes? Thanks for the back-story on this corner of the build. I am fine with the changes. Tim

Re: Review Request: Build-infra update

2012-06-04 Thread Tim Bell
Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only' prerequisite - I had to look it up as I have only seen it used one other time. http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types Tim On 06/04/12 07:15, Erik Joelsson wrote: I have created a

RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-06-13 Thread Tim Bell
) is resolved. Thanks in advance for your review and feedback - Tim Bell [1] http://openjdk.java.net/projects/code-tools/

Re: Mercurial error: No module named HTMLParser

2012-06-16 Thread Tim Bell
On 06/16/12 09:36, Pete Brunet wrote: When using hg commands I always get: *** failed to import extension defpath from C:\Users\Pete\hg-extensions\defpath\defpath.py: No module named HTMLParser I am using cygwin 1.7.0 (instead of the latest due to needing to run on Windows 7). Did this hg

Re: README-builds.html

2012-06-18 Thread Tim Bell
On 06/18/12 10:25, Andrew Haley wrote: The README-builds.html instructions say... Slow Builds: ... Creating the javadocs can be very slow, if you are running javadoc, consider skipping that step. But there is no information I can find about how to skip that step: I think it's

Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-06-27 Thread Tim Bell
. jtreg test runs of the '-automatic -noshell' tests under test/java/lang test/java/math test/java/util ran as expected (2 failures, both known bugs). Thanks in advance for your review and feedback - I'd like to get these changes in soon. Tim Bell On 06/13/12 22:31, Tim Bell wrote: Hello

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
On 06/27/12 15:26, John Coomes wrote: I only looked at the hotspot changes, which are fine. One minor request. In hotspot/make/windows/makefiles/defs.make: 215 else 216 ifeq ($(USING_MINGW), true) 217 ABS_OUTPUTDIR := $(shell $(CD) $(OUTPUTDIR);$(PWD)) 218 ABS_BOOTDIR

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
. But overall, I see no reason to block this work from being integrated. As long as the current RE MKS builds are ok. JPRT build jobs are going through OK. Thanks for the review- Tim -kto On Jun 27, 2012, at 9:45 AM, Tim Bell wrote: I went over the open changes again and removed some debug code left

RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-02 Thread Tim Bell
it if it is OK). Thanks in advance- Tim Bell [1] http://cr.openjdk.java.net/~tbell/7152336/webrev.02/

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-04 Thread Tim Bell
Additional comments inline: On 07/03/12 00:40, Volker Simonis wrote: Hi, please see my comments inline.. On Tue, Jul 3, 2012 at 7:07 AM, David Holmesdavid.hol...@oracle.com wrote: Hi Tim, On 3/07/2012 1:52 PM, Tim Bell wrote: All- This is the hotspot-only portion of the changes to allow

Re: Need reviewer

2012-07-16 Thread Tim Bell
On 07/16/12 10:52, Kelly O'Hair wrote: Minor change to the get_source/hgforest scripts to allow for trailing // Plus adding the whitespace normalizer perl script to the openjdk7updates forest. 7184406: Adjust get_source/hgforest script to allow for trailing // characters

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-17 Thread Tim Bell
On 07/17/12 17:16, David Holmes wrote: I'm not sure if you are agreeing with me :) so to be clear. We have: Thanks for the clarification. I think we all agree here, but best to be sure. COMPILE_JAVAC=$(BootStrapDir)\bin\javac $(BOOTSTRAP_JAVAC_FLAGS) COMPILE_RMIC=$(BootStrapDir)\bin\rmic

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-07-19 Thread Tim Bell
I wrote: My test build is running now. I'll update the webrev and send out a new URL. The test builds were successful. I also ran full hotspot builds on JPRT using '-release jdk8' and '-release jdk7u6', so there is no regression in the old builds. I believe I have addressed the review

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-08-02 Thread Tim Bell
/shared.make Let me know if there is anything I can do to help you out. Tim On 08/02/12 10:46, Daniel D. Daugherty wrote: Tim, I'm the RT_Baseline gatekeeper this month so I'll take a look at the changes and shepherd them into RT_Baseline. Dan On 8/2/12 11:30 AM, Tim Bell wrote: Ping? I

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-08-03 Thread Tim Bell
On 08/02/12 14:20, Daniel D. Daugherty wrote: http://cr.openjdk.java.net/~tbell/7181175/webrev.01/ Thanks for the review, Dan. make/windows/makefiles/defs.make No comments. make/windows/makefiles/rules.make lines 28-33: Might want to comment on why these paths still use

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-08-03 Thread Tim Bell
:45, Daniel D. Daugherty wrote: Thumbs up on this version. Do you have a commit message ready for this patch? Dan On 8/3/12 1:26 PM, Tim Bell wrote: On 08/02/12 14:20, Daniel D. Daugherty wrote: http://cr.openjdk.java.net/~tbell/7181175/webrev.01/ Thanks for the review, Dan. make/windows

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-08-03 Thread Tim Bell
On 08/03/12 15:09, Daniel D. Daugherty wrote: Gotta put 'tbell' in there some where... Can I add you as a reviewer? Oh - that's right. Sure, add me as a reviewer. Tim Dan On 8/3/12 3:58 PM, Tim Bell wrote: Thanks, Dan How about this for a commit message: 7181175: Enable builds

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

2012-08-03 Thread Tim Bell
. Dan -kto On Aug 3, 2012, at 4:21 PM, Daniel D. Daugherty wrote: Added you to the reviewer list. You're also the user for the changeset. The job is in the JPRT-hotspotwest queue heading to RT_Baseline. Dan On 8/3/12 5:08 PM, Tim Bell wrote: On 08/03/12 15:09, Daniel D. Daugherty wrote

RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

2012-08-10 Thread Tim Bell
Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using that .bat file. Note that this is not on the 'product' build path at all - this is something

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

2012-08-10 Thread Tim Bell
I wrote: Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using that .bat file. Note that this is not on the 'product' build path at all - this is

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

2012-08-10 Thread Tim Bell
On 08/10/12 14:08, Daniel D. Daugherty wrote: On 8/10/12 3:07 PM, Tim Bell wrote: I wrote: Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

2012-08-11 Thread Tim Bell
On 08/11/12 12:12, Daniel D. Daugherty wrote: On 8/11/12 3:49 AM, Dmitry Samersoff wrote: Dan, On 2012-08-11 01:08, Daniel D. Daugherty wrote: One-line addition of two double quotes... Gotta love Windows. It's not about windows. Unpack workspace to mypath with spaces and try to build

Re: Need reviewers: more predictable binaries

2012-09-06 Thread Tim Bell
On 09/05/12 21:08, Kelly O'Hair wrote: Need a reviewer for this change. http://cr.openjdk.java.net/~ohair/openjdk8/jdk8-this-file/webrev/ It does change source, but it's effectively a build change. The goal here is to try and create more predictable binary files and remove the

Re: RFR: 8000461 Top level build doesn't pass OPENJDK=true through to the hotspot build

2012-10-07 Thread Tim Bell
On 10/07/12 16:36, David Holmes wrote: This is a simple fix contributed by Mark Weilaard to add the OPENJDK=true make variable to COMMON_BUILD_ARGUMENTS so that it gets passed down to the component builds - in particular hotspot: http://cr.openjdk.java.net/~dholmes/8000461/webrev/ Looks

Re: Fwd: Re: How to decrease size of j2sdk_image

2012-10-12 Thread Tim Bell
Hi Jon: Is there, should there be a FAQ for the new build, along the lines of a series of How do I ... questions? -- Jon Have you been through README for the New Build System? http://openjdk.java.net/projects/build-infra/guide.html Section 9 of that doc is a FAQ. We can certainly

hg: jdk8/build/corba: 7152336: Enable builds on Windows with MinGW/MSYS

2012-10-23 Thread tim . bell
Changeset: 0a5931be9176 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by:

hg: jdk8/build/jdk: 7152336: Enable builds on Windows with MinGW/MSYS

2012-10-23 Thread tim . bell
Changeset: a0a2b186ae28 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by:

hg: jdk8/build: 7152336: Enable builds on Windows with MinGW/MSYS

2012-10-23 Thread tim . bell
Changeset: c12e759ac4e8 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair,

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-10-26 Thread Tim Bell
Looks good to me also. Always good to see code deletion take place. Tim On 10/26/12 09:31, Kelly O'Hair wrote: Looks ok to me. We may need to do some builds both ways to make sure. -kto On Oct 26, 2012, at 9:16 AM, Alan Bateman wrote: We're jettisoning the legacy JDBC-ODBC bridge from

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
Anthony: Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ These changes look fine. We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

2012-10-29 Thread Tim Bell
On 10/29/12 12:06, Anthony Petrov wrote: That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. OK, thanks. Sorry if I sounded a bit fussy, but I want to avoid last minute surprises if we can, and it is

Re: XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

2012-11-07 Thread Tim Bell
On 11/06/12 21:08, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default location of objcopy, and just as with native compilation

Re: Review request: 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc

2012-11-07 Thread Tim Bell
On 11/07/12 06:38, Erik Joelsson wrote: This is essentially the patch from Vincent to make build-infra work on Solaris 11.1 with some minor adjustments to keep the new and old build equal. http://cr.openjdk.java.net/~erikj/8002365/webrev.01/

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

2012-11-08 Thread Tim Bell
Looks good to me. Tim On 11/08/12 06:27, Erik Joelsson wrote: New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/ http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.root.02/ Changed to conditional as David suggested. Improved the description and fail message in

Re: CFV: Nomination of Erik Joelsson to OpenJDK Build Group

2012-11-08 Thread Tim Bell
Vote: yes On 11/07/12 09:52, Kelly O'Hair wrote: Please cast your vote or veto by replying to this message

  1   2   3   4   5   6   7   8   9   10   >