Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-19 Thread Christian Thalinger
> On Mar 15, 2016, at 10:51 PM, Erik Joelsson wrote: > > The __FILE__ macro is built into the compiler and evaluates to the file name > of the current source file. It's intended use is for debug messages. In the > rest of the JDK we eliminated its use completely by

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-18 Thread Erik Joelsson
On 2016-03-16 19:17, Christian Thalinger wrote: On Mar 15, 2016, at 10:51 PM, Erik Joelsson wrote: The __FILE__ macro is built into the compiler and evaluates to the file name of the current source file. It's intended use is for debug messages. In the rest of the

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-16 Thread Erik Joelsson
The __FILE__ macro is built into the compiler and evaluates to the file name of the current source file. It's intended use is for debug messages. In the rest of the JDK we eliminated its use completely by providing a macro called THIS_FILE that evaluates to the basename.ext of the source file

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-15 Thread Christian Thalinger
> On Mar 15, 2016, at 12:06 AM, Erik Joelsson wrote: > > Any chance I could get a second review on this? Preferably from the hotspot > team. It’s not quite obvious to me what the __FILE__ change is. Maybe an example would help. > > /Erik > > On 2016-03-11 18:16,

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-15 Thread Erik Joelsson
Any chance I could get a second review on this? Preferably from the hotspot team. /Erik On 2016-03-11 18:16, Erik Joelsson wrote: In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the

Re: RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-13 Thread Tim Bell
Erik: In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the generated binaries some. These changes are: * Standardizing sort order for objects on link command line on Windows to a

RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

2016-03-11 Thread Erik Joelsson
In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the generated binaries some. These changes are: * Standardizing sort order for objects on link command line on Windows to a locale