Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-15 Thread Christian Thalinger
This is amazing! Awesome work. I’m glad this got done so soon. > On Feb 8, 2017, at 9:29 AM, Bob Vandette wrote: > > SUMMARY: > > Please review the following set of changes that adds Ahead-of-time > compilation support for Mac OSX and > Windows x64 in JDK 10.

Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-09 Thread Erik Joelsson
Hello, Looks good, just one minor comment below. On 2017-02-08 20:29, Bob Vandette wrote: SUMMARY: Please review the following set of changes that adds Ahead-of-time compilation support for Mac OSX and Windows x64 in JDK 10. Linux and Solaris x64 AOT support has also been updated to be

Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Mandy Chung
> On Feb 8, 2017, at 11:29 AM, Bob Vandette wrote: > > JDK > —— > > http://cr.openjdk.java.net/~bobv/8172670/jdk/webrev.01/ > The jdk change looks fine. If any change to module-info.java.extra in JDK 9 for jdk.vm.compiler, we should make sure the same change

Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Vladimir Kozlov
On 2/8/17 11:29 AM, Bob Vandette wrote: SUMMARY: Please review the following set of changes that adds Ahead-of-time compilation support for Mac OSX and Windows x64 in JDK 10. Linux and Solaris x64 AOT support has also been updated to be consistent with the new 100% Java based binary

RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Bob Vandette
SUMMARY: Please review the following set of changes that adds Ahead-of-time compilation support for Mac OSX and Windows x64 in JDK 10. Linux and Solaris x64 AOT support has also been updated to be consistent with the new 100% Java based binary container support included in this changeset.