Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-21 Thread Vladimir Kozlov
On 8/21/17 7:05 AM, Bob Vandette wrote: No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue. Leave CodeSectionProcessor.java as it is - don't even change comment. I will update it if needed. No updated webrev needed. Do you want me to

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-21 Thread Bob Vandette
No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue. Do you want me to just push it? Can you send me a diff of the change you want me to add? Bob. > On Aug 19, 2017, at 3:46 PM, Vladimir Kozlov > wrote: > > Bob,

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-21 Thread Erik Joelsson
Build changes look ok. /Erik On 2017-08-15 20:55, Bob Vandette wrote: Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8186115 Webrev: http://cr.openjdk.java.net/~bobv/8186115/

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-19 Thread Vladimir Kozlov
Bob, did you pushed it? If not yes, please fix .mx.graal/suite.py for unit tests Rickard added. They have dependency on jdk.tools.jaotc.collect: test/compiler/aot/jdk.tools.jaotc.test/ They failed when I modified collect and other classes. We need to have dependency on it in suite.py.

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-16 Thread David Holmes
Hi Bob, These changes all seem fine to me. Thanks, David On 16/08/2017 4:55 AM, Bob Vandette wrote: Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8186115 Webrev:

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-16 Thread Christian Thalinger
> On Aug 15, 2017, at 8:55 PM, Bob Vandette wrote: > > Please review these changes for JDK 10 that remove all dependencies on libelf > from the JDK > build system. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8186115 >

Re: RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-15 Thread Vladimir Kozlov
On 8/15/17 11:55 AM, Bob Vandette wrote: Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8186115 Webrev: http://cr.openjdk.java.net/~bobv/8186115/ Good. Compiler team: Please check

RFR: JDK-8186115 - libelf still referenced after 8172670

2017-08-15 Thread Bob Vandette
Please review these changes for JDK 10 that remove all dependencies on libelf from the JDK build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8186115 Webrev: http://cr.openjdk.java.net/~bobv/8186115/ Compiler team: Please check