Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Erik Joelsson
I think this is ok, but we should make sure to add a check in configure in the hotspot build-infra project. /Erik On 2015-10-21 21:46, Christian Thalinger wrote: https://bugs.openjdk.java.net/browse/JDK-8140091 http://cr.openjdk.java.net/~twisti/8140091/webrev/ There is a bit more context in

Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Christian Thalinger
> On Oct 21, 2015, at 10:57 PM, Erik Joelsson wrote: > > I think this is ok, but we should make sure to add a check in configure in > the hotspot build-infra project. Yes, we should do that. I was looking for something like this but couldn’t find any code so I went

Re: RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-22 Thread Vladimir Kozlov
Hotspot changes looks fine. I was surprise that code was added long ago. Thanks, Vladimir On 10/22/15 3:46 AM, Christian Thalinger wrote: https://bugs.openjdk.java.net/browse/JDK-8140091 http://cr.openjdk.java.net/~twisti/8140091/webrev/ There is a bit more context in JIRA but the bottom line

RFR (S): 8140091: remove VMStructs cast_uint64_t workaround for GCC 4.1.1 bug

2015-10-21 Thread Christian Thalinger
https://bugs.openjdk.java.net/browse/JDK-8140091 http://cr.openjdk.java.net/~twisti/8140091/webrev/ There is a bit more context in JIRA but the bottom line is that we shouldn’t be building the JDK with GCC 4.1.1. We have a workaround in just one place but that doesn’t mean the bug doesn’t show