Re: RFR [XS] - 8139026 hotspot.script cannot handle command-line arguments with spaces

2015-10-30 Thread Ioi Lam
On 10/30/15 10:58 AM, Christian Thalinger wrote: On Oct 25, 2015, at 10:34 PM, Ioi Lam wrote: Please review a very small fix: http://cr.openjdk.java.net/~iklam/8139026-hotspot-script-arg-quoating/ Looks good. I’m sure you asked, who is still using this script? Thanks

Re: RFR [XS] - 8139026 hotspot.script cannot handle command-line arguments with spaces

2015-10-30 Thread Christian Thalinger
> On Oct 25, 2015, at 10:34 PM, Ioi Lam wrote: > > Please review a very small fix: > > http://cr.openjdk.java.net/~iklam/8139026-hotspot-script-arg-quoating/ Looks good. I’m sure you asked, who is still using this script? > > Bug: hotspot/make/hotspot.script cannot

Re: RFR [XS] - 8139026 hotspot.script cannot handle command-line arguments with spaces

2015-10-28 Thread Magnus Ihse Bursie
On 2015-10-26 06:34, Ioi Lam wrote: Please review a very small fix: http://cr.openjdk.java.net/~iklam/8139026-hotspot-script-arg-quoating/ Looks good to me. As you say, dbx is not fixed, but fixing that properly probably requires more work than it's worth. /Magnus Bug:

RFR [XS] - 8139026 hotspot.script cannot handle command-line arguments with spaces

2015-10-25 Thread Ioi Lam
Please review a very small fix: http://cr.openjdk.java.net/~iklam/8139026-hotspot-script-arg-quoating/ Bug: hotspot/make/hotspot.script cannot handle command-line arguments with spaces https://bugs.openjdk.java.net/browse/JDK-8139026 Summary of fix: The old script was adding $@ to a