Re: What to pass to --with-custom-make-dir?

2017-03-07 Thread Christian Thalinger
> On Mar 6, 2017, at 10:17 PM, Erik Joelsson wrote: > > > > On 2017-03-07 03:22, David Holmes wrote: >> On 7/03/2017 6:32 AM, Christian Thalinger wrote: >>> On Mar 6, 2017, at 8:51 AM, Christian Thalinger wrote: >

Re: What to pass to --with-custom-make-dir?

2017-03-07 Thread Erik Joelsson
On 2017-03-07 03:22, David Holmes wrote: On 7/03/2017 6:32 AM, Christian Thalinger wrote: On Mar 6, 2017, at 8:51 AM, Christian Thalinger wrote: On Mar 3, 2017, at 4:09 PM, David Holmes wrote: Hi Christian, I think you need to pass

Re: What to pass to --with-custom-make-dir?

2017-03-06 Thread David Holmes
On 7/03/2017 6:32 AM, Christian Thalinger wrote: On Mar 6, 2017, at 8:51 AM, Christian Thalinger wrote: On Mar 3, 2017, at 4:09 PM, David Holmes wrote: Hi Christian, I think you need to pass an absolute directory, in which all the custom

Re: What to pass to --with-custom-make-dir?

2017-03-06 Thread Christian Thalinger
> On Mar 6, 2017, at 8:51 AM, Christian Thalinger > wrote: > > >> On Mar 3, 2017, at 4:09 PM, David Holmes wrote: >> >> Hi Christian, >> >> I think you need to pass an absolute directory, in which all the custom >> files, regardless of

Re: What to pass to --with-custom-make-dir?

2017-03-06 Thread Christian Thalinger
> On Mar 3, 2017, at 4:09 PM, David Holmes wrote: > > Hi Christian, > > I think you need to pass an absolute directory, in which all the custom > files, regardless of repo, are located. That is essentially how we use it - > jdk/make/closed has files included from

Re: What to pass to --with-custom-make-dir?

2017-03-03 Thread David Holmes
Hi Christian, I think you need to pass an absolute directory, in which all the custom files, regardless of repo, are located. That is essentially how we use it - jdk/make/closed has files included from other repos. Of course that only works if names are unique. David On 4/03/2017 9:11 AM,

Re: What to pass to --with-custom-make-dir?

2017-03-03 Thread Rob McKenna
Hi Christian, I'm cc'ing build-dev (and bcc'ing jdk8u-dev) as that may be a more appropriate venue for this discussion. -Rob On 03/03/17 10:19, Christian Thalinger wrote: > At Twitter we are using the custom extension mechanism to separate our > additional code from upstream in order to