[jdk21] Integrated: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023

2023-08-07 Thread Jesper Wilhelmsson
On Mon, 7 Aug 2023 23:11:27 GMT, Jesper Wilhelmsson wrote: > JDK-8312985: Remove EA from the JDK 21 version string with first RC promotion > on August 10, 2023 This pull request has now been integrated. Changeset: bfe037a4 Author:Jesper Wilhelmsson URL:

Re: [jdk21] RFR: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023

2023-08-07 Thread Mikael Vidstedt
On Mon, 7 Aug 2023 23:11:27 GMT, Jesper Wilhelmsson wrote: > JDK-8312985: Remove EA from the JDK 21 version string with first RC promotion > on August 10, 2023 Marked as reviewed by mikael (Reviewer). - PR Review:

[jdk21] RFR: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023

2023-08-07 Thread Jesper Wilhelmsson
JDK-8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023 - Commit messages: - Removed EA Changes: https://git.openjdk.org/jdk21/pull/165/files Webrev: https://webrevs.openjdk.org/?repo=jdk21=165=00 Issue:

Integrated: 8313167: Update to use jtreg 7.3

2023-08-07 Thread Christian Stein
On Wed, 26 Jul 2023 09:06:19 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: 8313167: Update to use jtreg 7.3

2023-08-07 Thread Iris Clark
On Wed, 26 Jul 2023 09:06:19 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: 8313167: Update to use jtreg 7.3

2023-08-07 Thread Jonathan Gibbons
On Wed, 26 Jul 2023 09:06:19 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: JDK-8313244: NM flags handling in configure process [v2]

2023-08-07 Thread Christoph Langer
On Fri, 4 Aug 2023 14:42:37 GMT, Andreas Steiner wrote: > > make/common/NativeCompilation.gmk uses NM too, is there a reason to avoid > > the flag there? flags-other.m4 : the comment 'on AIX ...' is just stating > > the obvious; maybe it should better mention that without -X64 we only > >

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v3]

2023-08-07 Thread Robbin Ehn
> Hi please consider. > > This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. > (tested x64 and some RV) > > There are 4 changes in binutils we work around. > - zstd compressed debug sections > - libsframe added > - init_disassemble_info() change > - libbfd.a is only

Integrated: 8313701: GHA: RISC-V should use the official repository for bootstrap

2023-08-07 Thread Aleksey Shipilev
On Fri, 4 Aug 2023 09:18:11 GMT, Aleksey Shipilev wrote: > RISC-V is now the [official Debian > architecture](https://lists.debian.org/debian-riscv/2023/07/msg00053.html). > This means that the official repository is slowly building up the package > set, while the old debian-ports repo is

Re: RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap [v2]

2023-08-07 Thread Aleksey Shipilev
On Mon, 7 Aug 2023 07:34:59 GMT, Aleksey Shipilev wrote: >> RISC-V is now the [official Debian >> architecture](https://lists.debian.org/debian-riscv/2023/07/msg00053.html). >> This means that the official repository is slowly building up the package >> set, while the old debian-ports repo is

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Kim Barrett
On Mon, 7 Aug 2023 08:00:12 GMT, David Holmes wrote: >> Hi David, this throw was removed for this method's declaration in the >> corresponding hpp file in an earlier commit [8305590: Remove nothrow >> exception specifications from operator >>

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
On Tue, 1 Aug 2023 08:19:06 GMT, Julian Waters wrote: >> src/hotspot/os/windows/symbolengine.cpp line 114: >> >>> 112: _capacity = (int)(sizeof(_fallback_buffer) / sizeof(T)); >>> 113: } >>> 114: _p[0] = (T) '\0'; >> >> I find this use of `'\0'` quite suspicious in itself, but it

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread David Holmes
On Tue, 1 Aug 2023 08:16:41 GMT, Julian Waters wrote: >> src/hotspot/share/memory/allocation.cpp line 114: >> >>> 112: // >>> 113: >>> 114: void* AnyObj::operator new(size_t size, Arena *arena) { >> >> Please remind us what the issue is with `throw()` as this is a change to >> shared code

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread David Holmes
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8313701: GHA: RISC-V should use the official repository for bootstrap [v2]

2023-08-07 Thread Aleksey Shipilev
> RISC-V is now the [official Debian > architecture](https://lists.debian.org/debian-riscv/2023/07/msg00053.html). > This means that the official repository is slowly building up the package > set, while the old debian-ports repo is [slowly >

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
On Tue, 1 Aug 2023 08:10:10 GMT, David Holmes wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 22 additional >> commits

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread David Holmes
On Mon, 7 Aug 2023 06:37:21 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-07 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done > with some effort, given that the significantly stricter gcc can now compile > an experimental

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler

2023-08-07 Thread Julian Waters
On Tue, 1 Aug 2023 01:52:24 GMT, Julian Waters wrote: > We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done > with some effort, given that the