Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Iris Clark
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

RFR: 8314483: Optionally override copyright header in generated source

2023-08-18 Thread Erik Joelsson
In the JDK build we have various build tools that generate source code from data files. For most of these tools, the source files are based on template files, which already have copyright headers, but for some, the complete source file is generated by the tool, which is providing the copyright

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Erik Joelsson
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

Re: RFR: 8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option

2023-08-18 Thread Erik Joelsson
On Fri, 18 Aug 2023 05:57:34 GMT, Vladimir Petko wrote: > 8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15340#pullrequestreview-1584454782

Integrated: 8314265: Fix -Wconversion warnings in miscellaneous runtime code

2023-08-18 Thread Coleen Phillimore
On Thu, 10 Aug 2023 20:31:20 GMT, Coleen Phillimore wrote: > Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion > warnings in runtime code. This is the last one I'm going to do for runtime > for a while. > Tested with tier1-4. This pull request has now been integrated.

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v6]

2023-08-18 Thread Coleen Phillimore
On Fri, 18 Aug 2023 02:13:57 GMT, David Holmes wrote: >> template bool primitive_equals(const K& k0, const K& k1) { >> return k0 == k1; >> } >> >> template int primitive_compare(const K& k0, const K& k1) { >> return ((k0 < k1) ? -1 : (k0 == k1) ? 0 : 1); >> } >> >> >> This is the

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v8]

2023-08-18 Thread Coleen Phillimore
On Thu, 17 Aug 2023 12:37:03 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the

Re: RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread David Holmes
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the

RFR: 8314495: Update to use jtreg 7.3.1

2023-08-18 Thread Christian Stein
Please review the change to update to using jtreg 7.3,1. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. This change

Integrated: 8314543: gitattributes: make diffs easier to read

2023-08-18 Thread Andrei Rybak
On Thu, 17 Aug 2023 17:25:52 GMT, Andrei Rybak wrote: > Git supports special hunk headers for several languages in diff output, which > make it easier to read diffs of files in that language, generated by Git > (git-diff, git-show, `git log -p`, etc). For details, see `git help >

Re: RFR: 8314543: gitattributes: make diffs easier to read

2023-08-18 Thread Koichi Sakata
On Thu, 17 Aug 2023 17:25:52 GMT, Andrei Rybak wrote: > Git supports special hunk headers for several languages in diff output, which > make it easier to read diffs of files in that language, generated by Git > (git-diff, git-show, `git log -p`, etc). For details, see `git help >

Re: RFR: 8314488: Compile the JDK as C++17

2023-08-18 Thread David Holmes
On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters wrote: > Implementation of [JEP draft: Compile the JDK as > C++17](https://bugs.openjdk.org/browse/JDK-8310260) Hi Julian, Given the JEP was closed/rejected as being unnecessary it didn't really make sense to present this as an Implementation

Re: RFR: 8314488: Compile the JDK as C++17

2023-08-18 Thread Julian Waters
On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters wrote: > Implementation of [JEP draft: Compile the JDK as > C++17](https://bugs.openjdk.org/browse/JDK-8310260) Hi Andrew, majority of the work to remove C++17 breaking code from the JDK is actually already complete, this PR cleans out the last

RFR: 8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option

2023-08-18 Thread Vladimir Petko
8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option - Commit messages: - 8314554: Debian/Ubuntu should not link OpenJDK with --as-needed link option Changes: https://git.openjdk.org/jdk/pull/15340/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15340=00