Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer

2023-10-20 Thread Erik Joelsson
On Fri, 20 Oct 2023 19:18:47 GMT, Matthew Donovan wrote: > Hello, > > In this PR I removed NSS tests from the ProblemList and updated NssTest to > use Sqlite databases. I also removed code in PKCS11Test.java that falls back > to NSS libraries installed on the test system. The tests can still

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Mark Reinhold
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer

2023-10-20 Thread Matthew Donovan
Hello, In this PR I removed NSS tests from the ProblemList and updated NssTest to use Sqlite databases. I also removed code in PKCS11Test.java that falls back to NSS libraries installed on the test system. The tests can still be run with different NSS libraries but they have to be specified by

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Jonathan Gibbons
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Vladimir Kozlov
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

RFR: 8317937: @sealedGraph: Links to inner classes fails in links

2023-10-20 Thread Chen Liang
This fixes the links to nested classes like `ValueLayout.OfLong` in the rendered sealed class hierarchy graph. A similar problem with nested classes exist for `@sealedGraph` on them, where their graphs will be generated to a wrong directory and the graph link broken, as seen in

Re: RFR: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039

2023-10-20 Thread Erik Joelsson
On Fri, 20 Oct 2023 14:25:30 GMT, Magnus Ihse Bursie wrote: > Unfortunately, [JDK-8317039](https://bugs.openjdk.org/browse/JDK-8317039) > caused a regression. The `$(JAVA)` variable did not just contain a path, > which was assumed by the patch, but also the necessary flags in >

Re: RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v3]

2023-10-20 Thread Frederic Thevenet
On Fri, 20 Oct 2023 13:46:35 GMT, Magnus Ihse Bursie wrote: >> Indeed, I see no reason to rush the integration for this before we've >> resolved the failing test. >> >> I can confirm that outside of the context of GHA, the `test-prebuilt` target >> does not properly resolve _relative_ paths

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Alan Bateman
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

2023-10-20 Thread Mark Reinhold
On Fri, 20 Oct 2023 15:32:55 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

2023-10-20 Thread Doug Simon
On Fri, 20 Oct 2023 15:32:55 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work,

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Doug Simon
> The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this requires a JDK change. The > core of the issue is

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v2]

2023-10-20 Thread Doug Simon
> The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this requires a JDK change. The > core of the issue is

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Vladimir Kozlov
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Doug Simon
On Fri, 20 Oct 2023 14:27:43 GMT, Vladimir Kozlov wrote: > Why you replaced pair of copyright years with one year in module-info.Java > files? Instead of updating last year only. Why also update 'since' there? > Even if you changed location these files existed already. The files may be

RFR: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039

2023-10-20 Thread Magnus Ihse Bursie
Unfortunately, [JDK-8317039](https://bugs.openjdk.org/browse/JDK-8317039) caused a regression. The `$(JAVA)` variable did not just contain a path, which was assumed by the patch, but also the necessary flags in `$(JAVA_FLAGS)`. Furthermore, the original implementation deviated from how we

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Vladimir Kozlov
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v3]

2023-10-20 Thread Magnus Ihse Bursie
On Wed, 11 Oct 2023 10:00:14 GMT, Frederic Thevenet wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added a test to verify that symbols are available > > Indeed, I see no reason to rush the integration for

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Magnus Ihse Bursie
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Erik Joelsson
On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon wrote: > The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this

RFR: 8318027: Support alternative name to jdk.internal.vm.compiler

2023-10-20 Thread Doug Simon
The Graal code base has [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) its module to `jdk.compiler.graal` as part of preparations for Project Galahad. Due to the way Java modules work, this requires a JDK change. The core of the issue is that the

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-10-20 Thread Magnus Ihse Bursie
On Thu, 19 Oct 2023 13:49:21 GMT, Robbin Ehn wrote: >> Hi please consider. >> >> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. >> (tested x64 and some RV) >> >> There are 4 changes in binutils we work around. >> - zstd compressed debug sections >> - libsframe

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-10-20 Thread Robbin Ehn
On Thu, 19 Oct 2023 13:49:21 GMT, Robbin Ehn wrote: >> Hi please consider. >> >> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. >> (tested x64 and some RV) >> >> There are 4 changes in binutils we work around. >> - zstd compressed debug sections >> - libsframe

Integrated: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-10-20 Thread Afshin Zafari
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.vm.runtime.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written

Re: RFR: 8308753: Class-File API transition to Preview [v22]

2023-10-20 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-10-20 Thread Daniel Jeliński
On Thu, 19 Oct 2023 13:49:21 GMT, Robbin Ehn wrote: >> Hi please consider. >> >> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. >> (tested x64 and some RV) >> >> There are 4 changes in binutils we work around. >> - zstd compressed debug sections >> - libsframe

Re: RFR: 8318540: make test cannot run .jasm tests directly

2023-10-20 Thread Aleksey Shipilev
On Thu, 19 Oct 2023 17:08:20 GMT, Aleksey Shipilev wrote: > Simple fix to allow running `.jasm` tests directly, like we can do now with > `.java` and `.sh` tests. > > Before the fix: > > > % make images test TEST=runtime/clone/LocalClone.jasm > Test selection 'runtime/clone/LocalClone.jasm',

Integrated: 8318540: make test cannot run .jasm tests directly

2023-10-20 Thread Aleksey Shipilev
On Thu, 19 Oct 2023 17:08:20 GMT, Aleksey Shipilev wrote: > Simple fix to allow running `.jasm` tests directly, like we can do now with > `.java` and `.sh` tests. > > Before the fix: > > > % make images test TEST=runtime/clone/LocalClone.jasm > Test selection 'runtime/clone/LocalClone.jasm',

Re: RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

2023-10-20 Thread Daniel Jeliński
On Thu, 19 Oct 2023 13:49:21 GMT, Robbin Ehn wrote: >> Hi please consider. >> >> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. >> (tested x64 and some RV) >> >> There are 4 changes in binutils we work around. >> - zstd compressed debug sections >> - libsframe