On Fri, 27 Oct 2023 10:05:39 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement review feedback.
>
> doc/testing.md line 141:
>
>> 139: Roughly speaking, a failure of a test in this tier
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote:
> Increase javacserver connection timeout values and max retry attempts for
> better make stability on some slower machines.
make/langtools/tools/javacserver/client/Client.java line 57:
> 55: private static final int
This is due you using a newer compiler than the "official" one used by
OpenJDK for JDK21
We will have a fix to silence it for JDK 22, but that won't help your
JDK 21 build.
You'll need to use Xcode 12.x instead of whatever you are using.
-phil.
On 10/24/23 9:57 AM, Asif Ikram wrote:
Dear
On Thu, 26 Oct 2023 17:53:12 GMT, Jonathan Gibbons wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`),
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply adding logic to look
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply adding logic to look
On Thu, 26 Oct 2023 15:41:35 GMT, Thomas Stuefe wrote:
> This looks good to me.
>
> One suggestion: to reduce code duplication and to make the code a bit safer
> against accidental returns prior to fesetenv, I would have used a mark object
> like this:
Thanks. I take your point, but I think
On Fri, 27 Oct 2023 11:49:16 GMT, Andrew Haley wrote:
> > One more thought, it would be good to add the FTZ_mode_enabled check to
> > `os::run_periodic_checks()`.
> > We already do signal handler checks there, and it is the right place to
> > check for "global things third party native code
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply adding logic to look
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
>
On Thu, 26 Oct 2023 17:42:39 GMT, Vladimir Ivanov wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove accidental include
>
> make/test/JtregNativeHotspot.gmk line 854:
>
>> 852:
On Thu, 26 Oct 2023 15:59:08 GMT, Thomas Stuefe wrote:
> One more thought, it would be good to add the FTZ_mode_enabled check to
> `os::run_periodic_checks()`.
>
> We already do signal handler checks there, and it is the right place to check
> for "global things third party native code may
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote:
> Increase javacserver connection timeout values and max retry attempts for
> better make stability on some slower machines.
Looks good to me, these changes seem to have improved nightbuilds at SAP. But
somebody from build group should
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
>
Increase javacserver connection timeout values and max retry attempts for
better make stability on some slower machines.
-
Commit messages:
- JDK-8318961
Changes: https://git.openjdk.org/jdk/pull/16397/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16397=00
Issue:
On Thu, 26 Oct 2023 19:38:55 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply adding logic to look
On Thu, 26 Oct 2023 19:38:55 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 26 Oct 2023 19:38:55 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad wrote:
> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on
> some Linux distributions (e.g. Fedora, Oracle Linux),
> `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
>
> This PR suggest simply adding logic to look
20 matches
Mail list logo
