On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 20:13:06 GMT, Magnus Ihse Bursie wrote:
> Not having a build time dependency on libsleef means you cannot really verify
> that the functions you want to call are correct, but maybe you feel secure
> that they will never change?
I'm not sure. The main reason that we add
On Thu, 30 Nov 2023 11:13:14 GMT, Andrew Haley wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename vmath to sleef in configure
>
> make/autoconf/lib-sleef.m4 line 56:
>
>> 54: AC_MSG_CHECKING([for the
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update symbol files to JDK 22 b26.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16505/files
- new:
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains eight commits:
>
> - Merge branch 'master' into JDK-8319413
> -
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains eight commits:
- Merge branch 'master' into JDK-8319413
- Merge branch 'master' into JDK-8319413
- Add symbol files for JDK
On Thu, 30 Nov 2023 20:07:19 GMT, Magnus Ihse Bursie wrote:
> But you are saying that you want to skip building this library unless you
> have a gcc version that supports c++17?
>
Yes, the request is to skip building the simdsort library if GCC version is < 8
as only GCC >= 8 supports C++17
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 14:50:24 GMT, Andrew Haley wrote:
>> Do this, but with the name vect_math.S. Don't use SLEEF headers in the
>> build. I think you can do this with no build-time dependency on SLEEF at all
>> if you load the library lazily at runtime.
>>
>>
On Thu, 30 Nov 2023 18:19:51 GMT, Srinivas Vamsi Parasa
wrote:
>> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
>> just CXXFLAGS?
>>
>> Also @vamsi-parasa, did you check into if this really was needed and why? To
>> be clear, I basically consider this an
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa,
On Thu, 30 Nov 2023 10:04:49 GMT, Jaikiran Pai wrote:
> @RealCLanger Hello Christoph, in https://bugs.openjdk.org/browse/JDK-8320863
> you noted that you ran into a build issue with Xcode version 13.1. Would you
> be able to test this current proposed patch in this PR against that setup
>
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x
On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing
>> in .cpp files for some reason.
>
> Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not
> just CXXFLAGS?
>
> Also @vamsi-parasa,
On Thu, 30 Nov 2023 11:46:58 GMT, Andrew Haley wrote:
> [vect_math.S.txt](https://github.com/openjdk/jdk/files/13512306/vect_math.S.txt)
I guess this will live only in os_linux and os_bsd because the Windows compiler
won't like it AFAIK.
-
PR Comment:
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 30 Nov 2023 09:35:04 GMT, Magnus Ihse Bursie wrote:
> This version looks much better, thank you! I guess cflags/SVE_CFLAGS is an
> okay-ish solution.
>
> I'm still not 100% happy though, but it might be due to my limited
> understanding. Let me write down a few numbered statements and
On Tue, 28 Nov 2023 18:15:56 GMT, Aleksey Shipilev wrote:
> In current GHA, `hotspot_compiler` testing takes a long time, and often takes
> the longest. On MacOS and Windows it routinely takes 60..80 minutes, while
> other test groups run in 30..40 minutes. This often drags the total wall
>
On Tue, 28 Nov 2023 18:15:56 GMT, Aleksey Shipilev wrote:
> In current GHA, `hotspot_compiler` testing takes a long time, and often takes
> the longest. On MacOS and Windows it routinely takes 60..80 minutes, while
> other test groups run in 30..40 minutes. This often drags the total wall
>
On Tue, 28 Nov 2023 18:15:56 GMT, Aleksey Shipilev wrote:
> In current GHA, `hotspot_compiler` testing takes a long time, and often takes
> the longest. On MacOS and Windows it routinely takes 60..80 minutes, while
> other test groups run in 30..40 minutes. This often drags the total wall
>
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Thu, 16 Nov 2023 07:04:52 GMT, David Holmes wrote:
>> Hi Magnus, the new x86-simd-sort 4.0 needs C++17 to compile. Will look into
>> the changes needed for this library to compile without the C++17 standard
>> and get back to you.
>>
>> Thanks,
>> Vamsi
>
> Seems a bit odd to me too as the
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
> Can I please get a review of this change will attempts to workaround an issue
> in dsymutil?
>
> The previous attempt to use `--reproducer Off` has shown that it fails to
> build on some other Xcode versions other than 14.3.1. Users have reported it
> to fail on Xcode 15.0.1 and Xcode from
On Thu, 30 Nov 2023 06:39:43 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Wed, 22 Nov 2023 09:05:31 GMT, Andrew Haley wrote:
>>> Have you considered the possibility of copying the sleef source to the
>>> OpenJDK repository and thereby it becomes part of the build process? I
>>> don't know how straightforward that is technically and IANAL but I think
>>> it's
32 matches
Mail list logo
