Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Magnus Ihse Bursie
On Fri, 8 Dec 2023 17:08:33 GMT, Daniel Jeliński wrote: > >And, oh, I must say that I think "clcl" as name for the toolchain is > > really bad. :-( > > It was not my first choice. I tried clang-cl first; the scripts didn't like > the dash. Then I tried clangcl, and some of the changes

Integrated: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays)

2023-12-08 Thread Srinivas Vamsi Parasa
On Tue, 7 Nov 2023 00:12:41 GMT, Srinivas Vamsi Parasa wrote: > The goal is to develop faster sort routines for x86_64 CPUs by taking > advantage of AVX2 instructions. This enhancement provides an order of > magnitude speedup for Arrays.sort() using int, long, float and double arrays. > > For

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v12]

2023-12-08 Thread Srinivas Vamsi Parasa
On Fri, 8 Dec 2023 22:37:26 GMT, Vladimir Kozlov wrote: > I pushed closed changes. Thanks Vladimir! - PR Comment: https://git.openjdk.org/jdk/pull/16534#issuecomment-1847939767

Re: RFR: JDK-8321621: Update JCov version to 3.0.16

2023-12-08 Thread Erik Joelsson
On Fri, 8 Dec 2023 22:42:42 GMT, Alexandre Iline wrote: > JCov support for byte code version 67. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17041#pullrequestreview-1773267176

RFR: JDK-8321621: Update JCov version to 3.0.16

2023-12-08 Thread Alexandre Iline
JCov support for byte code version 67. - Commit messages: - JDK-8321621: Update JCov version to 3.0.16 Changes: https://git.openjdk.org/jdk/pull/17041/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17041=00 Issue: https://bugs.openjdk.org/browse/JDK-8321621 Stats: 1 line

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v12]

2023-12-08 Thread Vladimir Kozlov
On Wed, 6 Dec 2023 23:12:13 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX2 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: Cross compilation discussion

2023-12-08 Thread erik . joelsson
On 12/8/23 08:29, Magnus Ihse Bursie wrote: OK. So you are doing what I'd usually call cross compiling, sort of, but you don't want to treat it as a cross-compiled build. It's an unusual case, in that it is cross compiled, but it is also expected to be able to run on the build system.

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Daniel Jeliński
On Fri, 8 Dec 2023 15:56:40 GMT, Magnus Ihse Bursie wrote: > Do I understand you correctly that clang-cl uses "mostly" the same arguments > as cl, but uses the clang warnings system, e.g. -Wno-foo-loops instead of > C1234? That's correct. Clang-cl only supports the following cl warning

Re: Cross compilation discussion

2023-12-08 Thread Magnus Ihse Bursie
OK. So you are doing what I'd usually call cross compiling, sort of, but you don't want to treat it as a cross-compiled build. It's an unusual case, in that it is cross compiled, but it is also expected to be able to run on the build system. The main reason for the build to know if we're

Re: RFR: 8316657: Support whitebox testing in microbenchmarks

2023-12-08 Thread Magnus Ihse Bursie
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote: > The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has > recently arisen. Alternatively, I could also unpack wb.jar alongside `$(JMH_CORE_JAR) $(JMH_COMMONS_MATH_JAR) $(JMH_JOPT_SIMPLE_JAR)`, and re-pack it into

Re: RFR: 8316657: Support whitebox testing in microbenchmarks

2023-12-08 Thread Magnus Ihse Bursie
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote: > The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has > recently arisen. make/RunTests.gmk line 598: > 596: endif > 597: > 598: # Set paths for dependencies @cl4es So basically this is the line you're

Re: RFR: 8321557: Move SOURCE line verification for OracleJDK out of OpenJDK

2023-12-08 Thread Magnus Ihse Bursie
On Thu, 7 Dec 2023 23:29:48 GMT, Erik Joelsson wrote: > The main goal of this patch is to remove the OracleJDK specific verification > of the SOURCE field in the release file from the OpenJDK test. While at it, I > decided to do some cleanup as well to make the code a bit more modern and >

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Magnus Ihse Bursie
On Thu, 7 Dec 2023 15:52:46 GMT, Daniel Jeliński wrote: > I'd like to propose a new toolchain for Windows using the clang-cl compiler > frontend. > > Clang-cl is available as an optional feature in all Visual Studio editions, > including the free-for-OSS-development community edition. > >

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Magnus Ihse Bursie
On Thu, 7 Dec 2023 15:52:46 GMT, Daniel Jeliński wrote: > I'd like to propose a new toolchain for Windows using the clang-cl compiler > frontend. > > Clang-cl is available as an optional feature in all Visual Studio editions, > including the free-for-OSS-development community edition. > >

Integrated: 8321597: Use .template consistently for files treated as templates by the build

2023-12-08 Thread Magnus Ihse Bursie
On Fri, 8 Dec 2023 14:43:29 GMT, Magnus Ihse Bursie wrote: > Some files are used as "templates" in the build, that is, they are almost, > but not fully, in the intended state. Instead, they have some pattern markers > that need to be replaced with actual content as part of the build. > > As a

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v8]

2023-12-08 Thread Evgeny Astigeevich
On Thu, 24 Jun 2021 17:02:03 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to

Re: RFR: 8321597: Use .template consistently for files treated as templates by the build

2023-12-08 Thread Erik Joelsson
On Fri, 8 Dec 2023 14:43:29 GMT, Magnus Ihse Bursie wrote: > Some files are used as "templates" in the build, that is, they are almost, > but not fully, in the intended state. Instead, they have some pattern markers > that need to be replaced with actual content as part of the build. > > As a

RFR: 8321597: Use .template consistently for files treated as templates by the build

2023-12-08 Thread Magnus Ihse Bursie
Some files are used as "templates" in the build, that is, they are almost, but not fully, in the intended state. Instead, they have some pattern markers that need to be replaced with actual content as part of the build. As a convention, most such files are named as `.template`, e.g.

Re: RFR: 8316657: Support whitebox testing in microbenchmarks

2023-12-08 Thread Claes Redestad
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote: > The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has > recently arisen. Adding wb.jar to the test image is great. Maybe that could be done separately? I think we need a different solution here that does not pollute

Re: RFR: 8316657: Support whitebox testing in microbenchmarks

2023-12-08 Thread Erik Joelsson
On Wed, 6 Dec 2023 15:32:14 GMT, Magnus Ihse Bursie wrote: > The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has > recently arisen. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16996#pullrequestreview-1772448490

Re: RFR: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

2023-12-08 Thread Frederic Thevenet
On Fri, 8 Dec 2023 10:48:51 GMT, Magnus Ihse Bursie wrote: >> When building OpenJDK on the Windows platform, version information are >> embedded as compiled resources into every native library and executable, >> which typically contain version numbers, copyright information, product name >>

Integrated: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

2023-12-08 Thread Frederic Thevenet
On Tue, 5 Dec 2023 11:15:18 GMT, Frederic Thevenet wrote: > When building OpenJDK on the Windows platform, version information are > embedded as compiled resources into every native library and executable, > which typically contain version numbers, copyright information, product name > and

Re: RFR: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

2023-12-08 Thread Frederic Thevenet
On Wed, 6 Dec 2023 18:30:58 GMT, Erik Joelsson wrote: >> When building OpenJDK on the Windows platform, version information are >> embedded as compiled resources into every native library and executable, >> which typically contain version numbers, copyright information, product name >> and

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v3]

2023-12-08 Thread Alan Bateman
On Fri, 8 Dec 2023 11:54:40 GMT, Serguei Spitsyn wrote: >> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 >> time frame. >> It is fixing a deadlock issue between `VirtualThread` class critical >> sections with the `interruptLock` (in methods: `unpark()`,

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Daniel Jeliński
On Thu, 7 Dec 2023 15:52:46 GMT, Daniel Jeliński wrote: > I'd like to propose a new toolchain for Windows using the clang-cl compiler > frontend. > > Clang-cl is available as an optional feature in all Visual Studio editions, > including the free-for-OSS-development community edition. > >

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v3]

2023-12-08 Thread Serguei Spitsyn
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 > time frame. > It is fixing a deadlock issue between `VirtualThread` class critical sections > with the `interruptLock` (in methods: `unpark()`, `interrupt()`, > `getAndClearInterrupt()`, `threadState()`,

Re: RFR: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll

2023-12-08 Thread Magnus Ihse Bursie
On Tue, 5 Dec 2023 11:15:18 GMT, Frederic Thevenet wrote: > When building OpenJDK on the Windows platform, version information are > embedded as compiled resources into every native library and executable, > which typically contain version numbers, copyright information, product name > and

RFR: 8316657: Support whitebox testing in microbenchmarks

2023-12-08 Thread Magnus Ihse Bursie
The need to use whitebox-testing (wb.jar) from JMH microbenchmarks has recently arisen. - Commit messages: - 8316657: Support whitebox testing in microbenchmarks Changes: https://git.openjdk.org/jdk/pull/16996/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16996=00 Issue:

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Julian Waters
On Fri, 8 Dec 2023 09:46:59 GMT, Daniel Jeliński wrote: > > Is it possible to fold clang-cl into the microsoft toolchain instead, and > > just pass clang-cl as the compiler instead of cl? > > I suppose it's possible; clang-cl output is supposed to be compatible with > link & lib, and most

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Daniel Jeliński
On Fri, 8 Dec 2023 08:00:45 GMT, Julian Waters wrote: > Is it possible to fold clang-cl into the microsoft toolchain instead, and > just pass clang-cl as the compiler instead of cl? I suppose it's possible; clang-cl output is supposed to be compatible with link & lib, and most command line

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Daniel Jeliński
On Thu, 7 Dec 2023 15:52:46 GMT, Daniel Jeliński wrote: > I'd like to propose a new toolchain for Windows using the clang-cl compiler > frontend. > > Clang-cl is available as an optional feature in all Visual Studio editions, > including the free-for-OSS-development community edition. > >

Re: RFR: 8321533: Clang build for Windows

2023-12-08 Thread Julian Waters
On Thu, 7 Dec 2023 15:52:46 GMT, Daniel Jeliński wrote: > I'd like to propose a new toolchain for Windows using the clang-cl compiler > frontend. > > Clang-cl is available as an optional feature in all Visual Studio editions, > including the free-for-OSS-development community edition. > >