Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v3]

2024-05-28 Thread Matias Saavedra Silva
On Sat, 25 May 2024 06:48:26 GMT, Ioi Lam wrote: >> ### Overview >> >> This PR archives `CONSTANT_FieldRef` entries in the _resolved_ state when >> it's safe to do so. >> >> I.e., when a `CONSTANT_FieldRef` constant pool entry in class `A` refers to >> a *non-static* field `B.F`, >> - `B`

Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v2]

2024-05-23 Thread Matias Saavedra Silva
On Thu, 23 May 2024 03:35:19 GMT, Ioi Lam wrote: >> ### Overview >> >> This PR archives `CONSTANT_FieldRef` entries in the _resolved_ state when >> it's safe to do so. >> >> I.e., when a `CONSTANT_FieldRef` constant pool entry in class `A` refers to >> a *non-static* field `B.F`, >> - `B`

Integrated: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry

2023-08-04 Thread Matias Saavedra Silva
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva wrote: > The recent change in > [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more > -Wconversion warnings that are addressed in this patch. The aforementioned > change has overlooked inconsistencies wi

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Matias Saavedra Silva
On Fri, 4 Aug 2023 17:29:36 GMT, Coleen Phillimore wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed field namnes to resolve error > > This looks good. Thank you f

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Matias Saavedra Silva
in()`. Verified with tier 1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Changed field namnes to resolve error - Changes: - all: https://git.openjdk.org/jdk/pull/15126/files - new: https://git.

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v3]

2023-08-04 Thread Matias Saavedra Silva
in()`. Verified with tier 1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Added asserts for flags - Changes: - all: https://git.openjdk.org/jdk/pull/15126/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v2]

2023-08-03 Thread Matias Saavedra Silva
in()`. Verified with tier 1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Change to checked_cast - Changes: - all: https://git.openjdk.org/jdk/pull/15126/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry

2023-08-03 Thread Matias Saavedra Silva
On Thu, 3 Aug 2023 11:48:43 GMT, Coleen Phillimore wrote: >> src/hotspot/share/oops/resolvedFieldEntry.hpp line 106: >> >>> 104: void set_flags(bool is_final, bool is_volatile) { >>> 105: int new_flags = (is_final << is_final_shift) | >>> static_cast(is_volatile); >>> 106: _flags =

RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry

2023-08-02 Thread Matias Saavedra Silva
The recent change in [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more -Wconversion warnings that are addressed in this patch. The aforementioned change has overlooked inconsistencies with the types used by `ResolvedFieldEntry` and the method `fill_in()`. Verified with tier

Integrated: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-19 Thread Matias Saavedra Silva
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva wrote: > This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previou

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v11]

2023-01-19 Thread Matias Saavedra Silva
On Thu, 19 Jan 2023 20:10:23 GMT, Matias Saavedra Silva wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as t

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v11]

2023-01-19 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional c

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v10]

2023-01-18 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additi

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v9]

2023-01-13 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v8]

2023-01-12 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit si

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v7]

2023-01-12 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additi

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v6]

2023-01-11 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commi

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v5]

2023-01-06 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional com

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v4]

2023-01-06 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v2]

2023-01-06 Thread Matias Saavedra Silva
On Thu, 5 Jan 2023 22:47:32 GMT, Matias Saavedra Silva wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as the >

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v3]

2023-01-06 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit s

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v2]

2023-01-05 Thread Matias Saavedra Silva
not able to find the previous releases revert to the existing logic > in TestAutoCreateSharedArchiveUpgrade.java (use the test.boot.jdk or > test.previous.jdk properties). Verified with tier1-4 tests. Matias Saavedra Silva has updated the pull request with a new target base due to

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-05 Thread Matias Saavedra Silva
On Thu, 5 Jan 2023 19:48:43 GMT, Erik Joelsson wrote: >> bin/jib.sh line 197: >> >>> 195: export REAL_CONFIGURE_COMMAND_EXEC_SHORT="$myname" >>> 196: >>> 197: ${installed_jib_script} "$@" >> >> Don't we need this? > > I just now noticed this file was deleted, that's not ok. Sorry about that,

RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-04 Thread Matias Saavedra Silva
This is an enhancement of the test case in [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests against an archive created by the "boot JDK", which is usually set as the previous official JDK release when building the JDK repo. If it's able to connect to an artifactory that

Integrated: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19

2022-11-28 Thread Matias Saavedra Silva
On Mon, 14 Nov 2022 21:33:23 GMT, Matias Saavedra Silva wrote: > The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, > this flag doesn't work across JDK 19 and 20. > > Expected: JDK 20 should recreate the specified CDS archive > Actual: JDK 20 c

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v7]

2022-11-22 Thread Matias Saavedra Silva
t; The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified > with tier 1-4 tests. Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge branch 'master' into autoCreateSharedArchive_8296754

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v6]

2022-11-22 Thread Matias Saavedra Silva
t; The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified > with tier 1-4 tests. Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contai

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v5]

2022-11-22 Thread Matias Saavedra Silva
On Thu, 17 Nov 2022 21:46:45 GMT, Matias Saavedra Silva wrote: >> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, >> this flag doesn't work across JDK 19 and 20. >> >> Expected: JDK 20 should recreate the specified CDS archive >> A

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v5]

2022-11-17 Thread Matias Saavedra Silva
t; The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified > with tier 1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Added newline to end of test - Changes: - all: https://git.openjdk.org/jdk/

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v4]

2022-11-17 Thread Matias Saavedra Silva
t; The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified > with tier 1-4 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Removed unused import - Changes: - all: https://git.openjdk.org/jdk/pull/11