On Fri, 30 Jun 2023 09:57:04 GMT, Matthias Baesken wrote:
> Hi Alan, I adjusted the comment in DriverManager.java .
Thanks, the update looks okay.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1257728322
On Wed, 5 Jul 2023 15:07:15 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comment
-
Changes:
- all:
On Thu, 22 Jun 2023 09:23:05 GMT, Matthias Baesken wrote:
>> test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java
>> line 1:
>>
>>> 1: /*
>>
>> The name of this test includes RTJar. It needs to be changed too I think.
>> Does this test actually still test something?
>
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comments
-
Changes:
- all:
On Wed, 5 Jul 2023 15:01:52 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
On Thu, 22 Jun 2023 09:21:29 GMT, Matthias Baesken wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
>> line 196:
>>
>>> 194:
>>> 195: /**
>>> 196: * Set whether or not to use ct.sym as an alternate
>>
>> As an alternate to what? This needs
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove import
-
Changes:
- all:
On Wed, 28 Jun 2023 13:22:20 GMT, Matthias Baesken wrote:
>>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is
>>> declared in module java.base, which does not export it to module java.sql'
>>> Is there any concern to export it as well to module java.sql ? And btw did
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comment in
On Wed, 28 Jun 2023 13:16:30 GMT, Alan Bateman wrote:
>> Hi Alan, regarding usage of class VM I get
>> 'package jdk.internal.misc is declared in module java.base, which does not
>> export it to module java.sql'
>> Is there any concern to export it as well to module java.sql ?
>> And btw did
On Wed, 28 Jun 2023 12:54:10 GMT, Matthias Baesken wrote:
> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is
> declared in module java.base, which does not export it to module java.sql' Is
> there any concern to export it as well to module java.sql ? And btw did you
>
On Thu, 22 Jun 2023 14:20:30 GMT, Alan Bateman wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> src/java.sql/share/classes/java/sql/DriverManager.java line 658:
>
>> 656: * (which is invoking this
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
src/java.sql/share/classes/java/sql/DriverManager.java line 658:
> 656: * (which is invoking this
On Wed, 21 Jun 2023 21:46:03 GMT, David Holmes wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
> line 196:
>
>> 194:
>> 195:
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Mostly seems okay - a couple of things need further adjusting I think.
Thanks.
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
The update to Java.gmk is good.
-
Marked as reviewed by erikj (Reviewer).
PR Review:
There are a few references to rt.jar in comments and in the codebase itself.
Some of them might be removed or adjusted.
-
Commit messages:
- JDK-8310550
Changes: https://git.openjdk.org/jdk/pull/14593/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14593=00
Issue:
20 matches
Mail list logo
