Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-09 Thread Erik Joelsson
On Wed, 9 Aug 2023 06:14:59 GMT, Andreas Steiner wrote: > I agree to add this to the nm calls in NativeCompilation.gmk. Christoph > mentioned this is used when static libraries are build. I tried the target > "static-libs-image". But this isn't working on AIX, because the ar flags -rcs > are

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-09 Thread Erik Joelsson
On Tue, 8 Aug 2023 20:50:11 GMT, Christoph Langer wrote: > > > Looks good overall. I suggest to remove the BUILD_NM variable in this PR > > > as well. We should then wait with a final review until some folks from > > > the Oracle build team are back. > > > > > > What is the motivation for

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-09 Thread Andreas Steiner
On Fri, 4 Aug 2023 14:37:04 GMT, Andreas Steiner wrote: >> On AIX we need the -X64 option for NM in the build. The handling is >> equivalent to the other used tools flags like AR. >> This change will replace the quick fix done in >> https://bugs.openjdk.org/browse/JDK-8312466. > > Andreas

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-08 Thread Christoph Langer
On Tue, 8 Aug 2023 20:14:55 GMT, Erik Joelsson wrote: > > Looks good overall. I suggest to remove the BUILD_NM variable in this PR as > > well. We should then wait with a final review until some folks from the > > Oracle build team are back. > > What is the motivation for removing BUILD_NM? I

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-08 Thread Erik Joelsson
On Fri, 4 Aug 2023 09:52:30 GMT, Christoph Langer wrote: > Looks good overall. I suggest to remove the BUILD_NM variable in this PR as > well. We should then wait with a final review until some folks from the > Oracle build team are back. What is the motivation for removing BUILD_NM? I

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-08 Thread Erik Joelsson
On Fri, 4 Aug 2023 14:37:04 GMT, Andreas Steiner wrote: >> On AIX we need the -X64 option for NM in the build. The handling is >> equivalent to the other used tools flags like AR. >> This change will replace the quick fix done in >> https://bugs.openjdk.org/browse/JDK-8312466. > > Andreas

Re: RFR: JDK-8313244: NM flags handling in configure process [v3]

2023-08-04 Thread Andreas Steiner
> On AIX we need the -X64 option for NM in the build. The handling is > equivalent to the other used tools flags like AR. > This change will replace the quick fix done in > https://bugs.openjdk.org/browse/JDK-8312466. Andreas Steiner has updated the pull request incrementally with one