Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base [v3]

2024-02-07 Thread Joe Darcy
On Wed, 7 Feb 2024 19:06:21 GMT, Weijun Wang wrote: > Security changes look fine. Although I don't know how to remove those > annotations later. A lot of compatibility impact. In case you didn't see it, the warning message are listed in an attachment on

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base [v2]

2024-02-07 Thread Joe Darcy
On Wed, 7 Feb 2024 19:28:11 GMT, Joe Darcy wrote: >> After the "this-escape" lint warning was added to javac (JDK-8015831), the >> base module was not updated to be able to compile with this warning enabled. >> This PR makes the necessary changes to allow the base module to build with >> the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base [v3]

2024-02-07 Thread Joe Darcy
> After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warning enabled. Joe Darcy has updated the pull request

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base [v2]

2024-02-07 Thread Joe Darcy
> After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warning enabled. Joe Darcy has updated the pull request

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-07 Thread Weijun Wang
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Daniel Fuchs
On Tue, 6 Feb 2024 17:29:25 GMT, Joe Darcy wrote: >> src/java.base/share/classes/sun/net/www/MessageHeader.java line 53: >> >>> 51: } >>> 52: >>> 53: @SuppressWarnings("this-escape") >> >> An alternative here could be to make the class final. AFAICS it's not >> subclassed anywhere.

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Lance Andersen
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Joe Wang
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Joe Darcy
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Joe Darcy
On Tue, 6 Feb 2024 14:35:52 GMT, Daniel Fuchs wrote: >> After the "this-escape" lint warning was added to javac (JDK-8015831), the >> base module was not updated to be able to compile with this warning enabled. >> This PR makes the necessary changes to allow the base module to build with >>

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Daniel Fuchs
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-06 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-05 Thread Stuart Marks
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-05 Thread Naoto Sato
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-05 Thread Joe Darcy
On Fri, 2 Feb 2024 23:38:41 GMT, Joe Darcy wrote: > In its initial form, the changes are tested on Linux. Later on, I'll do > cross-platform builds to make sure there aren't any, say, windows-specific > changes that are needed as well. > > I can file a follow-up umbrella bug with the original

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-05 Thread Erik Joelsson
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-03 Thread Alan Bateman
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
On Fri, 2 Feb 2024 23:38:41 GMT, Joe Darcy wrote: > In its initial form, the changes are tested on Linux. Later on, I'll do > cross-platform builds to make sure there aren't any, say, windows-specific > changes that are needed as well. > PS Builds pass on all platforms (linux, mac, and

RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled. - Commit messages: -

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the